[jira] Created: (SOLR-2133) ability to parse multiple value sources

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (SOLR-2133) ability to parse multiple value sources

JIRA jira@apache.org
ability to parse multiple value sources
---------------------------------------

                 Key: SOLR-2133
                 URL: https://issues.apache.org/jira/browse/SOLR-2133
             Project: Solr
          Issue Type: New Feature
            Reporter: Yonik Seeley


To enable things like this:
q=dist($pt)&pt=10,20
The function query parser needs to have the option of parsing a list of value sources rather than just one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-2133) ability to parse multiple value sources

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914858#action_12914858 ]

Yonik Seeley commented on SOLR-2133:
------------------------------------

Related: we should throw an exception if there is unexpected trailing stuff after parsing a value source.
For example, today a query of defType=func&q=10,20 parses the 10 and silently ignores the rest.

The behavior to parse multiple until the end of the string needs to be optional and configurable so we can only do it during parsing of sub-value sources.  If multiple value sources are parsed, they would presumably be returned as a VectorValueSource.

> ability to parse multiple value sources
> ---------------------------------------
>
>                 Key: SOLR-2133
>                 URL: https://issues.apache.org/jira/browse/SOLR-2133
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Yonik Seeley
>
> To enable things like this:
> q=dist($pt)&pt=10,20
> The function query parser needs to have the option of parsing a list of value sources rather than just one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (SOLR-2133) ability to parse multiple value sources

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley reassigned SOLR-2133:
----------------------------------

    Assignee: Yonik Seeley

> ability to parse multiple value sources
> ---------------------------------------
>
>                 Key: SOLR-2133
>                 URL: https://issues.apache.org/jira/browse/SOLR-2133
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Yonik Seeley
>            Assignee: Yonik Seeley
>
> To enable things like this:
> q=dist($pt)&pt=10,20
> The function query parser needs to have the option of parsing a list of value sources rather than just one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-2133) ability to parse multiple value sources

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley updated SOLR-2133:
-------------------------------

    Attachment: SOLR-2133.patch

Here's a patch that seems to work fine.
A query like:
    defType=func&q=10 what?
now produces an error like:    
   org.apache.lucene.queryParser.ParseException: Unexpected text after function: what?

And a query like:
    q=dist(2,vector(1,2),vector(3,4))
is equivalent to
    q=dist(2,vector(1,2),$pt)&pt=3,4

Which will make it a lot more user friendly to deal with referencing points in spatial search like
pt=lat,lon

I'll add some tests next.

> ability to parse multiple value sources
> ---------------------------------------
>
>                 Key: SOLR-2133
>                 URL: https://issues.apache.org/jira/browse/SOLR-2133
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Yonik Seeley
>            Assignee: Yonik Seeley
>         Attachments: SOLR-2133.patch
>
>
> To enable things like this:
> q=dist($pt)&pt=10,20
> The function query parser needs to have the option of parsing a list of value sources rather than just one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-2133) ability to parse multiple value sources

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley updated SOLR-2133:
-------------------------------

    Attachment: SOLR-2133.patch

And here's the patch w/ tests.

> ability to parse multiple value sources
> ---------------------------------------
>
>                 Key: SOLR-2133
>                 URL: https://issues.apache.org/jira/browse/SOLR-2133
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Yonik Seeley
>            Assignee: Yonik Seeley
>         Attachments: SOLR-2133.patch, SOLR-2133.patch
>
>
> To enable things like this:
> q=dist($pt)&pt=10,20
> The function query parser needs to have the option of parsing a list of value sources rather than just one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (SOLR-2133) ability to parse multiple value sources

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley resolved SOLR-2133.
--------------------------------

    Fix Version/s: 4.0
       Resolution: Fixed

committed.

> ability to parse multiple value sources
> ---------------------------------------
>
>                 Key: SOLR-2133
>                 URL: https://issues.apache.org/jira/browse/SOLR-2133
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Yonik Seeley
>            Assignee: Yonik Seeley
>             Fix For: 4.0
>
>         Attachments: SOLR-2133.patch, SOLR-2133.patch
>
>
> To enable things like this:
> q=dist($pt)&pt=10,20
> The function query parser needs to have the option of parsing a list of value sources rather than just one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Reopened: (SOLR-2133) ability to parse multiple value sources

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Koji Sekiguchi reopened SOLR-2133:
----------------------------------


Reopening to incorporate this into 3x.

> ability to parse multiple value sources
> ---------------------------------------
>
>                 Key: SOLR-2133
>                 URL: https://issues.apache.org/jira/browse/SOLR-2133
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Yonik Seeley
>            Assignee: Yonik Seeley
>             Fix For: 4.0
>
>         Attachments: SOLR-2133.patch, SOLR-2133.patch
>
>
> To enable things like this:
> q=dist($pt)&pt=10,20
> The function query parser needs to have the option of parsing a list of value sources rather than just one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (SOLR-2133) ability to parse multiple value sources

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Koji Sekiguchi resolved SOLR-2133.
----------------------------------

    Fix Version/s: 3.1
       Resolution: Fixed

branch_3x: Committed revision 1003741.

> ability to parse multiple value sources
> ---------------------------------------
>
>                 Key: SOLR-2133
>                 URL: https://issues.apache.org/jira/browse/SOLR-2133
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Yonik Seeley
>            Assignee: Yonik Seeley
>             Fix For: 3.1, 4.0
>
>         Attachments: SOLR-2133.patch, SOLR-2133.patch
>
>
> To enable things like this:
> q=dist($pt)&pt=10,20
> The function query parser needs to have the option of parsing a list of value sources rather than just one.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]