[jira] Created: (SOLR-2192) StreamingUpdateSolrServer not thread safe

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (SOLR-2192) StreamingUpdateSolrServer not thread safe

JIRA jira@apache.org
StreamingUpdateSolrServer not thread safe
-----------------------------------------

                 Key: SOLR-2192
                 URL: https://issues.apache.org/jira/browse/SOLR-2192
             Project: Solr
          Issue Type: Bug
    Affects Versions: 1.4.1
            Reporter: Yonik Seeley


test error method suggest thread safety violation

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-2192) StreamingUpdateSolrServer not thread safe

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924372#action_12924372 ]

Yonik Seeley commented on SOLR-2192:
------------------------------------

Build: http://hudson.zones.apache.org/hudson/job/Lucene-Solr-tests-only-3.x/508/
{noformat}
1 tests failed.
REGRESSION:  org.apache.solr.client.solrj.embedded.SolrExampleStreamingTest.testStatistics

Error Message:
null

Stack Trace:
java.util.NoSuchElementException
       at java.util.LinkedList.getFirst(LinkedList.java:126)
       at java.util.LinkedList.peek(LinkedList.java:466)
       at org.apache.solr.client.solrj.impl.StreamingUpdateSolrServer.blockUntilFinished(StreamingUpdateSolrServer.java:251)
       at org.apache.solr.client.solrj.impl.StreamingUpdateSolrServer.request(StreamingUpdateSolrServer.java:198)
       at org.apache.solr.client.solrj.request.AbstractUpdateRequest.process(AbstractUpdateRequest.java:105)
       at org.apache.solr.client.solrj.SolrServer.commit(SolrServer.java:86)
       at org.apache.solr.client.solrj.SolrServer.commit(SolrServer.java:75)
       at org.apache.solr.client.solrj.SolrExampleTests.testStatistics(SolrExampleTests.java:444)
       at org.apache.lucene.util.LuceneTestCase$LuceneTestCaseRunner.runChild(LuceneTestCase.java:779)
       at org.apache.lucene.util.LuceneTestCase$LuceneTestCaseRunner.runChild(LuceneTestCase.java:745)
{noformat}

> StreamingUpdateSolrServer not thread safe
> -----------------------------------------
>
>                 Key: SOLR-2192
>                 URL: https://issues.apache.org/jira/browse/SOLR-2192
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.4.1
>            Reporter: Yonik Seeley
>
> test error method suggest thread safety violation

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-2192) StreamingUpdateSolrServer not thread safe

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924373#action_12924373 ]

Yonik Seeley commented on SOLR-2192:
------------------------------------

The only way I figure peek() could fail is if the LinkedList was being used in a non-thread safe manner.

> StreamingUpdateSolrServer not thread safe
> -----------------------------------------
>
>                 Key: SOLR-2192
>                 URL: https://issues.apache.org/jira/browse/SOLR-2192
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.4.1
>            Reporter: Yonik Seeley
>
> test error method suggest thread safety violation

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-2192) StreamingUpdateSolrServer not thread safe

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924374#action_12924374 ]

Yonik Seeley commented on SOLR-2192:
------------------------------------

Yep - a quick look shows that "runners" is normally synchronized on itself, but it's not in
blockUntilFinished

> StreamingUpdateSolrServer not thread safe
> -----------------------------------------
>
>                 Key: SOLR-2192
>                 URL: https://issues.apache.org/jira/browse/SOLR-2192
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.4.1
>            Reporter: Yonik Seeley
>
> test error method suggest thread safety violation

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-2192) StreamingUpdateSolrServer not thread safe

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley updated SOLR-2192:
-------------------------------

    Attachment: SOLR-2192.patch

Here's a patch that synchronizes on runners only enough to call peek()

> StreamingUpdateSolrServer not thread safe
> -----------------------------------------
>
>                 Key: SOLR-2192
>                 URL: https://issues.apache.org/jira/browse/SOLR-2192
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.4.1
>            Reporter: Yonik Seeley
>         Attachments: SOLR-2192.patch
>
>
> test error method suggest thread safety violation

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (SOLR-2192) StreamingUpdateSolrServer not thread safe

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley resolved SOLR-2192.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 4.0
                   3.1
                   1.4.2

> StreamingUpdateSolrServer not thread safe
> -----------------------------------------
>
>                 Key: SOLR-2192
>                 URL: https://issues.apache.org/jira/browse/SOLR-2192
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.4.1
>            Reporter: Yonik Seeley
>             Fix For: 1.4.2, 3.1, 4.0
>
>         Attachments: SOLR-2192.patch
>
>
> test error method suggest thread safety violation

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]