[jira] Created: (SOLR-2413) Cleanup XMLWriter, remove 'version' parameter

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (SOLR-2413) Cleanup XMLWriter, remove 'version' parameter

JIRA jira@apache.org
Cleanup XMLWriter, remove 'version' parameter
---------------------------------------------

                 Key: SOLR-2413
                 URL: https://issues.apache.org/jira/browse/SOLR-2413
             Project: Solr
          Issue Type: Improvement
            Reporter: Ryan McKinley
            Priority: Minor


XMLWriter includes support for a a pre 1.0 response format where multi-valued fields are not collected together in an <arr> tag.

One problem is that many tests assume this format.

Lets remove this in 4.0

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-2413) Cleanup XMLWriter, remove 'version' parameter

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley updated SOLR-2413:
--------------------------------

    Fix Version/s: 4.0

> Cleanup XMLWriter, remove 'version' parameter
> ---------------------------------------------
>
>                 Key: SOLR-2413
>                 URL: https://issues.apache.org/jira/browse/SOLR-2413
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>            Priority: Minor
>             Fix For: 4.0
>
>
> XMLWriter includes support for a a pre 1.0 response format where multi-valued fields are not collected together in an <arr> tag.
> One problem is that many tests assume this format.
> Lets remove this in 4.0

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-2413) Cleanup XMLWriter, remove 'version' parameter

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley updated SOLR-2413:
--------------------------------

    Attachment: SOLR-2413-remove-XMLWriter-version.patch

Here is a patch that removes support for the old version, and fixes tests that depends on it.

Most of the test chagnes look like this:
{code}
-    assertQ(req("id:100"),"//str[@name='my_s'][.='quoted']");
+    assertQ(req("id:100"),"//arr[@name='my_s']/str[.='quoted']");
{code}

that is rather then just str[@name...] it is now arr[@name...]/str

This removes the multi version support added in SOLR-59



> Cleanup XMLWriter, remove 'version' parameter
> ---------------------------------------------
>
>                 Key: SOLR-2413
>                 URL: https://issues.apache.org/jira/browse/SOLR-2413
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: SOLR-2413-remove-XMLWriter-version.patch
>
>
> XMLWriter includes support for a a pre 1.0 response format where multi-valued fields are not collected together in an <arr> tag.
> One problem is that many tests assume this format.
> Lets remove this in 4.0

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-2413) Cleanup XMLWriter, remove 'version' parameter

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-2413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004705#comment-13004705 ]

Ryan McKinley commented on SOLR-2413:
-------------------------------------

I'd like to commit this soon... it will make a working version of SOLR-1566 much easier

> Cleanup XMLWriter, remove 'version' parameter
> ---------------------------------------------
>
>                 Key: SOLR-2413
>                 URL: https://issues.apache.org/jira/browse/SOLR-2413
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: SOLR-2413-remove-XMLWriter-version.patch
>
>
> XMLWriter includes support for a a pre 1.0 response format where multi-valued fields are not collected together in an <arr> tag.
> One problem is that many tests assume this format.
> Lets remove this in 4.0

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-2413) Cleanup XMLWriter, remove support for version < 2.2

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley updated SOLR-2413:
--------------------------------

    Description:
XMLWriter includes support for a a pre 1.0 response format where multi-valued fields are not collected together in an <arr> tag.

One problem is that many tests assume this format.

In 4.0, lets remove support for the old style XML formats

  was:
XMLWriter includes support for a a pre 1.0 response format where multi-valued fields are not collected together in an <arr> tag.

One problem is that many tests assume this format.

Lets remove this in 4.0

        Summary: Cleanup XMLWriter, remove support for version < 2.2  (was: Cleanup XMLWriter, remove 'version' parameter)

> Cleanup XMLWriter, remove support for version < 2.2
> ---------------------------------------------------
>
>                 Key: SOLR-2413
>                 URL: https://issues.apache.org/jira/browse/SOLR-2413
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: SOLR-2413-remove-XMLWriter-version.patch
>
>
> XMLWriter includes support for a a pre 1.0 response format where multi-valued fields are not collected together in an <arr> tag.
> One problem is that many tests assume this format.
> In 4.0, lets remove support for the old style XML formats

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-2413) Cleanup XMLWriter, remove support for version < 2.2

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-2413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004728#comment-13004728 ]

Ryan McKinley commented on SOLR-2413:
-------------------------------------

will need to update:
http://wiki.apache.org/solr/XMLResponseFormat

> Cleanup XMLWriter, remove support for version < 2.2
> ---------------------------------------------------
>
>                 Key: SOLR-2413
>                 URL: https://issues.apache.org/jira/browse/SOLR-2413
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: SOLR-2413-remove-XMLWriter-version.patch, SOLR-2413-remove-XMLWriter-version.patch
>
>
> XMLWriter includes support for a a pre 1.0 response format where multi-valued fields are not collected together in an <arr> tag.
> One problem is that many tests assume this format.
> In 4.0, lets remove support for the old style XML formats

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-2413) Cleanup XMLWriter, remove support for version < 2.2

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley updated SOLR-2413:
--------------------------------

    Attachment: SOLR-2413-remove-XMLWriter-version.patch

updated patch that does not remove the 'version' tag, just drops support for version less then 2.2

I'll make a new ticket to drop the version param

> Cleanup XMLWriter, remove support for version < 2.2
> ---------------------------------------------------
>
>                 Key: SOLR-2413
>                 URL: https://issues.apache.org/jira/browse/SOLR-2413
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: SOLR-2413-remove-XMLWriter-version.patch, SOLR-2413-remove-XMLWriter-version.patch
>
>
> XMLWriter includes support for a a pre 1.0 response format where multi-valued fields are not collected together in an <arr> tag.
> One problem is that many tests assume this format.
> In 4.0, lets remove support for the old style XML formats

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-2413) Cleanup XMLWriter, remove support for version < 2.2

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-2413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004762#comment-13004762 ]

Ryan McKinley commented on SOLR-2413:
-------------------------------------

added to /trunk in #1079963 and updated wiki

> Cleanup XMLWriter, remove support for version < 2.2
> ---------------------------------------------------
>
>                 Key: SOLR-2413
>                 URL: https://issues.apache.org/jira/browse/SOLR-2413
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: SOLR-2413-remove-XMLWriter-version.patch, SOLR-2413-remove-XMLWriter-version.patch
>
>
> XMLWriter includes support for a a pre 1.0 response format where multi-valued fields are not collected together in an <arr> tag.
> One problem is that many tests assume this format.
> In 4.0, lets remove support for the old style XML formats

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (SOLR-2413) Cleanup XMLWriter, remove support for version < 2.2

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley resolved SOLR-2413.
---------------------------------

    Resolution: Fixed
      Assignee: Ryan McKinley

> Cleanup XMLWriter, remove support for version < 2.2
> ---------------------------------------------------
>
>                 Key: SOLR-2413
>                 URL: https://issues.apache.org/jira/browse/SOLR-2413
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>            Assignee: Ryan McKinley
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: SOLR-2413-remove-XMLWriter-version.patch, SOLR-2413-remove-XMLWriter-version.patch
>
>
> XMLWriter includes support for a a pre 1.0 response format where multi-valued fields are not collected together in an <arr> tag.
> One problem is that many tests assume this format.
> In 4.0, lets remove support for the old style XML formats

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]