[jira] [Created] (SOLR-2730) Highlighting is not HTML-encoded when fallback to alternate field

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (SOLR-2730) Highlighting is not HTML-encoded when fallback to alternate field

JIRA jira@apache.org
Highlighting is not HTML-encoded when fallback to alternate field
-----------------------------------------------------------------

                 Key: SOLR-2730
                 URL: https://issues.apache.org/jira/browse/SOLR-2730
             Project: Solr
          Issue Type: Bug
          Components: highlighter
            Reporter: Jan Høydahl


When highlighter finds matches in the field and returns the snippets, all other text returned is HTML-encoded, i.e. a <br> in the field will be displayed as a literal tag instead of causing a break.

But when hl.alternateField is used, and the query does not match any words in the field, the alternate fallback field is returned as is, without being HTML-encoded.

This is inconsistent and causes problems in the client. HTML-encoding in the client is not an option since the highlighted snippets then would break.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-2730) Highlighting is not HTML-encoded when fallback to alternate field

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090963#comment-13090963 ]

Jan Høydahl commented on SOLR-2730:
-----------------------------------

Suggested fixes:
A) Always return the fallback field content HTML-encoded, as is done for normal highlighted content
B) Include a flag in the highlighting result which says whether fallback has occurred, so client can do something intelligent

> Highlighting is not HTML-encoded when fallback to alternate field
> -----------------------------------------------------------------
>
>                 Key: SOLR-2730
>                 URL: https://issues.apache.org/jira/browse/SOLR-2730
>             Project: Solr
>          Issue Type: Bug
>          Components: highlighter
>            Reporter: Jan Høydahl
>
> When highlighter finds matches in the field and returns the snippets, all other text returned is HTML-encoded, i.e. a <br> in the field will be displayed as a literal tag instead of causing a break.
> But when hl.alternateField is used, and the query does not match any words in the field, the alternate fallback field is returned as is, without being HTML-encoded.
> This is inconsistent and causes problems in the client. HTML-encoding in the client is not an option since the highlighted snippets then would break.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Issue Comment Edited] (SOLR-2730) Highlighting is not HTML-encoded when fallback to alternate field

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090963#comment-13090963 ]

Jan Høydahl edited comment on SOLR-2730 at 8/25/11 12:37 PM:
-------------------------------------------------------------

Suggested fixes:
A) Also HTML-encode fallback field content, as is done for normal highlighted content. This can be controlled with hl.htmlEncodeFallback=true to give the possibility for backwards compat
B) Include a flag in the highlighting result which says whether fallback has occurred, so client can do something intelligent


      was (Author: janhoy):
    Suggested fixes:
A) Always return the fallback field content HTML-encoded, as is done for normal highlighted content
B) Include a flag in the highlighting result which says whether fallback has occurred, so client can do something intelligent
 

> Highlighting is not HTML-encoded when fallback to alternate field
> -----------------------------------------------------------------
>
>                 Key: SOLR-2730
>                 URL: https://issues.apache.org/jira/browse/SOLR-2730
>             Project: Solr
>          Issue Type: Bug
>          Components: highlighter
>            Reporter: Jan Høydahl
>
> When highlighter finds matches in the field and returns the snippets, all other text returned is HTML-encoded, i.e. a <br> in the field will be displayed as a literal tag instead of causing a break.
> But when hl.alternateField is used, and the query does not match any words in the field, the alternate fallback field is returned as is, without being HTML-encoded.
> This is inconsistent and causes problems in the client. HTML-encoding in the client is not an option since the highlighted snippets then would break.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-2730) Highlighting is not HTML-encoded when fallback to alternate field

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13091041#comment-13091041 ]

Koji Sekiguchi commented on SOLR-2730:
--------------------------------------

Duplicate of SOLR-2603?

> Highlighting is not HTML-encoded when fallback to alternate field
> -----------------------------------------------------------------
>
>                 Key: SOLR-2730
>                 URL: https://issues.apache.org/jira/browse/SOLR-2730
>             Project: Solr
>          Issue Type: Bug
>          Components: highlighter
>            Reporter: Jan Høydahl
>
> When highlighter finds matches in the field and returns the snippets, all other text returned is HTML-encoded, i.e. a <br> in the field will be displayed as a literal tag instead of causing a break.
> But when hl.alternateField is used, and the query does not match any words in the field, the alternate fallback field is returned as is, without being HTML-encoded.
> This is inconsistent and causes problems in the client. HTML-encoding in the client is not an option since the highlighted snippets then would break.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Closed] (SOLR-2730) Highlighting is not HTML-encoded when fallback to alternate field

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Høydahl closed SOLR-2730.
-----------------------------

    Resolution: Duplicate

> Highlighting is not HTML-encoded when fallback to alternate field
> -----------------------------------------------------------------
>
>                 Key: SOLR-2730
>                 URL: https://issues.apache.org/jira/browse/SOLR-2730
>             Project: Solr
>          Issue Type: Bug
>          Components: highlighter
>            Reporter: Jan Høydahl
>
> When highlighter finds matches in the field and returns the snippets, all other text returned is HTML-encoded, i.e. a <br> in the field will be displayed as a literal tag instead of causing a break.
> But when hl.alternateField is used, and the query does not match any words in the field, the alternate fallback field is returned as is, without being HTML-encoded.
> This is inconsistent and causes problems in the client. HTML-encoding in the client is not an option since the highlighted snippets then would break.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Reopened] (SOLR-2730) Highlighting is not HTML-encoded when fallback to alternate field

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Høydahl reopened SOLR-2730:
-------------------------------

      Assignee: Jan Høydahl

Seems as this was not a duplicate after all
               

> Highlighting is not HTML-encoded when fallback to alternate field
> -----------------------------------------------------------------
>
>                 Key: SOLR-2730
>                 URL: https://issues.apache.org/jira/browse/SOLR-2730
>             Project: Solr
>          Issue Type: Bug
>          Components: highlighter
>            Reporter: Jan Høydahl
>            Assignee: Jan Høydahl
>             Fix For: 4.0, 5.0
>
>
> When highlighter finds matches in the field and returns the snippets, all other text returned is HTML-encoded, i.e. a <br> in the field will be displayed as a literal tag instead of causing a break.
> But when hl.alternateField is used, and the query does not match any words in the field, the alternate fallback field is returned as is, without being HTML-encoded.
> This is inconsistent and causes problems in the client. HTML-encoding in the client is not an option since the highlighted snippets then would break.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-2730) Highlighting is not HTML-encoded when fallback to alternate field

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Høydahl updated SOLR-2730:
------------------------------

    Fix Version/s: 5.0
                   4.0
   

> Highlighting is not HTML-encoded when fallback to alternate field
> -----------------------------------------------------------------
>
>                 Key: SOLR-2730
>                 URL: https://issues.apache.org/jira/browse/SOLR-2730
>             Project: Solr
>          Issue Type: Bug
>          Components: highlighter
>            Reporter: Jan Høydahl
>            Assignee: Jan Høydahl
>             Fix For: 4.0, 5.0
>
>
> When highlighter finds matches in the field and returns the snippets, all other text returned is HTML-encoded, i.e. a <br> in the field will be displayed as a literal tag instead of causing a break.
> But when hl.alternateField is used, and the query does not match any words in the field, the alternate fallback field is returned as is, without being HTML-encoded.
> This is inconsistent and causes problems in the client. HTML-encoding in the client is not an option since the highlighted snippets then would break.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (SOLR-2730) Highlighting is not HTML-encoded when fallback to alternate field

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Høydahl resolved SOLR-2730.
-------------------------------

       Resolution: Duplicate
    Fix Version/s:     (was: 4.0)
                       (was: 5.0)

My bad, SOLR-2603 works like a charm :)
               

> Highlighting is not HTML-encoded when fallback to alternate field
> -----------------------------------------------------------------
>
>                 Key: SOLR-2730
>                 URL: https://issues.apache.org/jira/browse/SOLR-2730
>             Project: Solr
>          Issue Type: Bug
>          Components: highlighter
>            Reporter: Jan Høydahl
>            Assignee: Jan Høydahl
>
> When highlighter finds matches in the field and returns the snippets, all other text returned is HTML-encoded, i.e. a <br> in the field will be displayed as a literal tag instead of causing a break.
> But when hl.alternateField is used, and the query does not match any words in the field, the alternate fallback field is returned as is, without being HTML-encoded.
> This is inconsistent and causes problems in the client. HTML-encoding in the client is not an option since the highlighted snippets then would break.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]