[jira] [Created] (SOLR-2959) edismax consider magic fields '_query_' and '_val_'

classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (SOLR-2959) edismax consider magic fields '_query_' and '_val_'

JIRA jira@apache.org
edismax consider magic fields '_query_' and '_val_'
---------------------------------------------------

                 Key: SOLR-2959
                 URL: https://issues.apache.org/jira/browse/SOLR-2959
             Project: Solr
          Issue Type: Bug
          Components: search
            Reporter: Michael Watts
             Fix For: 3.6


The edismax query parser should recognize '_query_' and '_val_' as so-called magic fields  rather un-prefixed query text.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-2959) edismax consider magic fields '_query_' and '_val_'

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Watts updated SOLR-2959:
--------------------------------

    Priority: Minor  (was: Major)
   

> edismax consider magic fields '_query_' and '_val_'
> ---------------------------------------------------
>
>                 Key: SOLR-2959
>                 URL: https://issues.apache.org/jira/browse/SOLR-2959
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>            Reporter: Michael Watts
>            Priority: Minor
>             Fix For: 3.6
>
>
> The edismax query parser should recognize '_query_' and '_val_' as so-called magic fields  rather un-prefixed query text.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-2959) edismax consider magic fields '_query_' and '_val_'

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Watts updated SOLR-2959:
--------------------------------

    Description: The edismax query parser should recognize '\_query\_' and '\_val\_' as so-called magic fields  rather un-prefixed query text.  (was: The edismax query parser should recognize '_query_' and '_val_' as so-called magic fields  rather un-prefixed query text.)
   

> edismax consider magic fields '_query_' and '_val_'
> ---------------------------------------------------
>
>                 Key: SOLR-2959
>                 URL: https://issues.apache.org/jira/browse/SOLR-2959
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>            Reporter: Michael Watts
>            Priority: Minor
>             Fix For: 3.6
>
>
> The edismax query parser should recognize '\_query\_' and '\_val\_' as so-called magic fields  rather un-prefixed query text.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-2959) edismax consider magic fields '_query_' and '_val_'

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Watts updated SOLR-2959:
--------------------------------

    Attachment: SOLR-2959.patch
   

> edismax consider magic fields '_query_' and '_val_'
> ---------------------------------------------------
>
>                 Key: SOLR-2959
>                 URL: https://issues.apache.org/jira/browse/SOLR-2959
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>            Reporter: Michael Watts
>            Priority: Minor
>             Fix For: 3.6
>
>         Attachments: SOLR-2959.patch
>
>
> The edismax query parser should recognize '\_query\_' and '\_val\_' as so-called magic fields  rather un-prefixed query text.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-2959) edismax consider magic fields '_query_' and '_val_'

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Watts updated SOLR-2959:
--------------------------------

    Attachment:     (was: SOLR-2959.patch)
   

> edismax consider magic fields '_query_' and '_val_'
> ---------------------------------------------------
>
>                 Key: SOLR-2959
>                 URL: https://issues.apache.org/jira/browse/SOLR-2959
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>            Reporter: Michael Watts
>            Priority: Minor
>             Fix For: 3.6
>
>         Attachments: SOLR-2959.patch
>
>
> The edismax query parser should recognize '\_query\_' and '\_val\_' as so-called magic fields  rather un-prefixed query text.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-2959) edismax consider magic fields '_query_' and '_val_'

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Watts updated SOLR-2959:
--------------------------------

    Attachment: SOLR-2959.patch

second upload of patch, this time 'granted inclusion'
               

> edismax consider magic fields '_query_' and '_val_'
> ---------------------------------------------------
>
>                 Key: SOLR-2959
>                 URL: https://issues.apache.org/jira/browse/SOLR-2959
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>            Reporter: Michael Watts
>            Priority: Minor
>             Fix For: 3.6
>
>         Attachments: SOLR-2959.patch
>
>
> The edismax query parser should recognize '\_query\_' and '\_val\_' as so-called magic fields  rather un-prefixed query text.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-2959) edismax consider magic fields '_query_' and '_val_'

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man updated SOLR-2959:
---------------------------

    Attachment: SOLR-2959.patch

Michael: thanks for your patch.

the situation has changed a bit since you opend this issue, particularly with regards to SOLR-3026 and the new support for specifying exactly which fields can/can't be used in the query string.

it appears that at the moment, (trunk) edismax supports _val_ and _query_ just fine -- and in fact the bug is sort of the reverse of before: you can't use the uf param to prevent them from working.

I've expanded on your test changes to demonstrate this in the update attachment.  will tweak issue summary shortly
               

> edismax consider magic fields '_query_' and '_val_'
> ---------------------------------------------------
>
>                 Key: SOLR-2959
>                 URL: https://issues.apache.org/jira/browse/SOLR-2959
>             Project: Solr
>          Issue Type: Bug
>          Components: query parsers
>            Reporter: Michael Watts
>            Priority: Minor
>             Fix For: 3.6
>
>         Attachments: SOLR-2959.patch, SOLR-2959.patch
>
>
> The edismax query parser should recognize '\_query\_' and '\_val\_' as so-called magic fields  rather un-prefixed query text.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-2959) edismax uf param does not work with magic fields '_query_' and '_val_'

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man updated SOLR-2959:
---------------------------

    Description: The edismax query parser should recognize the magic fields '\_query\_' and '\_val\_' as field names that can be allowed/restricted using "uf" just like any other field name.  (was: The edismax query parser should recognize '\_query\_' and '\_val\_' as so-called magic fields  rather un-prefixed query text.)
        Summary: edismax uf param does not work with magic fields '_query_' and '_val_'  (was: edismax consider magic fields '_query_' and '_val_')
   

> edismax uf param does not work with magic fields '_query_' and '_val_'
> ----------------------------------------------------------------------
>
>                 Key: SOLR-2959
>                 URL: https://issues.apache.org/jira/browse/SOLR-2959
>             Project: Solr
>          Issue Type: Bug
>          Components: query parsers
>            Reporter: Michael Watts
>            Priority: Minor
>             Fix For: 3.6
>
>         Attachments: SOLR-2959.patch, SOLR-2959.patch
>
>
> The edismax query parser should recognize the magic fields '\_query\_' and '\_val\_' as field names that can be allowed/restricted using "uf" just like any other field name.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-2959) edismax uf param does not work with magic fields '_query_' and '_val_'

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man updated SOLR-2959:
---------------------------

    Attachment: SOLR-2959.patch

updated patch: fixes tests, and fixes edismax to support the magic fields.

this patch also refactors the magic field handling in SolrQueryParser a big so the magic fields are defined by an enum to future proof us against inconsistencies if more magic fields are added down the road.
               

> edismax uf param does not work with magic fields '_query_' and '_val_'
> ----------------------------------------------------------------------
>
>                 Key: SOLR-2959
>                 URL: https://issues.apache.org/jira/browse/SOLR-2959
>             Project: Solr
>          Issue Type: Bug
>          Components: query parsers
>            Reporter: Michael Watts
>            Priority: Minor
>             Fix For: 3.6
>
>         Attachments: SOLR-2959.patch, SOLR-2959.patch, SOLR-2959.patch
>
>
> The edismax query parser should recognize the magic fields '\_query\_' and '\_val\_' as field names that can be allowed/restricted using "uf" just like any other field name.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Assigned] (SOLR-2959) edismax uf param does not work with magic fields '_query_' and '_val_'

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man reassigned SOLR-2959:
------------------------------

    Assignee: Hoss Man

feedback appreciated, but i'll assume lazy concensus and commit tomorrow if i don't get any.
               

> edismax uf param does not work with magic fields '_query_' and '_val_'
> ----------------------------------------------------------------------
>
>                 Key: SOLR-2959
>                 URL: https://issues.apache.org/jira/browse/SOLR-2959
>             Project: Solr
>          Issue Type: Bug
>          Components: query parsers
>            Reporter: Michael Watts
>            Assignee: Hoss Man
>            Priority: Minor
>             Fix For: 3.6
>
>         Attachments: SOLR-2959.patch, SOLR-2959.patch, SOLR-2959.patch
>
>
> The edismax query parser should recognize the magic fields '\_query\_' and '\_val\_' as field names that can be allowed/restricted using "uf" just like any other field name.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-2959) edismax uf param does not work with magic fields '_query_' and '_val_'

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234040#comment-13234040 ]

Yonik Seeley commented on SOLR-2959:
------------------------------------

+1, looks good.
               

> edismax uf param does not work with magic fields '_query_' and '_val_'
> ----------------------------------------------------------------------
>
>                 Key: SOLR-2959
>                 URL: https://issues.apache.org/jira/browse/SOLR-2959
>             Project: Solr
>          Issue Type: Bug
>          Components: query parsers
>            Reporter: Michael Watts
>            Assignee: Hoss Man
>            Priority: Minor
>             Fix For: 3.6
>
>         Attachments: SOLR-2959.patch, SOLR-2959.patch, SOLR-2959.patch
>
>
> The edismax query parser should recognize the magic fields '\_query\_' and '\_val\_' as field names that can be allowed/restricted using "uf" just like any other field name.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (SOLR-2959) edismax uf param does not work with magic fields '_query_' and '_val_'

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man resolved SOLR-2959.
----------------------------

       Resolution: Fixed
    Fix Version/s: 4.0

r1303265 - 3x
r1303256 - trunk

Thanks for your patch Michael! .. even with all of the other changes to edismax it helped me track down exactly what needed to be fixed.
               

> edismax uf param does not work with magic fields '_query_' and '_val_'
> ----------------------------------------------------------------------
>
>                 Key: SOLR-2959
>                 URL: https://issues.apache.org/jira/browse/SOLR-2959
>             Project: Solr
>          Issue Type: Bug
>          Components: query parsers
>            Reporter: Michael Watts
>            Assignee: Hoss Man
>            Priority: Minor
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-2959.patch, SOLR-2959.patch, SOLR-2959.patch
>
>
> The edismax query parser should recognize the magic fields '\_query\_' and '\_val\_' as field names that can be allowed/restricted using "uf" just like any other field name.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-2959) edismax uf param does not work with magic fields '_query_' and '_val_'

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234173#comment-13234173 ]

Jan H√łydahl commented on SOLR-2959:
-----------------------------------

+1 Not tested but patch looks good
               

> edismax uf param does not work with magic fields '_query_' and '_val_'
> ----------------------------------------------------------------------
>
>                 Key: SOLR-2959
>                 URL: https://issues.apache.org/jira/browse/SOLR-2959
>             Project: Solr
>          Issue Type: Bug
>          Components: query parsers
>            Reporter: Michael Watts
>            Assignee: Hoss Man
>            Priority: Minor
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-2959.patch, SOLR-2959.patch, SOLR-2959.patch
>
>
> The edismax query parser should recognize the magic fields '\_query\_' and '\_val\_' as field names that can be allowed/restricted using "uf" just like any other field name.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]