[jira] [Created] (SOLR-3052) Typo in QueryComponent Distributed grouping parameter

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (SOLR-3052) Typo in QueryComponent Distributed grouping parameter

JIRA jira@apache.org
Typo in QueryComponent Distributed grouping parameter
-----------------------------------------------------

                 Key: SOLR-3052
                 URL: https://issues.apache.org/jira/browse/SOLR-3052
             Project: Solr
          Issue Type: Bug
            Reporter: Grant Ingersoll
            Priority: Trivial
             Fix For: 3.6, 4.0


The QueryComponent on line 388 and 409 has a typo in the name of a parameter which would likely cause problems:
{code}
if (params.getBool("group.distibuted.first", false)) {
{code}

the typo being "distibuted".

Also, this param is not doc'd, so it would be good to add some docs on it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-3052) Typo in QueryComponent Distributed grouping parameter

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189322#comment-13189322 ]

Martijn van Groningen commented on SOLR-3052:
---------------------------------------------

The typo also exists in SearchGroupsRequestFactory line 74...
At least the typo is consistent :)

The reason I never documented this parameter is because it was meant to be used internally by Solr (just like field sort values (fsv) parameter). But I can understand why people might want to use this.

               

> Typo in QueryComponent Distributed grouping parameter
> -----------------------------------------------------
>
>                 Key: SOLR-3052
>                 URL: https://issues.apache.org/jira/browse/SOLR-3052
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Grant Ingersoll
>            Priority: Trivial
>             Fix For: 3.6, 4.0
>
>
> The QueryComponent on line 388 and 409 has a typo in the name of a parameter which would likely cause problems:
> {code}
> if (params.getBool("group.distibuted.first", false)) {
> {code}
> the typo being "distibuted".
> Also, this param is not doc'd, so it would be good to add some docs on it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-3052) Typo in QueryComponent Distributed grouping parameter

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206578#comment-13206578 ]

Martijn van Groningen commented on SOLR-3052:
---------------------------------------------

I accidentally committed the typo fix in the commits for SOLR-3109. I'll add changes entry in CHANGES.txt.
Grant, where do you think it is the right place to document these parameters? Wiki or jdocs?
               

> Typo in QueryComponent Distributed grouping parameter
> -----------------------------------------------------
>
>                 Key: SOLR-3052
>                 URL: https://issues.apache.org/jira/browse/SOLR-3052
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Grant Ingersoll
>            Priority: Trivial
>             Fix For: 3.6, 4.0
>
>
> The QueryComponent on line 388 and 409 has a typo in the name of a parameter which would likely cause problems:
> {code}
> if (params.getBool("group.distibuted.first", false)) {
> {code}
> the typo being "distibuted".
> Also, this param is not doc'd, so it would be good to add some docs on it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Issue Comment Edited] (SOLR-3052) Typo in QueryComponent Distributed grouping parameter

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206578#comment-13206578 ]

Martijn van Groningen edited comment on SOLR-3052 at 2/13/12 12:26 AM:
-----------------------------------------------------------------------

I accidentally committed the typo fix in the commits for SOLR-3109. I'll add changes entry in CHANGES.txt.
Grant, what do you think is the right place to document these parameters? Wiki or jdocs?
               
      was (Author: martijn.v.groningen):
    I accidentally committed the typo fix in the commits for SOLR-3109. I'll add changes entry in CHANGES.txt.
Grant, where do you think it is the right place to document these parameters? Wiki or jdocs?
                 

> Typo in QueryComponent Distributed grouping parameter
> -----------------------------------------------------
>
>                 Key: SOLR-3052
>                 URL: https://issues.apache.org/jira/browse/SOLR-3052
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Grant Ingersoll
>            Priority: Trivial
>             Fix For: 3.6, 4.0
>
>
> The QueryComponent on line 388 and 409 has a typo in the name of a parameter which would likely cause problems:
> {code}
> if (params.getBool("group.distibuted.first", false)) {
> {code}
> the typo being "distibuted".
> Also, this param is not doc'd, so it would be good to add some docs on it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Issue Comment Edited] (SOLR-3052) Typo in QueryComponent Distributed grouping parameter

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206578#comment-13206578 ]

Martijn van Groningen edited comment on SOLR-3052 at 2/13/12 12:27 AM:
-----------------------------------------------------------------------

I accidentally committed the typo fix in the commits for SOLR-3109. I'll add a changes entry in CHANGES.txt.
Grant, what do you think is the right place to document these parameters? Wiki or jdocs?
               
      was (Author: martijn.v.groningen):
    I accidentally committed the typo fix in the commits for SOLR-3109. I'll add changes entry in CHANGES.txt.
Grant, what do you think is the right place to document these parameters? Wiki or jdocs?
                 

> Typo in QueryComponent Distributed grouping parameter
> -----------------------------------------------------
>
>                 Key: SOLR-3052
>                 URL: https://issues.apache.org/jira/browse/SOLR-3052
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Grant Ingersoll
>            Priority: Trivial
>             Fix For: 3.6, 4.0
>
>
> The QueryComponent on line 388 and 409 has a typo in the name of a parameter which would likely cause problems:
> {code}
> if (params.getBool("group.distibuted.first", false)) {
> {code}
> the typo being "distibuted".
> Also, this param is not doc'd, so it would be good to add some docs on it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (SOLR-3052) Typo in QueryComponent Distributed grouping parameter

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man resolved SOLR-3052.
----------------------------

    Resolution: Fixed
      Assignee: Martijn van Groningen

resolving since it looks like everything has been commited.

Martijn: if you think it's something users should know about, i would add mention of it to the wiki ... if it's something only devs might want to be aware of then i would add it to the javadocs.

either way we should go ahead and resolve this issue as fixed in 3.6 since that's where the change was made.
               

> Typo in QueryComponent Distributed grouping parameter
> -----------------------------------------------------
>
>                 Key: SOLR-3052
>                 URL: https://issues.apache.org/jira/browse/SOLR-3052
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Grant Ingersoll
>            Assignee: Martijn van Groningen
>            Priority: Trivial
>             Fix For: 3.6, 4.0
>
>
> The QueryComponent on line 388 and 409 has a typo in the name of a parameter which would likely cause problems:
> {code}
> if (params.getBool("group.distibuted.first", false)) {
> {code}
> the typo being "distibuted".
> Also, this param is not doc'd, so it would be good to add some docs on it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-3052) Typo in QueryComponent Distributed grouping parameter

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233905#comment-13233905 ]

Martijn van Groningen commented on SOLR-3052:
---------------------------------------------

I think that this is something only devs need to know about. I'll make sure that it ends up in the jdocs.
               

> Typo in QueryComponent Distributed grouping parameter
> -----------------------------------------------------
>
>                 Key: SOLR-3052
>                 URL: https://issues.apache.org/jira/browse/SOLR-3052
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Grant Ingersoll
>            Assignee: Martijn van Groningen
>            Priority: Trivial
>             Fix For: 3.6, 4.0
>
>
> The QueryComponent on line 388 and 409 has a typo in the name of a parameter which would likely cause problems:
> {code}
> if (params.getBool("group.distibuted.first", false)) {
> {code}
> the typo being "distibuted".
> Also, this param is not doc'd, so it would be good to add some docs on it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]