[jira] [Created] (SOLR-3304) Implement spatial contrib module with LSP Lucene module

classic Classic list List threaded Threaded
31 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (SOLR-3304) Implement spatial contrib module with LSP Lucene module

JIRA jira@apache.org
Implement spatial contrib module with LSP Lucene module
-------------------------------------------------------

                 Key: SOLR-3304
                 URL: https://issues.apache.org/jira/browse/SOLR-3304
             Project: Solr
          Issue Type: Bug
            Reporter: Bill Bell


Placeholder. Get the Solr spatial module integrated with the lucene LSP module.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-3304) Implement Solr spatial contrib module with LSP Lucene module

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bill Bell updated SOLR-3304:
----------------------------

    Affects Version/s: 4.0
              Summary: Implement Solr spatial contrib module with LSP Lucene module  (was: Implement spatial contrib module with LSP Lucene module)
   

> Implement Solr spatial contrib module with LSP Lucene module
> ------------------------------------------------------------
>
>                 Key: SOLR-3304
>                 URL: https://issues.apache.org/jira/browse/SOLR-3304
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Bill Bell
>
> Placeholder. Get the Solr spatial module integrated with the lucene LSP module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-3304) Implement Solr spatial contrib module with LSP Lucene module

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bill Bell updated SOLR-3304:
----------------------------

    Description:
Placeholder. The Solr 4 glue. Get the Solr spatial module integrated with the lucene LSP module.


  was:
Placeholder. Get the Solr spatial module integrated with the lucene LSP module.


   

> Implement Solr spatial contrib module with LSP Lucene module
> ------------------------------------------------------------
>
>                 Key: SOLR-3304
>                 URL: https://issues.apache.org/jira/browse/SOLR-3304
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Bill Bell
>
> Placeholder. The Solr 4 glue. Get the Solr spatial module integrated with the lucene LSP module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-3304) Implement Solr spatial contrib module with LSP Lucene module

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244490#comment-13244490 ]

David Smiley commented on SOLR-3304:
------------------------------------

We're going to get to it; don't worry Bill.
               

> Implement Solr spatial contrib module with LSP Lucene module
> ------------------------------------------------------------
>
>                 Key: SOLR-3304
>                 URL: https://issues.apache.org/jira/browse/SOLR-3304
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Bill Bell
>
> Placeholder. The Solr 4 glue. Get the Solr spatial module integrated with the lucene LSP module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-3304) Add Solr support for the new Lucene spatial module

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Smiley updated SOLR-3304:
-------------------------------

    Description:
Get the Solr spatial module integrated with the lucene spatial module.


  was:
Placeholder. The Solr 4 glue. Get the Solr spatial module integrated with the lucene LSP module.


       Assignee: David Smiley
         Labels: spatial  (was: )
     Issue Type: New Feature  (was: Bug)
        Summary: Add Solr support for the new Lucene spatial module  (was: Implement Solr spatial contrib module with LSP Lucene module)
   

> Add Solr support for the new Lucene spatial module
> --------------------------------------------------
>
>                 Key: SOLR-3304
>                 URL: https://issues.apache.org/jira/browse/SOLR-3304
>             Project: Solr
>          Issue Type: New Feature
>    Affects Versions: 4.0
>            Reporter: Bill Bell
>            Assignee: David Smiley
>              Labels: spatial
>
> Get the Solr spatial module integrated with the lucene spatial module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-3304) Add Solr support for the new Lucene spatial module

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244937#comment-13244937 ]

Bill Bell commented on SOLR-3304:
---------------------------------

Let me know if I can help.
               

> Add Solr support for the new Lucene spatial module
> --------------------------------------------------
>
>                 Key: SOLR-3304
>                 URL: https://issues.apache.org/jira/browse/SOLR-3304
>             Project: Solr
>          Issue Type: New Feature
>    Affects Versions: 4.0
>            Reporter: Bill Bell
>            Assignee: David Smiley
>              Labels: spatial
>
> Get the Solr spatial module integrated with the lucene spatial module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-3304) Add Solr support for the new Lucene spatial module

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Smiley updated SOLR-3304:
-------------------------------

    Attachment: SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch

Attached is the first draft.

The Solr support for the new Lucene spatial module is a set of field types which are effectively adapters into the real logic in Lucene.  Even all the configuration option initialization from the fieldType attributes are done in Lucene.  A map of these is passed with a utility wrapper to detect which attributes were seen so that they can be removed afterwards. And so if you typo a parameter then you'll get an error like you would for any other field type.

The Lucene spatial module supports sorting indirectly by having a spatial Query's score be the distance.  Of course you don't always need the score/distance and so there is a local-param attribute needScore which can be set to false, such as in a filter query (see SOLR-2883).

I'll say the tests here are so-so; I welcome input on how they can be structured to be more effective.  Since the real logic is all in the Lucene spatial module, ideally the tests on the Solr side would be fairly minimal in this regard... just instantiate the various field types exercising a few features and a few options.

Some TODOs:
* Document how to use it in the wiki
* At least some basic tests for the SpatialTwoDoublesFieldType and SpatialTermQueryPrefixTreeFieldtype.

At least for now, I don't envision the capabilities here replacing the Solr spatial introduced in 3x; it is a new alternative.
               

> Add Solr support for the new Lucene spatial module
> --------------------------------------------------
>
>                 Key: SOLR-3304
>                 URL: https://issues.apache.org/jira/browse/SOLR-3304
>             Project: Solr
>          Issue Type: New Feature
>    Affects Versions: 4.0
>            Reporter: Bill Bell
>            Assignee: David Smiley
>              Labels: spatial
>         Attachments: SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch
>
>
> Get the Solr spatial module integrated with the lucene spatial module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-3304) Add Solr support for the new Lucene spatial module

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278935#comment-13278935 ]

David Smiley commented on SOLR-3304:
------------------------------------

Another TODO:
 * in solr's example schema.xml add SpatialRecursivePrefixTreeFieldType and for that matter remove the old geohash one.
               

> Add Solr support for the new Lucene spatial module
> --------------------------------------------------
>
>                 Key: SOLR-3304
>                 URL: https://issues.apache.org/jira/browse/SOLR-3304
>             Project: Solr
>          Issue Type: New Feature
>    Affects Versions: 4.0
>            Reporter: Bill Bell
>            Assignee: David Smiley
>              Labels: spatial
>         Attachments: SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch
>
>
> Get the Solr spatial module integrated with the lucene spatial module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-3304) Add Solr support for the new Lucene spatial module

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279609#comment-13279609 ]

Itamar Syn-Hershko commented on SOLR-3304:
------------------------------------------

In continuation to the discussion on the spatial4j list, +1 for having all the tests with actual spatial logic reside in the Lucene spatial module, and have the Solr tests rely on that
               

> Add Solr support for the new Lucene spatial module
> --------------------------------------------------
>
>                 Key: SOLR-3304
>                 URL: https://issues.apache.org/jira/browse/SOLR-3304
>             Project: Solr
>          Issue Type: New Feature
>    Affects Versions: 4.0
>            Reporter: Bill Bell
>            Assignee: David Smiley
>              Labels: spatial
>         Attachments: SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch
>
>
> Get the Solr spatial module integrated with the lucene spatial module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-3304) Add Solr support for the new Lucene spatial module

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397618#comment-13397618 ]

Cody Young commented on SOLR-3304:
----------------------------------

Haven't seen any movement on this in a while. What needs to be finished for this to be committed?
               

> Add Solr support for the new Lucene spatial module
> --------------------------------------------------
>
>                 Key: SOLR-3304
>                 URL: https://issues.apache.org/jira/browse/SOLR-3304
>             Project: Solr
>          Issue Type: New Feature
>    Affects Versions: 4.0
>            Reporter: Bill Bell
>            Assignee: David Smiley
>              Labels: spatial
>         Attachments: SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch
>
>
> Get the Solr spatial module integrated with the lucene spatial module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-3304) Add Solr support for the new Lucene spatial module

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397642#comment-13397642 ]

David Smiley commented on SOLR-3304:
------------------------------------

I've been slowly getting back into this.  I developed some basic documentation but I haven't put it on the wiki yet.  I think I'll start by simply adding it as new page.  I welcome input on what to name the page  since it works significantly different than the existing Solr spatial (what I call Solr 3 spatial).  I moved a particular extensive geohash based search test that is in this patch to LUCENE-4157 last night.  I think what remains as far as this code is concerned is mostly about testing various field types with their configuration, but not worrying about in-depth testing of the algorithms which instead belongs in Lucene spatial module's tests.
               

> Add Solr support for the new Lucene spatial module
> --------------------------------------------------
>
>                 Key: SOLR-3304
>                 URL: https://issues.apache.org/jira/browse/SOLR-3304
>             Project: Solr
>          Issue Type: New Feature
>    Affects Versions: 4.0
>            Reporter: Bill Bell
>            Assignee: David Smiley
>              Labels: spatial
>         Attachments: SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch
>
>
> Get the Solr spatial module integrated with the lucene spatial module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-3304) Add Solr support for the new Lucene spatial module

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403327#comment-13403327 ]

David Smiley commented on SOLR-3304:
------------------------------------

Some initial documentation: http://wiki.apache.org/solr/SolrAdaptersForLuceneSpatial4
               

> Add Solr support for the new Lucene spatial module
> --------------------------------------------------
>
>                 Key: SOLR-3304
>                 URL: https://issues.apache.org/jira/browse/SOLR-3304
>             Project: Solr
>          Issue Type: New Feature
>    Affects Versions: 4.0
>            Reporter: Bill Bell
>            Assignee: David Smiley
>              Labels: spatial
>         Attachments: SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch
>
>
> Get the Solr spatial module integrated with the lucene spatial module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-3304) Add Solr support for the new Lucene spatial module

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Smiley updated SOLR-3304:
-------------------------------

    Attachment: SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch

Here is an updated patch.

Even though Lucene spatial now has most/all of the tests that were in this patch, I feel they were short enough to just keep them here as well, in their Solr form, to demonstrate how to do queries at the Solr level.

Changes:
* Account for the Spatial4j query package moving to Lucene Spatial
* Added SpatialRecursivePrefixTreeFieldType into the example schema.xml registered with name "location_2d_trie" -- comments on name?
* Removed the old GeoHashField from the example schema.xml
* One Test file: TestSolr4Spatial that is parameterized for 3 geo fields with varying configuration.
* Added test for lat,lon order in results (which is a known failure right now).

Left to do:
* Ensure output field is lat,lon order for a geospatial context.  This should be addressed in Lucene Spatial *or* Spatial4j but probably not here, I feel.  Comments?
* Test 2d (non-geo) spatial.  Ugh.  I'd probably do another test file with similar tests, perhaps fewer.
* Fix "distErrPct" taking a fraction and not a percent. This problem is in Lucene spatial.

Concerns:
* The TwoDoubles type is not tested here. If I were to add it, it would surely break as it can't handle circles and probably has other problems.  Thoughts, Ryan? I know you wrote that one.
* Consider moving the factory stuff out of Lucene spatial into the Solr adapters?  I put them in Lucene spatial because I was thinking of the bigger picture of clients other than Solr that might use the same name-value initialization parameters.  Chris doesn't seem to be a fan because the least-common-denominator way I represented this is a Map<String,String> which is admittedly dirtly.
               

> Add Solr support for the new Lucene spatial module
> --------------------------------------------------
>
>                 Key: SOLR-3304
>                 URL: https://issues.apache.org/jira/browse/SOLR-3304
>             Project: Solr
>          Issue Type: New Feature
>    Affects Versions: 4.0
>            Reporter: Bill Bell
>            Assignee: David Smiley
>              Labels: spatial
>         Attachments: SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch
>
>
> Get the Solr spatial module integrated with the lucene spatial module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-3304) Add Solr support for the new Lucene spatial module

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Smiley updated SOLR-3304:
-------------------------------

    Attachment: SOLR-3304_Solr_fields_for_Lucene_spatial_module (fieldName in Strategy).patch

Attached is a new patch which assumes LUCENE-4188 (Strategy doesn't store shapes, and puts fieldName in Strategy) and LUCENE-4192 (no single createField()).
               

> Add Solr support for the new Lucene spatial module
> --------------------------------------------------
>
>                 Key: SOLR-3304
>                 URL: https://issues.apache.org/jira/browse/SOLR-3304
>             Project: Solr
>          Issue Type: New Feature
>    Affects Versions: 4.0
>            Reporter: Bill Bell
>            Assignee: David Smiley
>              Labels: spatial
>         Attachments: SOLR-3304_Solr_fields_for_Lucene_spatial_module (fieldName in Strategy).patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch
>
>
> Get the Solr spatial module integrated with the lucene spatial module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-3304) Add Solr support for the new Lucene spatial module

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andy Fowler updated SOLR-3304:
------------------------------

    Attachment: SOLR-3304_Solr_fields_for_Lucene_spatial_module (fieldName in Strategy) - indexableFields.patch

I've been playing around with this against the current 4x branch. I've attached the original patch with one small tweak to AbstractSpatialFieldType.createFields, fixing a bug caught at compile-time.

I'm pretty far out of my league trying to work on this, but I'm getting an NPE at AbstractSpatialFieldType.getQueryFromSpatialArgs(AbstractSpatialFieldType.java:178). It appears that createFields is never being called, so the fieldStrategyMap is empty when a query arrives. Not sure where in the lifecycle createFields is supposed to happen.

Just throwing my progress out there for others looking at this.
               

> Add Solr support for the new Lucene spatial module
> --------------------------------------------------
>
>                 Key: SOLR-3304
>                 URL: https://issues.apache.org/jira/browse/SOLR-3304
>             Project: Solr
>          Issue Type: New Feature
>    Affects Versions: 4.0-ALPHA
>            Reporter: Bill Bell
>            Assignee: David Smiley
>              Labels: spatial
>         Attachments: SOLR-3304_Solr_fields_for_Lucene_spatial_module (fieldName in Strategy) - indexableFields.patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module (fieldName in Strategy).patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch
>
>
> Get the Solr spatial module integrated with the lucene spatial module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-3304) Add Solr support for the new Lucene spatial module

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andy Fowler updated SOLR-3304:
------------------------------

    Attachment: SOLR-3304-strategy-getter-fixed.patch

Attached is one more update to David Smiley's patch which resolves the NPE I was getting when trying to query on a geo field, before a document had been added (i.e. after restarting solr with an already-created index).

Instead of assuming that the spacialStrategy had been instantiated during CreateFields, the same logic is used at query-time.

It applies cleanly to branch_4x and all tests pass for me. Thanks for your work on this, David!
               

> Add Solr support for the new Lucene spatial module
> --------------------------------------------------
>
>                 Key: SOLR-3304
>                 URL: https://issues.apache.org/jira/browse/SOLR-3304
>             Project: Solr
>          Issue Type: New Feature
>    Affects Versions: 4.0-ALPHA
>            Reporter: Bill Bell
>            Assignee: David Smiley
>              Labels: spatial
>         Attachments: SOLR-3304_Solr_fields_for_Lucene_spatial_module (fieldName in Strategy) - indexableFields.patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module (fieldName in Strategy).patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch, SOLR-3304-strategy-getter-fixed.patch
>
>
> Get the Solr spatial module integrated with the lucene spatial module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-3304) Add Solr support for the new Lucene spatial module

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Smiley updated SOLR-3304:
-------------------------------

    Attachment: SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch

Thanks for finding and fixing that bug Andy. Your fix wasn't quite right though since the getStrategy() method you refactored synchronized on a parameter (pointless) instead of the field. I fixed this.

This new patch makes that and various other changes:
* synchronized with the latest source tree (e.g. Spatial4j 0.3)
** This means distances are now degrees based (0-180 for circle radius) not kilometers
* removed ignoreIncompatibleGeometry option (see LUCENE-4173)
* Use the input string as the stored value that is returned.  So if you give "lat,lon" then that's what you get back, in whatever number of decimal places you chose.
* added prefixGridScanLevel performance tuning option to SpatialRecursivePrefixTreeFieldType (simply exposed it from the strategy)
* keep distErrPct as a fraction (no change)

It would be nice to have a kilometer unit option but that isn't easily done until Spatial4j's shape reader gets to be more flexible.  That can wait.

That "needScore" local-param hack (see SOLR-2883) is unfortunate, as Solr can't get a Filter from a field type.  I'm tempted to change the default to 'false' as leaving it at true' triggers large RAM requirements and slow-downs for SpatialRecursivePrefixTreeFieldType.  This could be an opportunity to specify what the score should be, come to think of it.  Instead of needScore="false", maybe score="none" (default) or score="distance" or score="recipDistance" or something like that.

The TwoDoubles strategy needs more attention and tests in Lucene spatial, but I don't want that to hold up this patch.  Shall I remove the adapter or let it get committed but don't advertise it until it's more worthy?
               

> Add Solr support for the new Lucene spatial module
> --------------------------------------------------
>
>                 Key: SOLR-3304
>                 URL: https://issues.apache.org/jira/browse/SOLR-3304
>             Project: Solr
>          Issue Type: New Feature
>    Affects Versions: 4.0-ALPHA
>            Reporter: Bill Bell
>            Assignee: David Smiley
>              Labels: spatial
>         Attachments: SOLR-3304_Solr_fields_for_Lucene_spatial_module (fieldName in Strategy) - indexableFields.patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module (fieldName in Strategy).patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch, SOLR-3304-strategy-getter-fixed.patch
>
>
> Get the Solr spatial module integrated with the lucene spatial module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-3304) Add Solr support for the new Lucene spatial module

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455401#comment-13455401 ]

Andy Fowler commented on SOLR-3304:
-----------------------------------

Thanks David! I'm just getting back to looking at this. We previously used your SOLR-2155 patch, and this one is a big deal to us. It looks like you're depending on Lucene 5 StorableField in the fieldtype (from LUCENE-3312). I can't tell from that ticket if those changes are planned to be backported.
               

> Add Solr support for the new Lucene spatial module
> --------------------------------------------------
>
>                 Key: SOLR-3304
>                 URL: https://issues.apache.org/jira/browse/SOLR-3304
>             Project: Solr
>          Issue Type: New Feature
>    Affects Versions: 4.0-ALPHA
>            Reporter: Bill Bell
>            Assignee: David Smiley
>              Labels: spatial
>         Attachments: SOLR-3304_Solr_fields_for_Lucene_spatial_module (fieldName in Strategy) - indexableFields.patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module (fieldName in Strategy).patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch, SOLR-3304-strategy-getter-fixed.patch
>
>
> Get the Solr spatial module integrated with the lucene spatial module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-3304) Add Solr support for the new Lucene spatial module

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455542#comment-13455542 ]

David Smiley commented on SOLR-3304:
------------------------------------

RE StorableField -- small details like that I work out at commit time.  I develop against trunk and then the 4x backport has been trivial.
               

> Add Solr support for the new Lucene spatial module
> --------------------------------------------------
>
>                 Key: SOLR-3304
>                 URL: https://issues.apache.org/jira/browse/SOLR-3304
>             Project: Solr
>          Issue Type: New Feature
>    Affects Versions: 4.0-ALPHA
>            Reporter: Bill Bell
>            Assignee: David Smiley
>              Labels: spatial
>         Attachments: SOLR-3304_Solr_fields_for_Lucene_spatial_module (fieldName in Strategy) - indexableFields.patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module (fieldName in Strategy).patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch, SOLR-3304-strategy-getter-fixed.patch
>
>
> Get the Solr spatial module integrated with the lucene spatial module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-3304) Add Solr support for the new Lucene spatial module

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Smiley updated SOLR-3304:
-------------------------------

    Fix Version/s: 4.0
   

> Add Solr support for the new Lucene spatial module
> --------------------------------------------------
>
>                 Key: SOLR-3304
>                 URL: https://issues.apache.org/jira/browse/SOLR-3304
>             Project: Solr
>          Issue Type: New Feature
>    Affects Versions: 4.0-ALPHA
>            Reporter: Bill Bell
>            Assignee: David Smiley
>              Labels: spatial
>             Fix For: 4.0
>
>         Attachments: SOLR-3304_Solr_fields_for_Lucene_spatial_module (fieldName in Strategy) - indexableFields.patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module (fieldName in Strategy).patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch, SOLR-3304_Solr_fields_for_Lucene_spatial_module.patch, SOLR-3304-strategy-getter-fixed.patch
>
>
> Get the Solr spatial module integrated with the lucene spatial module.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

12