[jira] Created: (SOLR-348) faceting, highlighting, mlt, should short circut when no matches

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (SOLR-348) faceting, highlighting, mlt, should short circut when no matches

JIRA jira@apache.org
faceting, highlighting, mlt, should short circut when no matches
----------------------------------------------------------------

                 Key: SOLR-348
                 URL: https://issues.apache.org/jira/browse/SOLR-348
             Project: Solr
          Issue Type: Bug
            Reporter: Hoss Man


all code in the core handlers that operates on the DocSet or DocList produced from a "main" serach should be smart enough to give up immediately when the DocList/DocSet is empty.

optimizations could be put in the handlers, but the definitely need to be put in the utility classes (so consumer written handlers benefit as well)

http://www.nabble.com/Slow-response-tf4394686.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-348) faceting, highlighting, mlt, should short circut when no matches

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12525578 ]

Mike Klaas commented on SOLR-348:
---------------------------------

Note that highlighting already has short circuiting for hl!=true, and does almost no work when the DocList is empty.  

> faceting, highlighting, mlt, should short circut when no matches
> ----------------------------------------------------------------
>
>                 Key: SOLR-348
>                 URL: https://issues.apache.org/jira/browse/SOLR-348
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Hoss Man
>
> all code in the core handlers that operates on the DocSet or DocList produced from a "main" serach should be smart enough to give up immediately when the DocList/DocSet is empty.
> optimizations could be put in the handlers, but the definitely need to be put in the utility classes (so consumer written handlers benefit as well)
> http://www.nabble.com/Slow-response-tf4394686.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-348) faceting, highlighting, mlt, should short circut when no matches

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12525583 ]

Yonik Seeley commented on SOLR-348:
-----------------------------------

For faceting, docset.size() should be compared to mincount.

> faceting, highlighting, mlt, should short circut when no matches
> ----------------------------------------------------------------
>
>                 Key: SOLR-348
>                 URL: https://issues.apache.org/jira/browse/SOLR-348
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Hoss Man
>
> all code in the core handlers that operates on the DocSet or DocList produced from a "main" serach should be smart enough to give up immediately when the DocList/DocSet is empty.
> optimizations could be put in the handlers, but the definitely need to be put in the utility classes (so consumer written handlers benefit as well)
> http://www.nabble.com/Slow-response-tf4394686.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-348) faceting, highlighting, mlt, should short circut when no matches

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley updated SOLR-348:
------------------------------

    Attachment: facet.patch

Here's a patch for the faceting part that should work.

> faceting, highlighting, mlt, should short circut when no matches
> ----------------------------------------------------------------
>
>                 Key: SOLR-348
>                 URL: https://issues.apache.org/jira/browse/SOLR-348
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Hoss Man
>         Attachments: facet.patch
>
>
> all code in the core handlers that operates on the DocSet or DocList produced from a "main" serach should be smart enough to give up immediately when the DocList/DocSet is empty.
> optimizations could be put in the handlers, but the definitely need to be put in the utility classes (so consumer written handlers benefit as well)
> http://www.nabble.com/Slow-response-tf4394686.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (SOLR-348) faceting, highlighting, mlt, should short circut when no matches

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley resolved SOLR-348.
-------------------------------

    Resolution: Fixed

committed faceting part, and closing.
if a separate component has an issue with no docs matching, we can open a separate issue.

> faceting, highlighting, mlt, should short circut when no matches
> ----------------------------------------------------------------
>
>                 Key: SOLR-348
>                 URL: https://issues.apache.org/jira/browse/SOLR-348
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Hoss Man
>         Attachments: facet.patch
>
>
> all code in the core handlers that operates on the DocSet or DocList produced from a "main" serach should be smart enough to give up immediately when the DocList/DocSet is empty.
> optimizations could be put in the handlers, but the definitely need to be put in the utility classes (so consumer written handlers benefit as well)
> http://www.nabble.com/Slow-response-tf4394686.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.