[jira] [Created] (SOLR-3717) DirectoryFactory.close() is never called

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (SOLR-3717) DirectoryFactory.close() is never called

JIRA jira@apache.org
Hoss Man created SOLR-3717:
------------------------------

             Summary: DirectoryFactory.close() is never called
                 Key: SOLR-3717
                 URL: https://issues.apache.org/jira/browse/SOLR-3717
             Project: Solr
          Issue Type: Bug
            Reporter: Hoss Man
             Fix For: 5.0, 4.0


While working on SOLR-3699 i noticed that DirectoryFactory implements Closable (and thus: has a close() method) but (unless i'm missing something) never gets closed.

I suspect the code that use to close() the DirectoryFactory got refactored into oblivion when SolrCoreState was introduced, and reloading a SolrCore started reusing the same DirectoryFactory.

it seems like either DirectoryFactory should no longer have a close() method, or something at the CoreContainer level should ensure that all DirectoryFactories are closed when shuting down

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (SOLR-3717) DirectoryFactory.close() is never called

JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-3717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430395#comment-13430395 ]

Mark Miller commented on SOLR-3717:
-----------------------------------

started looking into this - I see a dir factory close in DefaultSolrCoreState around line 148?
               

> DirectoryFactory.close() is never called
> ----------------------------------------
>
>                 Key: SOLR-3717
>                 URL: https://issues.apache.org/jira/browse/SOLR-3717
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Hoss Man
>             Fix For: 5.0, 4.0
>
>
> While working on SOLR-3699 i noticed that DirectoryFactory implements Closable (and thus: has a close() method) but (unless i'm missing something) never gets closed.
> I suspect the code that use to close() the DirectoryFactory got refactored into oblivion when SolrCoreState was introduced, and reloading a SolrCore started reusing the same DirectoryFactory.
> it seems like either DirectoryFactory should no longer have a close() method, or something at the CoreContainer level should ensure that all DirectoryFactories are closed when shuting down

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (SOLR-3717) DirectoryFactory.close() is never called

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-3717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man resolved SOLR-3717.
----------------------------

    Resolution: Not A Problem

thanks mark, i definitely missed seeing that.
               

> DirectoryFactory.close() is never called
> ----------------------------------------
>
>                 Key: SOLR-3717
>                 URL: https://issues.apache.org/jira/browse/SOLR-3717
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Hoss Man
>             Fix For: 5.0, 4.0
>
>
> While working on SOLR-3699 i noticed that DirectoryFactory implements Closable (and thus: has a close() method) but (unless i'm missing something) never gets closed.
> I suspect the code that use to close() the DirectoryFactory got refactored into oblivion when SolrCoreState was introduced, and reloading a SolrCore started reusing the same DirectoryFactory.
> it seems like either DirectoryFactory should no longer have a close() method, or something at the CoreContainer level should ensure that all DirectoryFactories are closed when shuting down

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]