[jira] [Created] (SOLR-4107) Parse Error message lost from 3.5.0 to 3.6.1

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (SOLR-4107) Parse Error message lost from 3.5.0 to 3.6.1

JIRA jira@apache.org
Pierre Gossé created SOLR-4107:
----------------------------------

             Summary: Parse Error message lost from 3.5.0 to 3.6.1
                 Key: SOLR-4107
                 URL: https://issues.apache.org/jira/browse/SOLR-4107
             Project: Solr
          Issue Type: Bug
          Components: search
    Affects Versions: 3.6.1
            Reporter: Pierre Gossé
            Priority: Minor


QueryComponent.prepare builds a SolrException from ParseException encountered, using a constructor that forces error message to null

in 3.5.0
public SolrException(ErrorCode code, Throwable th) {
   super(th);
   this.code=code.code;
   logged=true;
}


in 3.6.1 :
public SolrException(ErrorCode code, Throwable th) {
   this(code, null, th, (th instanceof SolrException) ? ((SolrException)th).logged : false);
}
calling :
public SolrException(ErrorCode code, String msg, Throwable th, boolean alreadyLogged) {
   super(msg,th);
   this.code=code.code;
   logged=alreadyLogged;
}

I don't think this is a desired behaviour, so I guessed this should be corrected by changing line 93 to
   this(code, th.getMessage(), th, (th instanceof SolrException) ?(SolrException)th).logged : false);

I'll try to add a patch later today.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-4107) Parse Error message lost from 3.5.0 to 3.6.1

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-4107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pierre Gossé updated SOLR-4107:
-------------------------------


Oups, this class is in solrj, so I'm not sure component "search" is appropriate.
               

> Parse Error message lost from 3.5.0 to 3.6.1
> --------------------------------------------
>
>                 Key: SOLR-4107
>                 URL: https://issues.apache.org/jira/browse/SOLR-4107
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 3.6.1
>            Reporter: Pierre Gossé
>            Priority: Minor
>
> QueryComponent.prepare builds a SolrException from ParseException encountered, using a constructor that forces error message to null
> in 3.5.0
> public SolrException(ErrorCode code, Throwable th) {
>    super(th);
>    this.code=code.code;
>    logged=true;
> }
> in 3.6.1 :
> public SolrException(ErrorCode code, Throwable th) {
>    this(code, null, th, (th instanceof SolrException) ? ((SolrException)th).logged : false);
> }
> calling :
> public SolrException(ErrorCode code, String msg, Throwable th, boolean alreadyLogged) {
>    super(msg,th);
>    this.code=code.code;
>    logged=alreadyLogged;
> }
> I don't think this is a desired behaviour, so I guessed this should be corrected by changing line 93 to
>    this(code, th.getMessage(), th, (th instanceof SolrException) ?(SolrException)th).logged : false);
> I'll try to add a patch later today.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]