[jira] Created: (SOLR-472) SolrResourceLoader calls normalizeDir twice on when the input instanceDir is null

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (SOLR-472) SolrResourceLoader calls normalizeDir twice on when the input instanceDir is null

JIRA jira@apache.org
SolrResourceLoader calls normalizeDir twice on when the input instanceDir is null
---------------------------------------------------------------------------------

                 Key: SOLR-472
                 URL: https://issues.apache.org/jira/browse/SOLR-472
             Project: Solr
          Issue Type: Improvement
            Reporter: Grant Ingersoll
            Assignee: Grant Ingersoll
            Priority: Trivial


Minor nit I noticed while looking at the SolrResourceLoader:
When the instanceDir is null upon constructing a SolrResourceLoader, normalizeDir is called twice, once by locateInstanceDir, and then again in the constructor.  

Patch to follow that also adds some docs on it and a simple unit test, etc.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-472) SolrResourceLoader calls normalizeDir twice on when the input instanceDir is null

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll updated SOLR-472:
---------------------------------

    Attachment: SOLR-472.patch

Adds a unit test, cleans up so that normalizeDir is only called once when finding the instanceDir and adds some docs.

> SolrResourceLoader calls normalizeDir twice on when the input instanceDir is null
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-472
>                 URL: https://issues.apache.org/jira/browse/SOLR-472
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Trivial
>         Attachments: SOLR-472.patch
>
>
> Minor nit I noticed while looking at the SolrResourceLoader:
> When the instanceDir is null upon constructing a SolrResourceLoader, normalizeDir is called twice, once by locateInstanceDir, and then again in the constructor.  
> Patch to follow that also adds some docs on it and a simple unit test, etc.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-472) SolrResourceLoader calls normalizeDir twice on when the input instanceDir is null

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565907#action_12565907 ]

Ryan McKinley commented on SOLR-472:
------------------------------------

looks good.  I'll commit in a sec..

> SolrResourceLoader calls normalizeDir twice on when the input instanceDir is null
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-472
>                 URL: https://issues.apache.org/jira/browse/SOLR-472
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Trivial
>         Attachments: SOLR-472.patch
>
>
> Minor nit I noticed while looking at the SolrResourceLoader:
> When the instanceDir is null upon constructing a SolrResourceLoader, normalizeDir is called twice, once by locateInstanceDir, and then again in the constructor.  
> Patch to follow that also adds some docs on it and a simple unit test, etc.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (SOLR-472) SolrResourceLoader calls normalizeDir twice on when the input instanceDir is null

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley resolved SOLR-472.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3

thanks grant!

> SolrResourceLoader calls normalizeDir twice on when the input instanceDir is null
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-472
>                 URL: https://issues.apache.org/jira/browse/SOLR-472
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Trivial
>             Fix For: 1.3
>
>         Attachments: SOLR-472.patch
>
>
> Minor nit I noticed while looking at the SolrResourceLoader:
> When the instanceDir is null upon constructing a SolrResourceLoader, normalizeDir is called twice, once by locateInstanceDir, and then again in the constructor.  
> Patch to follow that also adds some docs on it and a simple unit test, etc.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.