[jira] Created: (SOLR-501) /admin/analysis.jsp does not decode input string as UTF-8 sequence.

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (SOLR-501) /admin/analysis.jsp does not decode input string as UTF-8 sequence.

JIRA jira@apache.org
/admin/analysis.jsp does not decode input string as UTF-8 sequence.
-------------------------------------------------------------------

                 Key: SOLR-501
                 URL: https://issues.apache.org/jira/browse/SOLR-501
             Project: Solr
          Issue Type: Bug
          Components: web gui
         Environment: Tomcat6.0
            Reporter: Hiroaki Kawai


In servlet2.5, we should call HttpRequestServlet.setCharacterEncoding("UTF-8") to get a UTF-8 character sequence via request.getParameter() in JSP.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-501) /admin/analysis.jsp does not decode input string as UTF-8 sequence.

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hiroaki Kawai updated SOLR-501:
-------------------------------

    Attachment: header.jsp.patch

> /admin/analysis.jsp does not decode input string as UTF-8 sequence.
> -------------------------------------------------------------------
>
>                 Key: SOLR-501
>                 URL: https://issues.apache.org/jira/browse/SOLR-501
>             Project: Solr
>          Issue Type: Bug
>          Components: web gui
>         Environment: Tomcat6.0
>            Reporter: Hiroaki Kawai
>         Attachments: header.jsp.patch
>
>
> In servlet2.5, we should call HttpRequestServlet.setCharacterEncoding("UTF-8") to get a UTF-8 character sequence via request.getParameter() in JSP.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-501) /admin/analysis.jsp does not decode input string as UTF-8 sequence.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612697#action_12612697 ]

Ryan McKinley commented on SOLR-501:
------------------------------------

Has anyone looked at this?  Any reason *not* to default the jsp pages to UTF-8?

> /admin/analysis.jsp does not decode input string as UTF-8 sequence.
> -------------------------------------------------------------------
>
>                 Key: SOLR-501
>                 URL: https://issues.apache.org/jira/browse/SOLR-501
>             Project: Solr
>          Issue Type: Bug
>          Components: web gui
>         Environment: Tomcat6.0
>            Reporter: Hiroaki Kawai
>         Attachments: header.jsp.patch
>
>
> In servlet2.5, we should call HttpRequestServlet.setCharacterEncoding("UTF-8") to get a UTF-8 character sequence via request.getParameter() in JSP.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (SOLR-501) /admin/analysis.jsp does not decode input string as UTF-8 sequence.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley reassigned SOLR-501:
----------------------------------

    Assignee: Ryan McKinley

> /admin/analysis.jsp does not decode input string as UTF-8 sequence.
> -------------------------------------------------------------------
>
>                 Key: SOLR-501
>                 URL: https://issues.apache.org/jira/browse/SOLR-501
>             Project: Solr
>          Issue Type: Bug
>          Components: web gui
>         Environment: Tomcat6.0
>            Reporter: Hiroaki Kawai
>            Assignee: Ryan McKinley
>             Fix For: 1.3
>
>         Attachments: header.jsp.patch
>
>
> In servlet2.5, we should call HttpRequestServlet.setCharacterEncoding("UTF-8") to get a UTF-8 character sequence via request.getParameter() in JSP.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-501) /admin/analysis.jsp does not decode input string as UTF-8 sequence.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley updated SOLR-501:
-------------------------------

    Fix Version/s: 1.3

> /admin/analysis.jsp does not decode input string as UTF-8 sequence.
> -------------------------------------------------------------------
>
>                 Key: SOLR-501
>                 URL: https://issues.apache.org/jira/browse/SOLR-501
>             Project: Solr
>          Issue Type: Bug
>          Components: web gui
>         Environment: Tomcat6.0
>            Reporter: Hiroaki Kawai
>            Assignee: Ryan McKinley
>             Fix For: 1.3
>
>         Attachments: header.jsp.patch
>
>
> In servlet2.5, we should call HttpRequestServlet.setCharacterEncoding("UTF-8") to get a UTF-8 character sequence via request.getParameter() in JSP.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-501) /admin/analysis.jsp does not decode input string as UTF-8 sequence.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612712#action_12612712 ]

Yonik Seeley commented on SOLR-501:
-----------------------------------

bq. Any reason not to default the jsp pages to UTF-8?

We do want to default to UTF8, but we still sort of support Tomcat 5.5 with this release, which is only up to servlet spec 2.4 .  The comment suggests this API call suggests this is new for 2.5?

> /admin/analysis.jsp does not decode input string as UTF-8 sequence.
> -------------------------------------------------------------------
>
>                 Key: SOLR-501
>                 URL: https://issues.apache.org/jira/browse/SOLR-501
>             Project: Solr
>          Issue Type: Bug
>          Components: web gui
>         Environment: Tomcat6.0
>            Reporter: Hiroaki Kawai
>            Assignee: Ryan McKinley
>             Fix For: 1.3
>
>         Attachments: header.jsp.patch
>
>
> In servlet2.5, we should call HttpRequestServlet.setCharacterEncoding("UTF-8") to get a UTF-8 character sequence via request.getParameter() in JSP.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-501) /admin/analysis.jsp does not decode input string as UTF-8 sequence.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Kotthoff updated SOLR-501:
-------------------------------

    Attachment: SOLR-501.patch

The method setCharacterEncoding() is also part of the 2.4 servlet spec, I've just tested it successfully with Tomcat 5.5.

However, if everything is to be passed around as UTF-8, the Content-Type header of the pages should indicate this and the accept-charset of the forms should be set to UTF-8. I've attached a path which makes the necessary changes.

> /admin/analysis.jsp does not decode input string as UTF-8 sequence.
> -------------------------------------------------------------------
>
>                 Key: SOLR-501
>                 URL: https://issues.apache.org/jira/browse/SOLR-501
>             Project: Solr
>          Issue Type: Bug
>          Components: web gui
>         Environment: Tomcat6.0
>            Reporter: Hiroaki Kawai
>            Assignee: Ryan McKinley
>             Fix For: 1.3
>
>         Attachments: header.jsp.patch, SOLR-501.patch
>
>
> In servlet2.5, we should call HttpRequestServlet.setCharacterEncoding("UTF-8") to get a UTF-8 character sequence via request.getParameter() in JSP.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-501) /admin/analysis.jsp does not decode input string as UTF-8 sequence.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613092#action_12613092 ]

Yonik Seeley commented on SOLR-501:
-----------------------------------

I reproduced the problem... UTF8 work on Jetty (which nicely defaults to UTF-8) and does not work on Tomcat (on 5.5 at least).

> /admin/analysis.jsp does not decode input string as UTF-8 sequence.
> -------------------------------------------------------------------
>
>                 Key: SOLR-501
>                 URL: https://issues.apache.org/jira/browse/SOLR-501
>             Project: Solr
>          Issue Type: Bug
>          Components: web gui
>         Environment: Tomcat6.0
>            Reporter: Hiroaki Kawai
>            Assignee: Ryan McKinley
>             Fix For: 1.3
>
>         Attachments: header.jsp.patch, SOLR-501.patch
>
>
> In servlet2.5, we should call HttpRequestServlet.setCharacterEncoding("UTF-8") to get a UTF-8 character sequence via request.getParameter() in JSP.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (SOLR-501) /admin/analysis.jsp does not decode input string as UTF-8 sequence.

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley resolved SOLR-501.
-------------------------------

    Resolution: Fixed

I just committed this after testing with jetty & tomcat, firefox & IE.
Thanks!

> /admin/analysis.jsp does not decode input string as UTF-8 sequence.
> -------------------------------------------------------------------
>
>                 Key: SOLR-501
>                 URL: https://issues.apache.org/jira/browse/SOLR-501
>             Project: Solr
>          Issue Type: Bug
>          Components: web gui
>         Environment: Tomcat6.0
>            Reporter: Hiroaki Kawai
>            Assignee: Ryan McKinley
>             Fix For: 1.3
>
>         Attachments: header.jsp.patch, SOLR-501.patch
>
>
> In servlet2.5, we should call HttpRequestServlet.setCharacterEncoding("UTF-8") to get a UTF-8 character sequence via request.getParameter() in JSP.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.