[jira] Created: (SOLR-531) rsyncd-start and snappuller should exit with different exit code when disabled

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (SOLR-531) rsyncd-start and snappuller should exit with different exit code when disabled

JIRA jira@apache.org
rsyncd-start and snappuller should exit with different exit code when disabled
------------------------------------------------------------------------------

                 Key: SOLR-531
                 URL: https://issues.apache.org/jira/browse/SOLR-531
             Project: Solr
          Issue Type: Improvement
          Components: replication
    Affects Versions: 1.3
            Reporter: Thomas Peuss


When the rsyncd-start and snappuller scripts get executed the scripts check if they are enabled or not. If they are disabled they exit with 1. The scripts exit with 1 on error as well. So you cannot decide in upstream scripts if really an error occurred or if they are only disabled.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-531) rsyncd-start and snappuller should exit with different exit code when disabled

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Peuss updated SOLR-531:
------------------------------

    Attachment: SOLR-531.patch

The patch changes the exit code to 2 when the scripts are disabled.

> rsyncd-start and snappuller should exit with different exit code when disabled
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-531
>                 URL: https://issues.apache.org/jira/browse/SOLR-531
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication
>    Affects Versions: 1.3
>            Reporter: Thomas Peuss
>         Attachments: SOLR-531.patch
>
>
> When the rsyncd-start and snappuller scripts get executed the scripts check if they are enabled or not. If they are disabled they exit with 1. The scripts exit with 1 on error as well. So you cannot decide in upstream scripts if really an error occurred or if they are only disabled.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-531) rsyncd-start and snappuller should exit with different exit code when disabled

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Peuss updated SOLR-531:
------------------------------

    Priority: Trivial  (was: Major)

> rsyncd-start and snappuller should exit with different exit code when disabled
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-531
>                 URL: https://issues.apache.org/jira/browse/SOLR-531
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication
>    Affects Versions: 1.3
>            Reporter: Thomas Peuss
>            Priority: Trivial
>         Attachments: SOLR-531.patch
>
>
> When the rsyncd-start and snappuller scripts get executed the scripts check if they are enabled or not. If they are disabled they exit with 1. The scripts exit with 1 on error as well. So you cannot decide in upstream scripts if really an error occurred or if they are only disabled.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (SOLR-531) rsyncd-start and snappuller should exit with different exit code when disabled

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

    [ https://issues.apache.org/jira/browse/SOLR-531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585100#action_12585100 ]

Bill Au commented on SOLR-531:
------------------------------

The patch looks good to me.  I will apply it if no one objects.

> rsyncd-start and snappuller should exit with different exit code when disabled
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-531
>                 URL: https://issues.apache.org/jira/browse/SOLR-531
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication
>    Affects Versions: 1.3
>            Reporter: Thomas Peuss
>            Priority: Trivial
>         Attachments: SOLR-531.patch
>
>
> When the rsyncd-start and snappuller scripts get executed the scripts check if they are enabled or not. If they are disabled they exit with 1. The scripts exit with 1 on error as well. So you cannot decide in upstream scripts if really an error occurred or if they are only disabled.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (SOLR-531) rsyncd-start and snappuller should exit with different exit code when disabled

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bill Au reassigned SOLR-531:
----------------------------

    Assignee: Bill Au

> rsyncd-start and snappuller should exit with different exit code when disabled
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-531
>                 URL: https://issues.apache.org/jira/browse/SOLR-531
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication
>    Affects Versions: 1.3
>            Reporter: Thomas Peuss
>            Assignee: Bill Au
>            Priority: Trivial
>         Attachments: SOLR-531.patch
>
>
> When the rsyncd-start and snappuller scripts get executed the scripts check if they are enabled or not. If they are disabled they exit with 1. The scripts exit with 1 on error as well. So you cannot decide in upstream scripts if really an error occurred or if they are only disabled.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (SOLR-531) rsyncd-start and snappuller should exit with different exit code when disabled

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bill Au resolved SOLR-531.
--------------------------

    Resolution: Fixed

Patch committed:

Sending        CHANGES.txt
Sending        src/scripts/rsyncd-start
Sending        src/scripts/snappuller
Transmitting file data ...
Committed revision 645608.


Thanks, Thomas.

> rsyncd-start and snappuller should exit with different exit code when disabled
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-531
>                 URL: https://issues.apache.org/jira/browse/SOLR-531
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication
>    Affects Versions: 1.3
>            Reporter: Thomas Peuss
>            Assignee: Bill Au
>            Priority: Trivial
>         Attachments: SOLR-531.patch
>
>
> When the rsyncd-start and snappuller scripts get executed the scripts check if they are enabled or not. If they are disabled they exit with 1. The scripts exit with 1 on error as well. So you cannot decide in upstream scripts if really an error occurred or if they are only disabled.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.