[jira] Created: (SOLR-95) simplification of solr_server.rb

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (SOLR-95) simplification of solr_server.rb

JIRA jira@apache.org
simplification of solr_server.rb
--------------------------------

                 Key: SOLR-95
                 URL: https://issues.apache.org/jira/browse/SOLR-95
             Project: Solr
          Issue Type: Improvement
          Components: clients - ruby - flare
         Environment: Darwin Kernel Version 8.8.1
            Reporter: Ed Summers
            Priority: Minor
         Attachments: solr_startup_simpification.diff

solr_start() was using a system call to start solr, which resulted in three separate processes that needed to be killed with a process group id. This required solr_start() to disassociate itself from the parent process with setsid, and lookup the subprocesses' parent id.

using exec() instead of system() makes this complexity go away fortunately. Also the solr_server.rb was renamed to test_helper.rb as it is likely to contain other methods/classes for clearing the index, etc...

 

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-95) simplification of solr_server.rb

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ed Summers updated SOLR-95:
---------------------------

    Attachment: solr_startup_simpification.diff

> simplification of solr_server.rb
> --------------------------------
>
>                 Key: SOLR-95
>                 URL: https://issues.apache.org/jira/browse/SOLR-95
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - ruby - flare
>         Environment: Darwin Kernel Version 8.8.1
>            Reporter: Ed Summers
>            Priority: Minor
>         Attachments: solr_startup_simpification.diff
>
>
> solr_start() was using a system call to start solr, which resulted in three separate processes that needed to be killed with a process group id. This required solr_start() to disassociate itself from the parent process with setsid, and lookup the subprocesses' parent id.
> using exec() instead of system() makes this complexity go away fortunately. Also the solr_server.rb was renamed to test_helper.rb as it is likely to contain other methods/classes for clearing the index, etc...
>  

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (SOLR-95) simplification of solr_server.rb

JIRA jira@apache.org
In reply to this post by JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erik Hatcher resolved SOLR-95.
------------------------------

    Resolution: Fixed
      Assignee: Erik Hatcher

Committed!  Thanks again, Ed :)

> simplification of solr_server.rb
> --------------------------------
>
>                 Key: SOLR-95
>                 URL: https://issues.apache.org/jira/browse/SOLR-95
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - ruby - flare
>         Environment: Darwin Kernel Version 8.8.1
>            Reporter: Ed Summers
>         Assigned To: Erik Hatcher
>            Priority: Minor
>         Attachments: solr_startup_simpification.diff
>
>
> solr_start() was using a system call to start solr, which resulted in three separate processes that needed to be killed with a process group id. This required solr_start() to disassociate itself from the parent process with setsid, and lookup the subprocesses' parent id.
> using exec() instead of system() makes this complexity go away fortunately. Also the solr_server.rb was renamed to test_helper.rb as it is likely to contain other methods/classes for clearing the index, etc...
>  

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira