[jira] [Resolved] (LUCENE-8344) TokenStreamToAutomaton doesn't ignore trailing posInc when preservePositionIncrements=false

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Resolved] (LUCENE-8344) TokenStreamToAutomaton doesn't ignore trailing posInc when preservePositionIncrements=false

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Smiley resolved LUCENE-8344.
----------------------------------
       Resolution: Fixed
         Assignee: David Smiley
    Fix Version/s: 7.4

Thanks for the review during your vacation Jim!  Indeed CGF is in 7.4.

I committed to master, branch_7x, and branch_7_4 but I don't yet see the comment bot saying so.  Here's a link to one such commit: [https://github.com/apache/lucene-solr/commit/228a84fd6db3ef5fc1624d69e1c82a1f02c51352]

> TokenStreamToAutomaton doesn't ignore trailing posInc when preservePositionIncrements=false
> -------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-8344
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8344
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/suggest
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Major
>             Fix For: 7.4
>
>         Attachments: LUCENE-8344.patch, LUCENE-8344.patch, LUCENE-8344.patch
>
>
> TokenStreamToAutomaton in Lucene core is used by the AnalyzingSuggester (incl. FuzzySuggester subclass ) and NRT Document Suggester and soon the SolrTextTagger.  It has a setting {{preservePositionIncrements}} defaulting to true.  If it's set to false (e.g. to ignore stopwords) and if there is a _trailing_ position increment greater than 1, TS2A will _still_ add position increments (holes) into the automata even though it was configured not to.
> I'm filing this issue separate from LUCENE-8332 where I first found it.  The fix is very simple but I'm concerned about back-compat ramifications so I'm filing it separately.  I'll attach a patch to show the problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]