Quantcast

[jira] [Updated] (LUCENE-7794) buildAndPushRelease.py should run precommit (or the equivalent)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Updated] (LUCENE-7794) buildAndPushRelease.py should run precommit (or the equivalent)

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-7794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Rowe updated LUCENE-7794:
-------------------------------
    Attachment: LUCENE-7794.patch

Patch, adds "validate" and "documentation-lint" to the "ant clean test" invocation.  The other component of "precommit", the "check-working-copy", isn't necessary in buildAndPushRelease.py, since its {{getGitRev()}} method already performs the same checks.

I'll test this (after disabling the dirty checkout tests in {{getGitRev()}}).

> buildAndPushRelease.py should run precommit (or the equivalent)
> ---------------------------------------------------------------
>
>                 Key: LUCENE-7794
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7794
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Steve Rowe
>         Attachments: LUCENE-7794.patch
>
>
> {{buildAndPushRelease.py}} runs {{ant clean test}} before building a release, but does not run {{precommit}}.  As a result, it's possible to build releases with source code that fails {{precommit}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...