[jira] [Updated] (LUCENE-7901) original/default Highlighter's constructor should throw if passed null args

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] [Updated] (LUCENE-7901) original/default Highlighter's constructor should throw if passed null args

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/LUCENE-7901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Gerlowski updated LUCENE-7901:
------------------------------------
    Attachment: LUCENE-7901.patch

Attached patch does about what you'd expect.  Tests and precommit pass.

> original/default Highlighter's constructor should throw if passed null args
> ---------------------------------------------------------------------------
>
>                 Key: LUCENE-7901
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7901
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/highlighter
>            Reporter: David Smiley
>            Priority: Minor
>         Attachments: LUCENE-7901.patch
>
>
> The default/original Highlighter has a constructor that takes several parameters, including an Encoder.  If per chance these are null, we'll throw an exception later at highlight time but it's nicer to get an exception eagerly.  It will also avoid the LUCENE-6979 trap.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...