[jira] [Updated] (SOLR-10779) JavaBinCodec should use close consistently rather than having marshal() and close() call finish() (which closes the underlying stream)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (SOLR-10779) JavaBinCodec should use close consistently rather than having marshal() and close() call finish() (which closes the underlying stream)

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-10779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erick Erickson updated SOLR-10779:
----------------------------------
    Attachment: SOLR-10779.patch

Final patch with CHANGES.txt and incorporating comments.

> JavaBinCodec should use close consistently rather than having marshal() and close() call finish() (which closes the underlying stream)
> --------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-10779
>                 URL: https://issues.apache.org/jira/browse/SOLR-10779
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public)
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>         Attachments: SOLR-10779.patch, SOLR-10779.patch, SOLR-10779.patch
>
>
> Having the marshal() code call finish which in turn calls close() is trappy. The marshal code is not robust anyway since if there's an exception before the try loop, it will not close the resource.
> Sub task of SOLR-10778



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]