[jira] Updated: (SOLR-1240) Numerical Range faceting

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[jira] Updated: (SOLR-1240) Numerical Range faceting

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/SOLR-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man updated SOLR-1240:

    Attachment: SOLR-1240.patch

Updated version of Gijs previous patch that applies cleanly to trunk

Misc comments on the patch...

* i agree with erik, we should split up SimpleFacets and FacetComponent, but that's a seperate probelm.  if the patch works well, let's commit and then refactor -- besides: there is enough similarity with date faceting that they should stay together and share code anyway, so let's just put number faceting with date faceting now and move them together later when we split up facet.query, facet.field and facet.date/number
** I think in an ideal world: we could eliminate facet.date and facet.number and just let people use "facet.range=fieldName" along with legitimate values for the other facet.range.* params and have it do the right thing depending on the type of fieldName ... but it might take a little while to get there
* Note: current patch breaks distributed test, but i think that's just a foolish assumption on the part of the test.
* functionality currently breaks if any of the numeric params is a float value -- the code does lots of special testing to see if the _field_ is a "float" field or not, but it still tries to parse every param as both a long and a float -- we need to fix that so any number is valid (even if the field type is "long" it's totally reasonable for people to ask for a gap of "0.5")
* the facet.date.include param was added after this patch was contributed, this patch uses it's own param/model for dealing with inclusion/exclusion -- it should be changed to match the conventions dates uses

> Numerical Range faceting
> ------------------------
>                 Key: SOLR-1240
>                 URL: https://issues.apache.org/jira/browse/SOLR-1240
>             Project: Solr
>          Issue Type: New Feature
>          Components: search
>            Reporter: Gijs Kunze
>            Priority: Minor
>         Attachments: SOLR-1240.patch, SOLR-1240.patch, SOLR-1240.patch
> For faceting numerical ranges using many facet.query query arguments leads to unmanageably large queries as the fields you facet over increase. Adding the same faceting parameter for numbers which already exists for dates should fix this.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]