[lucy-dev] [VOTE] Apache Clownfish 0.6.2 RC 1

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[lucy-dev] [VOTE] Apache Clownfish 0.6.2 RC 1

Nick Wellnhofer
Hello,

Release candidate 1 for Apache Clownfish version 0.6.2 can be
found at:

 
https://dist.apache.org/repos/dist/dev/lucy/clownfish/apache-clownfish-0.6.2-rc1/

See the CHANGES file at the top level of the archive for information
about the content of this release.

This candidate was assembled according to the process documented at:

     http://wiki.apache.org/lucy/ReleaseGuide

It was cut using "git archive" from the tag at:

 
https://git-wip-us.apache.org/repos/asf?p=lucy-clownfish.git;a=tag;h=refs/tags/v0.6.2-rc1

Please vote on releasing this candidate as Apache Clownfish version
0.6.2.  The vote will be held open for at least the next 72
hours.

All interested parties are welcome to inspect the release candidate
and express approval or disapproval.  Votes from members of the Lucy
PMC are binding; the vote passes if there are at least three binding
+1 votes and more +1 votes than -1 votes.

For suggestions as to how to evaluate Apache Clownfish release candidates,
and for information on ASF voting procedures, see:

     http://wiki.apache.org/lucy/ReleaseVerification
     http://wiki.apache.org/lucy/ReleasePrep
     http://www.apache.org/foundation/voting.html

[ ] +1 Release RC 1 as Apache Clownfish 0.6.2.
[ ] +0
[ ] -1 Do not release RC 1 as Apache Clownfish 0.6.2 because...

Here's my +1.

Thanks!
Reply | Threaded
Open this post in threaded view
|

Re: [lucy-dev] [VOTE] Apache Clownfish 0.6.2 RC 1

Peter Karman
Nick Wellnhofer wrote on 11/15/17 9:52 AM:

>
> [ ] +1 Release RC 1 as Apache Clownfish 0.6.2.
> [ ] +0
> [ ] -1 Do not release RC 1 as Apache Clownfish 0.6.2 because...
>

+1

full output of my test below

[karpet@pekmac:clownfish]$ test-lucy-rc.pl
https://dist.apache.org/repos/dist/dev/lucy/clownfish/apache-clownfish-0.6.2-rc1/
--------------------------------------------------------------------------------
wget -q -r --no-parent --reject 'index.html*'
https://dist.apache.org/repos/dist/dev/lucy/clownfish/apache-clownfish-0.6.2-rc1/
================================================================================
--------------------------------------------------------------------------------
md5sum apache-clownfish-0.6.2.tar.gz.md5
signatures match: b535bbb5fea790ac72e71625d013b753
apache-clownfish-0.6.2.tar.gz: OK
================================================================================
--------------------------------------------------------------------------------
shasum -c apache-clownfish-0.6.2.tar.gz.sha512
apache-clownfish-0.6.2.tar.gz: OK
================================================================================
--------------------------------------------------------------------------------
gpg --verify apache-clownfish-0.6.2.tar.gz.asc
gpg: assuming signed data in 'apache-clownfish-0.6.2.tar.gz'
gpg: Signature made Wed Nov 15 09:46:53 2017 CST using RSA key ID 3241E84F
gpg: Good signature from "Nick Wellnhofer (CODE SIGNING KEY)
<[hidden email]>" [full]
================================================================================
--------------------------------------------------------------------------------
tar xfz apache-clownfish-0.6.2.tar.gz
--------------------------------------------------------------------------------
perl Build.PL
Created MYMETA.yml and MYMETA.json
Creating new 'Build' script for 'Clownfish' version '0.6.2'
--------------------------------------------------------------------------------
perl Build test >> clownfish-test-out
autogen/source/cfish_perl.c:111:1: warning: unused function
'S_finish_callback_f64' [-Wunused-function]
S_finish_callback_f64(pTHX_ const char *meth_name) {
^
1 warning generated.
autogen/source/testcfish_perl.c:108:1: warning: unused function
'S_finish_callback_f64' [-Wunused-function]
S_finish_callback_f64(pTHX_ const char *meth_name) {
^
1 warning generated.
Build runtime/perl test finished for apache-clownfish-0.6.2
[karpet@pekmac:clownfish]$ perl -v

This is perl 5, version 24, subversion 0 (v5.24.0) built for darwin-2level

Copyright 1987-2016, Larry Wall

Perl may be copied only under the terms of either the Artistic License or the
GNU General Public License, which may be found in the Perl 5 source kit.

Complete documentation for Perl, including FAQ lists, should be found on
this system using "man perl" or "perldoc perl".  If you have access to the
Internet, point your browser at http://www.perl.org/, the Perl Home Page.

[karpet@pekmac:clownfish]$ uname -a
Darwin pekmac.midcoip.net 16.7.0 Darwin Kernel Version 16.7.0: Wed Oct  4
00:17:00 PDT 2017; root:xnu-3789.71.6~1/RELEASE_X86_64 x86_64


--
Peter Karman  .  https://karpet.github.io  .  https://keybase.io/peterkarman
Reply | Threaded
Open this post in threaded view
|

Re: [lucy-dev] [VOTE] Apache Clownfish 0.6.2 RC 1

Marvin Humphrey
In reply to this post by Nick Wellnhofer
On Wed, Nov 15, 2017 at 7:52 AM, Nick Wellnhofer <[hidden email]> wrote:

> [ ] +1 Release RC 1 as Apache Clownfish 0.6.2.
> [ ] +0
> [ ] -1 Do not release RC 1 as Apache Clownfish 0.6.2 because...

+1

* Checked sums and sigs.
* Inspected the diff between the last release tag and this RC tag.
* Tested the Clownfish RC along with the Lucy 0.6.1 tarball
  using lucy/devel/bin/test_all.sh.

* OS X Sierra
* Apple LLVM version 9.0.0 (clang-900.0.38)
* Perl v5.18.2
* Go go1.9.2 darwin/amd64

After some twiddling, I was able to make test_all.sh pass.

However, the Go build was broken out of the box. I was able to remedy
by applying the following patch to the `build.go` files in
$CLOWNFISH/compiler/go/build.go, $CLOWNFISH/runtime/go/build.go, and
$LUCY/go/build.go:

  func init() {
    _, buildGO, _, _ = runtime.Caller(1)
+   if buildGO == "<autogenerated>" {
+       _, buildGO, _, _ = runtime.Caller(0)
+   }
    buildDir = path.Dir(buildGO)
    configGO = path.Join(buildDir, "cfc", "config.go")

Without that patch, we don't get the full path for the include dirs
under recent versions of Go and the build can't find files like
"CFC.h". Depending on `runtime.Caller()` to get the file path and
derive the directory is fragile and using the full paths to feed CGO
is a sketchy hack to begin with -- it's not surprising that it broke.
I'm actually pretty happy that that's all that was broken.

This issue is not any worse with the current RC than it is in previous
releases, so I am not going to block the RC. If someone feels like
rolling out new releases for Clownfish and Lucy we can fix it.

Marvin Humphrey
Reply | Threaded
Open this post in threaded view
|

[lucy-dev] [VOTE][RESULT] Apache Clownfish 0.6.2 RC 1

Nick Wellnhofer
In reply to this post by Nick Wellnhofer
On 15/11/2017 16:52, Nick Wellnhofer wrote:
> [ ] +1 Release RC 1 as Apache Clownfish 0.6.2.
> [ ] +0
> [ ] -1 Do not release RC 1 as Apache Clownfish 0.6.2 because...

The vote passes with +1 votes from PMC members

- Nick Wellnhofer
- Peter Karman
- Marvin Humphrey

Nick