[lucy-dev] [VOTE] Apache Lucy 0.6.1 RC 1

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[lucy-dev] [VOTE] Apache Lucy 0.6.1 RC 1

Nick Wellnhofer
Hello,

Release candidate 1 for Apache Lucy version 0.6.1 can be
found at:

     https://dist.apache.org/repos/dist/dev/lucy/apache-lucy-0.6.1-rc1/

See the CHANGES file at the top level of the archive for information
about the content of this release.

This candidate was assembled according to the process documented at:

     http://wiki.apache.org/lucy/ReleaseGuide

It was cut using "git archive" from the tag at:

 
https://git-wip-us.apache.org/repos/asf?p=lucy.git;a=tag;h=refs/tags/v0.6.1-rc1

Please vote on releasing this candidate as Apache Lucy version
0.6.1.  The vote will be held open for at least the next 72
hours.

All interested parties are welcome to inspect the release candidate
and express approval or disapproval.  Votes from members of the Lucy
PMC are binding; the vote passes if there are at least three binding
+1 votes and more +1 votes than -1 votes.

For suggestions as to how to evaluate Apache Lucy release candidates,
and for information on ASF voting procedures, see:

     http://wiki.apache.org/lucy/ReleaseVerification
     http://wiki.apache.org/lucy/ReleasePrep
     http://www.apache.org/foundation/voting.html

I tested under Ubuntu 16.04, x86 (32-bit):

- Go bindings with stock Go 1.6.1
- Perl bindings with stock Perl 5.22.1
- C bindings with stock GCC 5.3.1

All CI tests passed:

     https://travis-ci.org/apache/lucy/builds/182635046
     https://ci.appveyor.com/project/Humbedooh/lucy/build/1.0.92

You can test both the Clownfish and Lucy RC with the test_all.sh
script:

     curl
https://dist.apache.org/repos/dist/dev/lucy/clownfish/apache-clownfish-0.6.1-rc1/apache-clownfish-0.6.1.tar.gz 
|tar xz
     curl
https://dist.apache.org/repos/dist/dev/lucy/apache-lucy-0.6.1-rc1/apache-lucy-0.6.1.tar.gz 
|tar xz
     mv apache-clownfish-0.6.1 clownfish
     mv apache-lucy-0.6.1 lucy
     lucy/devel/bin/test_all.sh

The script requires a golang installation, Perl, and a C compiler.
You can also test host languages separately by running

     lucy/devel/bin/test_all.sh go
     lucy/devel/bin/test_all.sh perl
     lucy/devel/bin/test_all.sh c

[ ] +1 Release RC 1 as Apache Lucy 0.6.1.
[ ] +0
[ ] -1 Do not release RC 1 as Apache Lucy 0.6.1 because...

Here's my +1.

Thanks!
Reply | Threaded
Open this post in threaded view
|

Re: [lucy-dev] [VOTE] Apache Lucy 0.6.1 RC 1

Peter Karman
Nick Wellnhofer wrote on 12/9/16 10:29 AM:

> [ ] +1 Release RC 1 as Apache Lucy 0.6.1.

+1

Perl bindings tested. Full results below.

[karpet@pekmac:~]$ perl my-toolbox/test-lucy-rc.pl
https://dist.apache.org/repos/dist/dev/lucy/apache-lucy-0.6.1-rc1/
--------------------------------------------------------------------------------
wget -q -r --no-parent --reject 'index.html*'
https://dist.apache.org/repos/dist/dev/lucy/apache-lucy-0.6.1-rc1/
================================================================================
--------------------------------------------------------------------------------
md5sum apache-lucy-0.6.1.tar.gz.md5
signatures match: 6b3cd04e6f718403549802d509bfed4b
apache-lucy-0.6.1.tar.gz: OK
================================================================================
--------------------------------------------------------------------------------
shasum -c apache-lucy-0.6.1.tar.gz.sha
apache-lucy-0.6.1.tar.gz: OK
================================================================================
--------------------------------------------------------------------------------
gpg --verify apache-lucy-0.6.1.tar.gz.asc
gpg: assuming signed data in 'apache-lucy-0.6.1.tar.gz'
gpg: Signature made Fri Dec  9 10:07:37 2016 CST using RSA key ID 3241E84F
gpg: Good signature from "Nick Wellnhofer (CODE SIGNING KEY)
<[hidden email]>" [full]
================================================================================
--------------------------------------------------------------------------------
tar xfz apache-lucy-0.6.1.tar.gz
--------------------------------------------------------------------------------
perl Build.PL
Created MYMETA.yml and MYMETA.json
Creating new 'Build' script for 'Lucy' version '0.6.1'
--------------------------------------------------------------------------------
./Build dist &>lucy-dist-output
--------------------------------------------------------------------------------
tar xfz Lucy-0.6.1.tar.gz
--------------------------------------------------------------------------------
perl Build.PL
Created MYMETA.yml and MYMETA.json
Creating new 'Build' script for 'Lucy' version '0.6.1'
--------------------------------------------------------------------------------
./Build test >> lucy-test-out
autogen/source/testlucy_perl.c:116:1: warning: unused function
'S_finish_callback_void' [-Wunused-function]
S_finish_callback_void(pTHX_ const char *meth_name) {
^
autogen/source/testlucy_perl.c:163:1: warning: unused function
'S_finish_callback_f64' [-Wunused-function]
S_finish_callback_f64(pTHX_ const char *meth_name) {
^
2 warnings generated.
Build test finished for apache-lucy-0.6.1

[karpet@pekmac:~]$ uname -a
Darwin pekmac.local 15.6.0 Darwin Kernel Version 15.6.0: Thu Sep  1 15:01:16 PDT
2016; root:xnu-3248.60.11~2/RELEASE_X86_64 x86_64


[karpet@pekmac:~]$ perl -v

This is perl 5, version 24, subversion 0 (v5.24.0) built for darwin-2level


--
Peter Karman  .  http://peknet.com/  .  [hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: [lucy-dev] [VOTE] Apache Lucy 0.6.1 RC 1

Marvin Humphrey
In reply to this post by Nick Wellnhofer
On Fri, Dec 9, 2016 at 8:29 AM, Nick Wellnhofer <[hidden email]> wrote:

> All CI tests passed:
>
>     https://travis-ci.org/apache/lucy/builds/182635046
>     https://ci.appveyor.com/project/Humbedooh/lucy/build/1.0.92

So nice... :)

> [ ] +1 Release RC 1 as Apache Lucy 0.6.1.
> [ ] +0
> [ ] -1 Do not release RC 1 as Apache Lucy 0.6.1 because...

+1

I found a small discrepancy between the content of the git tag and the content
of the release tarball: there are 2 lines missing from CHANGES in the tarball.
See below my sig.

My suggestion is to make a commit and update the tag before it is made
permanent by moving it under `rel/`.  Rerolling a release candidate would be
overkill, but it is good for the tag and the tarball to match.  It is not
critical that CHANGES be exhaustively complete.

Other things I checked:

*   Sums and sigs check out.
*   The `test_valgrind` build target for Perl, run on Amazon linux, did not
    reveal any substantial problems.
*   The `test_all.sh` script passed on OS X El Capitan
    - Apple LLVM version 8.0.0 (clang-800.0.42.1)
    - stock Perl 5.18.2
    - go 1.4.2
*   Though I've been quiet on-list lately, I've reviewed all commits.
*   The issue tracker is clean.
*   Copyright dates look good.

Marvin Humphrey

marvin@nicodemus:~/Desktop/release $ diff -ur ~/projects/lucy lucy
Only in /Users/marvin/projects/lucy: .git
diff -ur /Users/marvin/projects/lucy/CHANGES lucy/CHANGES
--- /Users/marvin/projects/lucy/CHANGES 2016-12-10 16:28:58.000000000 -0800
+++ lucy/CHANGES 2016-12-09 07:50:05.000000000 -0800
@@ -5,10 +5,8 @@
   Bugfixes:

     * [LUCY-286] - Remote::SearchClient::DESTROY shouldn't throw exceptions
-    * [LUCY-309] - BSD make doesn't support pattern rules
     * [LUCY-310] - CPAN dist includes Lucy/Test.xs
     * [LUCY-311] - Non-ASCII error messages from strerror cause exceptions
-    * [LUCY-312] - Remote searcher tests fail if port is in use
     * [LUCY-315] - Memory leak in HitQueue with SortSpec
     * [LUCY-316] - Don't regenerate POD when building CPAN distro
     * [LUCY-317] - Compile failure on FreeBSD 10.1
Reply | Threaded
Open this post in threaded view
|

Re: [lucy-dev] [VOTE] Apache Lucy 0.6.1 RC 1

Nick Wellnhofer
On 11/12/2016 02:42, Marvin Humphrey wrote:
> I found a small discrepancy between the content of the git tag and the content
> of the release tarball: there are 2 lines missing from CHANGES in the tarball.
> See below my sig.

Right, I forgot to update the tarball after adding these two entries the
changelog.

> My suggestion is to make a commit and update the tag before it is made
> permanent by moving it under `rel/`.  Rerolling a release candidate would be
> overkill, but it is good for the tag and the tarball to match.  It is not
> critical that CHANGES be exhaustively complete.

The rc1 tag should match the contents of the tarball now:

 
https://git1-us-west.apache.org/repos/asf?p=lucy.git;a=shortlog;h=refs/heads/0.6

> *   Though I've been quiet on-list lately, I've reviewed all commits.

Thanks.

Nick

Reply | Threaded
Open this post in threaded view
|

[lucy-dev] [VOTE][RESULT] Apache Lucy 0.6.1 RC 1

Nick Wellnhofer
In reply to this post by Nick Wellnhofer
On 09/12/2016 17:29, Nick Wellnhofer wrote:
> [ ] +1 Release RC 1 as Apache Lucy 0.6.1.
> [ ] +0
> [ ] -1 Do not release RC 1 as Apache Lucy 0.6.1 because...

The vote passes with +1 votes from PMC members

- Nick Wellnhofer
- Peter Karman
- Marvin Humphrey

Nick