Closing GitHub PRs

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Closing GitHub PRs

Jan Høydahl / Cominvent
Hi

I ran the tool dev-tools/scripts/githubPRs.py and JIRA and GitHub tend to diverge day by day. Need some help to connect orphan PRs with JIRA issues and close PRs that have a closed JIRA:

PRs lacking JIRA reference in title
  #1026: Buffer one record from each shard every 5000 reads to ensure connecti…
  #1005: LUCENE 9042: Refactor TopGroups.merge tests
  #1002: [docs]: fixed two small errors in JavaDoc
  #1000: [MINOR] Fix typo
  #993: maybe can simpler
  #988: Update README.md
  #934: Fix typo
  #908: Change the file format of README files from README.txt to README.md a…
  #882: Add versions.lock entry for "org.apache.yetus:audience-annotations"
  #880: Tweak header format.
  #873: Rename README.txt to README.md
  #854: Shared PQ Based Early Termination for Concurrent Search
  #807: Remove solr.jetty.https.port when SSL is not used
  #772: Payload-stored position length intervals
  #673: Replace instances of Math.random with Random.nextDouble
  #669: Facet2d
  #639: Solve the problem of highlighting Chinese inaccurately.
  #615: Intervals Query Parser
  #602: docu change: use class TopDocs instead of Hits
  #601: Adding reader settings for moving fst offheap
  #596: Under this branch, the dataDimensionCount is definitely not zero.
  #564: prorated early termination
  #542: LuceneLevenshteinDistance computes distance values outside of interval [0, 1]
  #508: Simplified JAVA_VER_NUM to utilize single expr execution
  #492: Answer to TODO: Replace Manual Encoding with JSON Module
  #491: Update for multiple term's suggestion scoring
  #484: solr 7.5 suggest The recommended result is empty
  #478: Query Source Tracker custom component
  #450: Add rule exception for "imento" and "mento" suffix
  #442: Fixing an edge case bug when overriding a default PostingsSolrHighligher
  #405: don't die when java prints tool options
  #404: Comment to explain how to use URLClassifyProcessorFactory
  #399: fix explicit type declaration
  #383: In ContextQuery, use a more comprehensive check for an empty prefix automaton.
  #379: add ë, ö and ï to norm()
  #350: SOLR match mode change for the rouding off instead of taking floor
  #340: Add SolrConfig to SolrRequestParsers constructor in EmbeddedSolrServer
  #309: Update ZkConfigManager.java
  #308: Add a suggester that operates on tokenized values from a field
  #293: spellcheck prefix already contains a trailing dot
  #292: Removed extra whitespace
  #272: Correct inconsistency on plugin support
  #241: SpanishLightStemmer fix for plural words like casas
  #234: Made minor changes to docstring to fix wording errors
  #231: WordDelimiterGraphFilter: Better support for camel case splitting.
  #218: feat: Separate SuggestModes for WordBreak and WordJoin
  #217: added initial .travis.yml
  #201: Allocate ArrayList with exact size
  #175: Skipping merger
  #153: Fix issues reported by findbugs
  #152: Added log prior calculations in CachingNaiveBayesClassifier.
  #133: Prevent memory leaks in PerFieldAnalyzerWrapper
  #131: Fix peer sync replcation test check
  #124: fix small issue in solr shell script
  #116: fixed NPEs
  #110: Update SearchFiles.java
  #108: Minor - Fix error message
  #85: Allow updating configs like port # on forced upgrade
  #48: moved common string to constant file
  #22: Update files.js
  #8: Do not log error messages, if client has been interrupted

Open PRs with a resolved JIRA
  #365: SOLR-12243 status=Closed, resolution=Fixed, resolutiondate=2018-11-05T17:20:27.000+0000 ([SOLR-12243] span query generalization + query parser tests)
  #330: SOLR-12045 status=Closed, resolution=Won't Fix, resolutiondate=2019-11-02T15:24:54.000+0000 (SOLR-12045: Moving the Analytics Component from contrib to core.)
  #861: SOLR-10665 status=Resolved, resolution=Abandoned, resolutiondate=2019-11-12T03:25:46.000+0000 (SOLR-10665 POC for a PF4J based plugin system)
  #161: SOLR-9399 status=Closed, resolution=Fixed, resolutiondate=2018-04-02T16:31:06.000+0000 (Fix SOLR-9399, pass basic auth to update request)
  #93: SOLR-8754 status=Closed, resolution=Fixed, resolutiondate=2019-06-13T10:59:41.000+0000 (SOLR-8754: Adding test cases and additional error checking)
  #1032: LUCENE-9058 status=Resolved, resolution=Won't Fix, resolutiondate=2019-11-25T18:58:49.000+0000 (LUCENE-9058: highlighting over underneath field despite IQ field)
  #631: LUCENE-8750 status=Resolved, resolution=Fixed, resolutiondate=2019-04-03T09:19:47.000+0000 (LUCENE-8750: implement setMissingValue for ValueSource sortFields)
  #536: LUCENE-8643 status=Resolved, resolution=Fixed, resolutiondate=2019-01-17T09:12:09.000+0000 (LUCENE-8643: Decrease test complexity in the default case. Exclude simple text codec.)
  #533: LUCENE-8636 status=Resolved, resolution=Fixed, resolutiondate=2019-01-15T11:02:49.000+0000 (LUCENE-8636: TestPointQueries and long execution times)
  #543: LUCENE-8474 status=Resolved, resolution=Fixed, resolutiondate=2019-01-28T12:50:00.000+0000 (LUCENE-8474: final cleanups and removal of RAMDirectory)

--
Jan Høydahl, search solution architect
Cominvent AS - www.cominvent.com

Reply | Threaded
Open this post in threaded view
|

Re: Closing GitHub PRs

Man with No Name
I have a PR without a jira ticket, I’ll update the title of the PR.

On Tue, Nov 26, 2019 at 3:02 PM Jan Høydahl <[hidden email]> wrote:
Hi

I ran the tool dev-tools/scripts/githubPRs.py and JIRA and GitHub tend to diverge day by day. Need some help to connect orphan PRs with JIRA issues and close PRs that have a closed JIRA:

PRs lacking JIRA reference in title
  #1026: Buffer one record from each shard every 5000 reads to ensure connecti…
  #1005: LUCENE 9042: Refactor TopGroups.merge tests
  #1002: [docs]: fixed two small errors in JavaDoc
  #1000: [MINOR] Fix typo
  #993: maybe can simpler
  #988: Update README.md
  #934: Fix typo
  #908: Change the file format of README files from README.txt to README.md a…
  #882: Add versions.lock entry for "org.apache.yetus:audience-annotations"
  #880: Tweak header format.
  #873: Rename README.txt to README.md
  #854: Shared PQ Based Early Termination for Concurrent Search
  #807: Remove solr.jetty.https.port when SSL is not used
  #772: Payload-stored position length intervals
  #673: Replace instances of Math.random with Random.nextDouble
  #669: Facet2d
  #639: Solve the problem of highlighting Chinese inaccurately.
  #615: Intervals Query Parser
  #602: docu change: use class TopDocs instead of Hits
  #601: Adding reader settings for moving fst offheap
  #596: Under this branch, the dataDimensionCount is definitely not zero.
  #564: prorated early termination
  #542: LuceneLevenshteinDistance computes distance values outside of interval [0, 1]
  #508: Simplified JAVA_VER_NUM to utilize single expr execution
  #492: Answer to TODO: Replace Manual Encoding with JSON Module
  #491: Update for multiple term's suggestion scoring
  #484: solr 7.5 suggest The recommended result is empty
  #478: Query Source Tracker custom component
  #450: Add rule exception for "imento" and "mento" suffix
  #442: Fixing an edge case bug when overriding a default PostingsSolrHighligher
  #405: don't die when java prints tool options
  #404: Comment to explain how to use URLClassifyProcessorFactory
  #399: fix explicit type declaration
  #383: In ContextQuery, use a more comprehensive check for an empty prefix automaton.
  #379: add ë, ö and ï to norm()
  #350: SOLR match mode change for the rouding off instead of taking floor
  #340: Add SolrConfig to SolrRequestParsers constructor in EmbeddedSolrServer
  #309: Update ZkConfigManager.java
  #308: Add a suggester that operates on tokenized values from a field
  #293: spellcheck prefix already contains a trailing dot
  #292: Removed extra whitespace
  #272: Correct inconsistency on plugin support
  #241: SpanishLightStemmer fix for plural words like casas
  #234: Made minor changes to docstring to fix wording errors
  #231: WordDelimiterGraphFilter: Better support for camel case splitting.
  #218: feat: Separate SuggestModes for WordBreak and WordJoin
  #217: added initial .travis.yml
  #201: Allocate ArrayList with exact size
  #175: Skipping merger
  #153: Fix issues reported by findbugs
  #152: Added log prior calculations in CachingNaiveBayesClassifier.
  #133: Prevent memory leaks in PerFieldAnalyzerWrapper
  #131: Fix peer sync replcation test check
  #124: fix small issue in solr shell script
  #116: fixed NPEs
  #110: Update SearchFiles.java
  #108: Minor - Fix error message
  #85: Allow updating configs like port # on forced upgrade
  #48: moved common string to constant file
  #22: Update files.js
  #8: Do not log error messages, if client has been interrupted

Open PRs with a resolved JIRA
  #365: SOLR-12243 status=Closed, resolution=Fixed, resolutiondate=2018-11-05T17:20:27.000+0000 ([SOLR-12243] span query generalization + query parser tests)
  #330: SOLR-12045 status=Closed, resolution=Won't Fix, resolutiondate=2019-11-02T15:24:54.000+0000 (SOLR-12045: Moving the Analytics Component from contrib to core.)
  #861: SOLR-10665 status=Resolved, resolution=Abandoned, resolutiondate=2019-11-12T03:25:46.000+0000 (SOLR-10665 POC for a PF4J based plugin system)
  #161: SOLR-9399 status=Closed, resolution=Fixed, resolutiondate=2018-04-02T16:31:06.000+0000 (Fix SOLR-9399, pass basic auth to update request)
  #93: SOLR-8754 status=Closed, resolution=Fixed, resolutiondate=2019-06-13T10:59:41.000+0000 (SOLR-8754: Adding test cases and additional error checking)
  #1032: LUCENE-9058 status=Resolved, resolution=Won't Fix, resolutiondate=2019-11-25T18:58:49.000+0000 (LUCENE-9058: highlighting over underneath field despite IQ field)
  #631: LUCENE-8750 status=Resolved, resolution=Fixed, resolutiondate=2019-04-03T09:19:47.000+0000 (LUCENE-8750: implement setMissingValue for ValueSource sortFields)
  #536: LUCENE-8643 status=Resolved, resolution=Fixed, resolutiondate=2019-01-17T09:12:09.000+0000 (LUCENE-8643: Decrease test complexity in the default case. Exclude simple text codec.)
  #533: LUCENE-8636 status=Resolved, resolution=Fixed, resolutiondate=2019-01-15T11:02:49.000+0000 (LUCENE-8636: TestPointQueries and long execution times)
  #543: LUCENE-8474 status=Resolved, resolution=Fixed, resolutiondate=2019-01-28T12:50:00.000+0000 (LUCENE-8474: final cleanups and removal of RAMDirectory)

--
Jan Høydahl, search solution architect
Cominvent AS - www.cominvent.com

--
Sent from Gmail for IPhone
Reply | Threaded
Open this post in threaded view
|

Re: Closing GitHub PRs

Jan Høydahl / Cominvent
I have closed several PRs where JIRAs were closed.
Also merged several minor PRs with typo fixes and similar, without opening a JIRA for them.
Would be nice for our first-time contributors if they get an immediate response when opening a PR!

The updated list of PRs we still have to triage are now:

Lucene/Solr Github PR report
============================
Number of open Pull Requests: 233

PRs lacking JIRA reference in title
  #1026: Buffer one record from each shard every 5000 reads to ensure connecti…
  #1005: LUCENE 9042: Refactor TopGroups.merge tests
  #1002: [docs]: fixed two small errors in JavaDoc
  #993: maybe can simpler
  #988: Update README.md
  #908: Change the file format of README files from README.txt to README.md a…
  #882: Add versions.lock entry for "org.apache.yetus:audience-annotations"
  #880: Tweak header format.
  #873: Rename README.txt to README.md
  #854: Shared PQ Based Early Termination for Concurrent Search
  #807: Remove solr.jetty.https.port when SSL is not used
  #772: Payload-stored position length intervals
  #673: Replace instances of Math.random with Random.nextDouble
  #669: Facet2d
  #639: Solve the problem of highlighting Chinese inaccurately.
  #615: Intervals Query Parser
  #602: docu change: use class TopDocs instead of Hits
  #601: Adding reader settings for moving fst offheap
  #596: Under this branch, the dataDimensionCount is definitely not zero.
  #564: prorated early termination
  #542: LuceneLevenshteinDistance computes distance values outside of interval [0, 1]
  #508: Simplified JAVA_VER_NUM to utilize single expr execution
  #492: Answer to TODO: Replace Manual Encoding with JSON Module
  #491: Update for multiple term's suggestion scoring
  #484: solr 7.5 suggest The recommended result is empty
  #478: Query Source Tracker custom component
  #450: Add rule exception for "imento" and "mento" suffix
  #442: Fixing an edge case bug when overriding a default PostingsSolrHighligher
  #405: don't die when java prints tool options
  #404: Comment to explain how to use URLClassifyProcessorFactory
  #399: fix explicit type declaration
  #383: In ContextQuery, use a more comprehensive check for an empty prefix automaton.
  #350: SOLR match mode change for the rouding off instead of taking floor
  #340: Add SolrConfig to SolrRequestParsers constructor in EmbeddedSolrServer
  #309: Update ZkConfigManager.java
  #308: Add a suggester that operates on tokenized values from a field
  #293: spellcheck prefix already contains a trailing dot
  #241: SpanishLightStemmer fix for plural words like casas
  #231: WordDelimiterGraphFilter: Better support for camel case splitting.
  #218: feat: Separate SuggestModes for WordBreak and WordJoin
  #201: Allocate ArrayList with exact size
  #175: Skipping merger
  #153: Fix issues reported by findbugs
  #152: Added log prior calculations in CachingNaiveBayesClassifier.
  #131: Fix peer sync replcation test check
  #124: fix small issue in solr shell script
  #110: Update SearchFiles.java
  #85: Allow updating configs like port # on forced upgrade
  #48: moved common string to constant file
  #8: Do not log error messages, if client has been interrupted

Open PRs with a resolved JIRA
  #365: SOLR-12243 status=Closed, resolution=Fixed, resolutiondate=2018-11-05T17:20:27.000+0000 ([SOLR-12243] span query generalization + query parser tests)
  #631: LUCENE-8750 status=Resolved, resolution=Fixed, resolutiondate=2019-04-03T09:19:47.000+0000 (LUCENE-8750: implement setMissingValue for ValueSource sortFields)
  #536: LUCENE-8643 status=Resolved, resolution=Fixed, resolutiondate=2019-01-17T09:12:09.000+0000 (LUCENE-8643: Decrease test complexity in the default case. Exclude simple text codec.)
  #533: LUCENE-8636 status=Resolved, resolution=Fixed, resolutiondate=2019-01-15T11:02:49.000+0000 (LUCENE-8636: TestPointQueries and long execution times)
  #543: LUCENE-8474 status=Resolved, resolution=Fixed, resolutiondate=2019-01-28T12:50:00.000+0000 (LUCENE-8474: final cleanups and removal of RAMDirectory)


--
Jan Høydahl, search solution architect
Cominvent AS - www.cominvent.com

26. nov. 2019 kl. 22:18 skrev Man with No Name <[hidden email]>:

I have a PR without a jira ticket, I’ll update the title of the PR.

On Tue, Nov 26, 2019 at 3:02 PM Jan Høydahl <[hidden email]> wrote:
Hi

I ran the tool dev-tools/scripts/githubPRs.py and JIRA and GitHub tend to diverge day by day. Need some help to connect orphan PRs with JIRA issues and close PRs that have a closed JIRA:

PRs lacking JIRA reference in title
  #1026: Buffer one record from each shard every 5000 reads to ensure connecti…
  #1005: LUCENE 9042: Refactor TopGroups.merge tests
  #1002: [docs]: fixed two small errors in JavaDoc
  #1000: [MINOR] Fix typo
  #993: maybe can simpler
  #988: Update README.md
  #934: Fix typo
  #908: Change the file format of README files from README.txt to README.md a…
  #882: Add versions.lock entry for "org.apache.yetus:audience-annotations"
  #880: Tweak header format.
  #873: Rename README.txt to README.md
  #854: Shared PQ Based Early Termination for Concurrent Search
  #807: Remove solr.jetty.https.port when SSL is not used
  #772: Payload-stored position length intervals
  #673: Replace instances of Math.random with Random.nextDouble
  #669: Facet2d
  #639: Solve the problem of highlighting Chinese inaccurately.
  #615: Intervals Query Parser
  #602: docu change: use class TopDocs instead of Hits
  #601: Adding reader settings for moving fst offheap
  #596: Under this branch, the dataDimensionCount is definitely not zero.
  #564: prorated early termination
  #542: LuceneLevenshteinDistance computes distance values outside of interval [0, 1]
  #508: Simplified JAVA_VER_NUM to utilize single expr execution
  #492: Answer to TODO: Replace Manual Encoding with JSON Module
  #491: Update for multiple term's suggestion scoring
  #484: solr 7.5 suggest The recommended result is empty
  #478: Query Source Tracker custom component
  #450: Add rule exception for "imento" and "mento" suffix
  #442: Fixing an edge case bug when overriding a default PostingsSolrHighligher
  #405: don't die when java prints tool options
  #404: Comment to explain how to use URLClassifyProcessorFactory
  #399: fix explicit type declaration
  #383: In ContextQuery, use a more comprehensive check for an empty prefix automaton.
  #379: add ë, ö and ï to norm()
  #350: SOLR match mode change for the rouding off instead of taking floor
  #340: Add SolrConfig to SolrRequestParsers constructor in EmbeddedSolrServer
  #309: Update ZkConfigManager.java
  #308: Add a suggester that operates on tokenized values from a field
  #293: spellcheck prefix already contains a trailing dot
  #292: Removed extra whitespace
  #272: Correct inconsistency on plugin support
  #241: SpanishLightStemmer fix for plural words like casas
  #234: Made minor changes to docstring to fix wording errors
  #231: WordDelimiterGraphFilter: Better support for camel case splitting.
  #218: feat: Separate SuggestModes for WordBreak and WordJoin
  #217: added initial .travis.yml
  #201: Allocate ArrayList with exact size
  #175: Skipping merger
  #153: Fix issues reported by findbugs
  #152: Added log prior calculations in CachingNaiveBayesClassifier.
  #133: Prevent memory leaks in PerFieldAnalyzerWrapper
  #131: Fix peer sync replcation test check
  #124: fix small issue in solr shell script
  #116: fixed NPEs
  #110: Update SearchFiles.java
  #108: Minor - Fix error message
  #85: Allow updating configs like port # on forced upgrade
  #48: moved common string to constant file
  #22: Update files.js
  #8: Do not log error messages, if client has been interrupted

Open PRs with a resolved JIRA
  #365: SOLR-12243 status=Closed, resolution=Fixed, resolutiondate=2018-11-05T17:20:27.000+0000 ([SOLR-12243] span query generalization + query parser tests)
  #330: SOLR-12045 status=Closed, resolution=Won't Fix, resolutiondate=2019-11-02T15:24:54.000+0000 (SOLR-12045: Moving the Analytics Component from contrib to core.)
  #861: SOLR-10665 status=Resolved, resolution=Abandoned, resolutiondate=2019-11-12T03:25:46.000+0000 (SOLR-10665 POC for a PF4J based plugin system)
  #161: SOLR-9399 status=Closed, resolution=Fixed, resolutiondate=2018-04-02T16:31:06.000+0000 (Fix SOLR-9399, pass basic auth to update request)
  #93: SOLR-8754 status=Closed, resolution=Fixed, resolutiondate=2019-06-13T10:59:41.000+0000 (SOLR-8754: Adding test cases and additional error checking)
  #1032: LUCENE-9058 status=Resolved, resolution=Won't Fix, resolutiondate=2019-11-25T18:58:49.000+0000 (LUCENE-9058: highlighting over underneath field despite IQ field)
  #631: LUCENE-8750 status=Resolved, resolution=Fixed, resolutiondate=2019-04-03T09:19:47.000+0000 (LUCENE-8750: implement setMissingValue for ValueSource sortFields)
  #536: LUCENE-8643 status=Resolved, resolution=Fixed, resolutiondate=2019-01-17T09:12:09.000+0000 (LUCENE-8643: Decrease test complexity in the default case. Exclude simple text codec.)
  #533: LUCENE-8636 status=Resolved, resolution=Fixed, resolutiondate=2019-01-15T11:02:49.000+0000 (LUCENE-8636: TestPointQueries and long execution times)
  #543: LUCENE-8474 status=Resolved, resolution=Fixed, resolutiondate=2019-01-28T12:50:00.000+0000 (LUCENE-8474: final cleanups and removal of RAMDirectory)

--
Jan Høydahl, search solution architect
Cominvent AS - www.cominvent.com

--
Sent from Gmail for IPhone