Created: (LUCENE-804) build.xml: result of "dist-src" should support "build-contrib"

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Created: (LUCENE-804) build.xml: result of "dist-src" should support "build-contrib"

Sebastian Nagel (Jira)
build.xml: result of "dist-src" should support "build-contrib"
--------------------------------------------------------------

                 Key: LUCENE-804
                 URL: https://issues.apache.org/jira/browse/LUCENE-804
             Project: Lucene - Java
          Issue Type: Task
          Components: Other
    Affects Versions: 2.1
            Reporter: Doron Cohen
            Priority: Minor
             Fix For: 2.1


Currently the packed src distribution would fail to run "ant build-contrib".
It would be much nicer if that work.
In fact, would be nicer if you could even "re-pack" with it.

For now I marked this for 2.1, although I am not yet sure if this is a stopper.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Commented: (LUCENE-804) build.xml: result of "dist-src" should support "build-contrib"

Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473316 ]

Doron Cohen commented on LUCENE-804:
------------------------------------

This can be easily fixed like this:

Index: build.xml
===================================================================
--- build.xml   (revision 507610)
+++ build.xml   (working copy)
@@ -37,7 +37,7 @@

   <patternset id="src.dist.patterns"
               includes="src/,build.xml,*build*.xml,docs/,*.txt,contrib/,"
-              excludes="contrib/*/lib/,src/site/build/"
+              excludes="contrib/db/*/lib/,contrib/*/ext-libs/,src/site/build/"
   />
   <patternset id="binary.build.dist.patterns"
               includes="${final.name}.jar,${demo.war.name}.war,${demo.name}.jar,docs/,contrib/*/*.jar"

A nicer fix would be to also modify contrib/db to have ext-libs rather than lib (like gdata), but
for not holding 2.1 this is good enough I think.

Running "ant -Dversion=2.1.0 dist dist-src" like this and unpacking the src.zip, reults in
the same content as a clean "svn co" (except for the unwanted index.html").

> build.xml: result of "dist-src" should support "build-contrib"
> --------------------------------------------------------------
>
>                 Key: LUCENE-804
>                 URL: https://issues.apache.org/jira/browse/LUCENE-804
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: Other
>    Affects Versions: 2.1
>            Reporter: Doron Cohen
>            Priority: Minor
>             Fix For: 2.1
>
>
> Currently the packed src distribution would fail to run "ant build-contrib".
> It would be much nicer if that work.
> In fact, would be nicer if you could even "re-pack" with it.
> For now I marked this for 2.1, although I am not yet sure if this is a stopper.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Updated: (LUCENE-804) build.xml: result of "dist-src" should support "build-contrib"

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doron Cohen updated LUCENE-804:
-------------------------------

    Attachment: 804.build.xml.patch

804.build.xml.patch removes loadable jars from the src_dist
and adds back in jars that are (currently) not downloadable. This
allows src_dist to compile contribs (or even to "re-dist").

src-dist size effect of this - reduced from 8.9 MB to 6.8 MB.


> build.xml: result of "dist-src" should support "build-contrib"
> --------------------------------------------------------------
>
>                 Key: LUCENE-804
>                 URL: https://issues.apache.org/jira/browse/LUCENE-804
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: Other
>    Affects Versions: 2.1
>            Reporter: Doron Cohen
>            Priority: Minor
>             Fix For: 2.1
>
>         Attachments: 804.build.xml.patch
>
>
> Currently the packed src distribution would fail to run "ant build-contrib".
> It would be much nicer if that work.
> In fact, would be nicer if you could even "re-pack" with it.
> For now I marked this for 2.1, although I am not yet sure if this is a stopper.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Updated: (LUCENE-804) build.xml: result of "dist-src" should support "build-contrib"

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doron Cohen updated LUCENE-804:
-------------------------------

    Lucene Fields: [New, Patch Available]  (was: [New])

> build.xml: result of "dist-src" should support "build-contrib"
> --------------------------------------------------------------
>
>                 Key: LUCENE-804
>                 URL: https://issues.apache.org/jira/browse/LUCENE-804
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: Other
>    Affects Versions: 2.1
>            Reporter: Doron Cohen
>            Priority: Minor
>             Fix For: 2.1
>
>         Attachments: 804.build.xml.patch
>
>
> Currently the packed src distribution would fail to run "ant build-contrib".
> It would be much nicer if that work.
> In fact, would be nicer if you could even "re-pack" with it.
> For now I marked this for 2.1, although I am not yet sure if this is a stopper.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Updated: (LUCENE-804) build.xml: result of "dist-src" should support "build-contrib"

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doron Cohen updated LUCENE-804:
-------------------------------

        Lucene Fields: [Patch Available]  (was: [Patch Available, New])
    Affects Version/s:     (was: 2.1)
        Fix Version/s:     (was: 2.1)
             Assignee: Doron Cohen

[1]  Modifying 'fix version' to not be 2.1, thereby clarifying that,
since releases are to be more frequent, this should not be
regarded as a stopper to release 2.1.

[2]  I would like to commit this in a day or so (unless anyone
points a problem with this).


> build.xml: result of "dist-src" should support "build-contrib"
> --------------------------------------------------------------
>
>                 Key: LUCENE-804
>                 URL: https://issues.apache.org/jira/browse/LUCENE-804
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: Other
>            Reporter: Doron Cohen
>         Assigned To: Doron Cohen
>            Priority: Minor
>         Attachments: 804.build.xml.patch
>
>
> Currently the packed src distribution would fail to run "ant build-contrib".
> It would be much nicer if that work.
> In fact, would be nicer if you could even "re-pack" with it.
> For now I marked this for 2.1, although I am not yet sure if this is a stopper.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Resolved: (LUCENE-804) build.xml: result of "dist-src" should support "build-contrib"

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/LUCENE-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doron Cohen resolved LUCENE-804.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 2.2

Commited this.
Fixing of contrib/db/* to have downloadable jars in ext-lib rather than lib should be done, if at all, under a separate issue.

> build.xml: result of "dist-src" should support "build-contrib"
> --------------------------------------------------------------
>
>                 Key: LUCENE-804
>                 URL: https://issues.apache.org/jira/browse/LUCENE-804
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: Other
>            Reporter: Doron Cohen
>         Assigned To: Doron Cohen
>            Priority: Minor
>             Fix For: 2.2
>
>         Attachments: 804.build.xml.patch
>
>
> Currently the packed src distribution would fail to run "ant build-contrib".
> It would be much nicer if that work.
> In fact, would be nicer if you could even "re-pack" with it.
> For now I marked this for 2.1, although I am not yet sure if this is a stopper.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]