Created: (SOLR-174) Add multi-param support to qf,pf,bf,bq

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Created: (SOLR-174) Add multi-param support to qf,pf,bf,bq

Sebastian Nagel (Jira)
Add multi-param support to qf,pf,bf,bq
--------------------------------------

                 Key: SOLR-174
                 URL: https://issues.apache.org/jira/browse/SOLR-174
             Project: Solr
          Issue Type: Improvement
          Components: search
    Affects Versions: 1.2
            Reporter: Mike Klaas
         Assigned To: Mike Klaas
            Priority: Minor
             Fix For: 1.2


A quick patch that adds multi-params support for the listed dismax params.

I opened an issue to get some feedback on the bq situation.  I left the subquery-extraction logic as in, applying it to each specified boost query.  I'm not sure this is still valid given coordFactor and such.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

Updated: (SOLR-174) Add multi-param support to qf,pf,bf,bq

Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Klaas updated SOLR-174:
----------------------------

    Attachment: multiparam.patch

(also includes a two-line change to re-write queries prior to highlighting)

> Add multi-param support to qf,pf,bf,bq
> --------------------------------------
>
>                 Key: SOLR-174
>                 URL: https://issues.apache.org/jira/browse/SOLR-174
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.2
>            Reporter: Mike Klaas
>         Assigned To: Mike Klaas
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: multiparam.patch
>
>
> A quick patch that adds multi-params support for the listed dismax params.
> I opened an issue to get some feedback on the bq situation.  I left the subquery-extraction logic as in, applying it to each specified boost query.  I'm not sure this is still valid given coordFactor and such.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

Commented: (SOLR-174) Add multi-param support to qf,pf,bf,bq

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476526 ]

Hoss Man commented on SOLR-174:
-------------------------------

Mike: havne't looked into the patch, but what i was thinking would make sense for the bq issue back when i last thought about this, was to say:

  if: more then one bq param is specified:
     then:
       foreach bq param value:
         trim the value
         if: the value is non blank
            then: parse value as a query and add to the main query
  else:
     legacy behavior

...that should be entirely backwards compatible, and gives people who really need a boolean query with a boost of 1 a way to force it (by adding a <null name="bq" /> to their appended params)

...we would just have to make sure it was clearly documented

thoughts?

> Add multi-param support to qf,pf,bf,bq
> --------------------------------------
>
>                 Key: SOLR-174
>                 URL: https://issues.apache.org/jira/browse/SOLR-174
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.2
>            Reporter: Mike Klaas
>         Assigned To: Mike Klaas
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: multiparam.patch
>
>
> A quick patch that adds multi-params support for the listed dismax params.
> I opened an issue to get some feedback on the bq situation.  I left the subquery-extraction logic as in, applying it to each specified boost query.  I'm not sure this is still valid given coordFactor and such.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

Commented: (SOLR-174) Add multi-param support to qf,pf,bf,bq

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477060 ]

Mike Klaas commented on SOLR-174:
---------------------------------

That's fine with me.  I suspect too that anyone who knows lucene well enough and is trying to get such a precise query structure would feel comfortable tweaking dismax to create their own reqeust handler.

I'll update the patch in a few minutes.

> Add multi-param support to qf,pf,bf,bq
> --------------------------------------
>
>                 Key: SOLR-174
>                 URL: https://issues.apache.org/jira/browse/SOLR-174
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.2
>            Reporter: Mike Klaas
>         Assigned To: Mike Klaas
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: multiparam.patch
>
>
> A quick patch that adds multi-params support for the listed dismax params.
> I opened an issue to get some feedback on the bq situation.  I left the subquery-extraction logic as in, applying it to each specified boost query.  I'm not sure this is still valid given coordFactor and such.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

Updated: (SOLR-174) Add multi-param support to qf,pf,bf,bq

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Klaas updated SOLR-174:
----------------------------

    Attachment: multiparam.patch

updated patch as per Hoss' comments.  This could use a once-over before committing.

> Add multi-param support to qf,pf,bf,bq
> --------------------------------------
>
>                 Key: SOLR-174
>                 URL: https://issues.apache.org/jira/browse/SOLR-174
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.2
>            Reporter: Mike Klaas
>         Assigned To: Mike Klaas
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: multiparam.patch, multiparam.patch
>
>
> A quick patch that adds multi-params support for the listed dismax params.
> I opened an issue to get some feedback on the bq situation.  I left the subquery-extraction logic as in, applying it to each specified boost query.  I'm not sure this is still valid given coordFactor and such.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

Commented: (SOLR-174) Add multi-param support to qf,pf,bf,bq

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477820 ]

Hoss Man commented on SOLR-174:
-------------------------------

Mike: patch reads nice and clean to me (didn't try applying though)

two nits:

1) it would be good to have a test of the case where a boolean with the default boost is specified in one bq, and a seperate blank bq is specified to force the first BQ to be treated as a single query

2) let's assign  params.getParams(DMP.BQ) to a temp variable so we don't have to call it twice in three lines.

> Add multi-param support to qf,pf,bf,bq
> --------------------------------------
>
>                 Key: SOLR-174
>                 URL: https://issues.apache.org/jira/browse/SOLR-174
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.2
>            Reporter: Mike Klaas
>         Assigned To: Mike Klaas
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: multiparam.patch, multiparam.patch
>
>
> A quick patch that adds multi-params support for the listed dismax params.
> I opened an issue to get some feedback on the bq situation.  I left the subquery-extraction logic as in, applying it to each specified boost query.  I'm not sure this is still valid given coordFactor and such.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

Resolved: (SOLR-174) Add multi-param support to qf,pf,bf,bq

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Klaas resolved SOLR-174.
-----------------------------

    Resolution: Fixed

committed in r514851

> Add multi-param support to qf,pf,bf,bq
> --------------------------------------
>
>                 Key: SOLR-174
>                 URL: https://issues.apache.org/jira/browse/SOLR-174
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.2
>            Reporter: Mike Klaas
>         Assigned To: Mike Klaas
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: multiparam.patch, multiparam.patch
>
>
> A quick patch that adds multi-params support for the listed dismax params.
> I opened an issue to get some feedback on the bq situation.  I left the subquery-extraction logic as in, applying it to each specified boost query.  I'm not sure this is still valid given coordFactor and such.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.