Created: (SOLR-177) ResponseWriter should support Iterator/Iterable rather then Collection

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Created: (SOLR-177) ResponseWriter should support Iterator/Iterable rather then Collection

Sebastian Nagel (Jira)
ResponseWriter should support Iterator/Iterable rather then Collection
----------------------------------------------------------------------

                 Key: SOLR-177
                 URL: https://issues.apache.org/jira/browse/SOLR-177
             Project: Solr
          Issue Type: Improvement
            Reporter: Ryan McKinley
             Fix For: 1.2
         Attachments: SOLR-177-IteratorResponseWriter.patch

The standard response writers should support an Iterator/Iterable object rather then printing them out as iterator.toString()

This patch slightly modifies the existing 'Collection' code to support Iterator or Iterable objects

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

Updated: (SOLR-177) ResponseWriter should support Iterator/Iterable rather then Collection

Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley updated SOLR-177:
-------------------------------

    Attachment: SOLR-177-IteratorResponseWriter.patch

> ResponseWriter should support Iterator/Iterable rather then Collection
> ----------------------------------------------------------------------
>
>                 Key: SOLR-177
>                 URL: https://issues.apache.org/jira/browse/SOLR-177
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>             Fix For: 1.2
>
>         Attachments: SOLR-177-IteratorResponseWriter.patch
>
>
> The standard response writers should support an Iterator/Iterable object rather then printing them out as iterator.toString()
> This patch slightly modifies the existing 'Collection' code to support Iterator or Iterable objects

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

Resolved: (SOLR-177) ResponseWriter should support Iterator/Iterable rather then Collection

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yonik Seeley resolved SOLR-177.
-------------------------------

    Resolution: Fixed

Committed.  Thanks Ryan!

> ResponseWriter should support Iterator/Iterable rather then Collection
> ----------------------------------------------------------------------
>
>                 Key: SOLR-177
>                 URL: https://issues.apache.org/jira/browse/SOLR-177
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>             Fix For: 1.2
>
>         Attachments: SOLR-177-IteratorResponseWriter.patch
>
>
> The standard response writers should support an Iterator/Iterable object rather then printing them out as iterator.toString()
> This patch slightly modifies the existing 'Collection' code to support Iterator or Iterable objects

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

Commented: (SOLR-177) ResponseWriter should support Iterator/Iterable rather then Collection

Sebastian Nagel (Jira)
In reply to this post by Sebastian Nagel (Jira)

    [ https://issues.apache.org/jira/browse/SOLR-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477693 ]

Ryan McKinley commented on SOLR-177:
------------------------------------

Thanks!  that was fast.

I should make them all this easy.

> ResponseWriter should support Iterator/Iterable rather then Collection
> ----------------------------------------------------------------------
>
>                 Key: SOLR-177
>                 URL: https://issues.apache.org/jira/browse/SOLR-177
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>             Fix For: 1.2
>
>         Attachments: SOLR-177-IteratorResponseWriter.patch
>
>
> The standard response writers should support an Iterator/Iterable object rather then printing them out as iterator.toString()
> This patch slightly modifies the existing 'Collection' code to support Iterator or Iterable objects

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

Re: Commented: (SOLR-177) ResponseWriter should support Iterator/Iterable rather then Collection

Chris Hostetter-3

: Thanks!  that was fast.
:
: I should make them all this easy.

You've stumbled upon the secret: patches that fix one bug, or add one
feature that is clearly beneficial; touch the smallest number of files
neccessary to be complete, and are completley backwards compatible are
really easy to commit.  :)




-Hoss