Created: (SOLR-179) Save me from myself! Abort on configuration errors

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Created: (SOLR-179) Save me from myself! Abort on configuration errors

Jan Høydahl (Jira)
Save me from myself!  Abort on configuration errors
---------------------------------------------------

                 Key: SOLR-179
                 URL: https://issues.apache.org/jira/browse/SOLR-179
             Project: Solr
          Issue Type: Improvement
            Reporter: Ryan McKinley
             Fix For: 1.2


When something goes wrong in solr configuration, I want solr to stop working and loudly say "something went wrong"  This patch adds a collection of severe errors to SolrConfig.  If abortOnConfigurationError=true and there are errors, the SolrDispatchFilter prints out a nice message saying "hey something went wrong!"

The specific things that were hidden in error files that will now give dramatic error are:
 * unknown class for RequestHandler/ResponseWriter
 * any exception throw during handler/writer init()

If you want to disable this behavior (perhaps for a production environment) you need to add:
  <abortOnConfigurationError>false</abortOnConfigurationError>
to solrconfig.xml


for more discussion, see:
http://www.nabble.com/merely-a-suggestion%3A-schema.xml-validator-or-better-schema-validation-logging-tf3331929.html



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

Updated: (SOLR-179) Save me from myself! Abort on configuration errors

Jan Høydahl (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley updated SOLR-179:
-------------------------------

    Attachment: SOLR-179-ConfigurationErrors.patch

This is using Erik's new system propety substition to make changing configuraiton for devlopment/production sites easier

  <abortOnConfigurationError>${solr.abortOnConfigurationError:true}</abortOnConfigurationError>



> Save me from myself!  Abort on configuration errors
> ---------------------------------------------------
>
>                 Key: SOLR-179
>                 URL: https://issues.apache.org/jira/browse/SOLR-179
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>             Fix For: 1.2
>
>         Attachments: SOLR-179-ConfigurationErrors.patch
>
>
> When something goes wrong in solr configuration, I want solr to stop working and loudly say "something went wrong"  This patch adds a collection of severe errors to SolrConfig.  If abortOnConfigurationError=true and there are errors, the SolrDispatchFilter prints out a nice message saying "hey something went wrong!"
> The specific things that were hidden in error files that will now give dramatic error are:
>  * unknown class for RequestHandler/ResponseWriter
>  * any exception throw during handler/writer init()
> If you want to disable this behavior (perhaps for a production environment) you need to add:
>   <abortOnConfigurationError>false</abortOnConfigurationError>
> to solrconfig.xml
> for more discussion, see:
> http://www.nabble.com/merely-a-suggestion%3A-schema.xml-validator-or-better-schema-validation-logging-tf3331929.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

Updated: (SOLR-179) Save me from myself! Abort on configuration errors

Jan Høydahl (Jira)
In reply to this post by Jan Høydahl (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley updated SOLR-179:
-------------------------------

    Attachment: SOLR-179-ConfigurationErrors.patch

updated to apply cleanly with trunk.

I looked into having the SolrDispatchFilter.init() thow an exception that would hopefully abort the web-app.  This works in Resin, but in Jetty it just logs the error and continues normally -- at that point it gives a 404 for any request though.

rather then have undefined behavior, this caches the error string and spits it out for every request.

> Save me from myself!  Abort on configuration errors
> ---------------------------------------------------
>
>                 Key: SOLR-179
>                 URL: https://issues.apache.org/jira/browse/SOLR-179
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>             Fix For: 1.2
>
>         Attachments: SOLR-179-ConfigurationErrors.patch, SOLR-179-ConfigurationErrors.patch
>
>
> When something goes wrong in solr configuration, I want solr to stop working and loudly say "something went wrong"  This patch adds a collection of severe errors to SolrConfig.  If abortOnConfigurationError=true and there are errors, the SolrDispatchFilter prints out a nice message saying "hey something went wrong!"
> The specific things that were hidden in error files that will now give dramatic error are:
>  * unknown class for RequestHandler/ResponseWriter
>  * any exception throw during handler/writer init()
> If you want to disable this behavior (perhaps for a production environment) you need to add:
>   <abortOnConfigurationError>false</abortOnConfigurationError>
> to solrconfig.xml
> for more discussion, see:
> http://www.nabble.com/merely-a-suggestion%3A-schema.xml-validator-or-better-schema-validation-logging-tf3331929.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (SOLR-179) Save me from myself! Abort on configuration errors

Jan Høydahl (Jira)
In reply to this post by Jan Høydahl (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley reassigned SOLR-179:
----------------------------------

    Assignee: Ryan McKinley

> Save me from myself!  Abort on configuration errors
> ---------------------------------------------------
>
>                 Key: SOLR-179
>                 URL: https://issues.apache.org/jira/browse/SOLR-179
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>         Assigned To: Ryan McKinley
>             Fix For: 1.2
>
>         Attachments: SOLR-179-ConfigurationErrors.patch, SOLR-179-ConfigurationErrors.patch
>
>
> When something goes wrong in solr configuration, I want solr to stop working and loudly say "something went wrong"  This patch adds a collection of severe errors to SolrConfig.  If abortOnConfigurationError=true and there are errors, the SolrDispatchFilter prints out a nice message saying "hey something went wrong!"
> The specific things that were hidden in error files that will now give dramatic error are:
>  * unknown class for RequestHandler/ResponseWriter
>  * any exception throw during handler/writer init()
> If you want to disable this behavior (perhaps for a production environment) you need to add:
>   <abortOnConfigurationError>false</abortOnConfigurationError>
> to solrconfig.xml
> for more discussion, see:
> http://www.nabble.com/merely-a-suggestion%3A-schema.xml-validator-or-better-schema-validation-logging-tf3331929.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (SOLR-179) Save me from myself! Abort on configuration errors

Jan Høydahl (Jira)
In reply to this post by Jan Høydahl (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley updated SOLR-179:
-------------------------------

    Attachment: SOLR-179-ConfigurationErrors.patch

compiles with trunk.  I will commit this as it does not require anyone to change their solrconfig.xml (except to override the behavior)

> Save me from myself!  Abort on configuration errors
> ---------------------------------------------------
>
>                 Key: SOLR-179
>                 URL: https://issues.apache.org/jira/browse/SOLR-179
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>         Assigned To: Ryan McKinley
>             Fix For: 1.2
>
>         Attachments: SOLR-179-ConfigurationErrors.patch, SOLR-179-ConfigurationErrors.patch, SOLR-179-ConfigurationErrors.patch
>
>
> When something goes wrong in solr configuration, I want solr to stop working and loudly say "something went wrong"  This patch adds a collection of severe errors to SolrConfig.  If abortOnConfigurationError=true and there are errors, the SolrDispatchFilter prints out a nice message saying "hey something went wrong!"
> The specific things that were hidden in error files that will now give dramatic error are:
>  * unknown class for RequestHandler/ResponseWriter
>  * any exception throw during handler/writer init()
> If you want to disable this behavior (perhaps for a production environment) you need to add:
>   <abortOnConfigurationError>false</abortOnConfigurationError>
> to solrconfig.xml
> for more discussion, see:
> http://www.nabble.com/merely-a-suggestion%3A-schema.xml-validator-or-better-schema-validation-logging-tf3331929.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Resolved: (SOLR-179) Save me from myself! Abort on configuration errors

Jan Høydahl (Jira)
In reply to this post by Jan Høydahl (Jira)

     [ https://issues.apache.org/jira/browse/SOLR-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley resolved SOLR-179.
--------------------------------

    Resolution: Fixed

> Save me from myself!  Abort on configuration errors
> ---------------------------------------------------
>
>                 Key: SOLR-179
>                 URL: https://issues.apache.org/jira/browse/SOLR-179
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>         Assigned To: Ryan McKinley
>             Fix For: 1.2
>
>         Attachments: SOLR-179-ConfigurationErrors.patch, SOLR-179-ConfigurationErrors.patch, SOLR-179-ConfigurationErrors.patch
>
>
> When something goes wrong in solr configuration, I want solr to stop working and loudly say "something went wrong"  This patch adds a collection of severe errors to SolrConfig.  If abortOnConfigurationError=true and there are errors, the SolrDispatchFilter prints out a nice message saying "hey something went wrong!"
> The specific things that were hidden in error files that will now give dramatic error are:
>  * unknown class for RequestHandler/ResponseWriter
>  * any exception throw during handler/writer init()
> If you want to disable this behavior (perhaps for a production environment) you need to add:
>   <abortOnConfigurationError>false</abortOnConfigurationError>
> to solrconfig.xml
> for more discussion, see:
> http://www.nabble.com/merely-a-suggestion%3A-schema.xml-validator-or-better-schema-validation-logging-tf3331929.html

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.