[DISCUSS] Prefer Github PR Integration over patch in JIRA

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[DISCUSS] Prefer Github PR Integration over patch in JIRA

Wei-Chiu Chuang-2
Historically, Hadoop developers create patches and attache them to JIRA,
andthen the Yetus bot runs precommit against the patch in the JIRA.

The Github PR is more convenient for code review and less hassle for
committers to merge a commit. I am proposing for the community to prefer
Github PR over the traditional patch-in-jira. This doesn't mean we will
reject the traditional way, but we can move gradually to the new way.
Additionally, update the Hadoop "How to contribute" wiki, and advertise
that Github PR is the preferred method.

Thoughts?
Reply | Threaded
Open this post in threaded view
|

Re: [DISCUSS] Prefer Github PR Integration over patch in JIRA

Sean Busbey-3
a word of caution. according to INFRA-18748, asf infra is going to be
cutting out blind PR building. So we'll need to be sure that precommit
integration works e.g. testing PRs because there's a JIRA that a
whitelisted contributor has associated and put in patch available
status.

On Mon, Jul 22, 2019 at 1:06 PM Wei-Chiu Chuang <[hidden email]> wrote:

>
> Historically, Hadoop developers create patches and attache them to JIRA,
> andthen the Yetus bot runs precommit against the patch in the JIRA.
>
> The Github PR is more convenient for code review and less hassle for
> committers to merge a commit. I am proposing for the community to prefer
> Github PR over the traditional patch-in-jira. This doesn't mean we will
> reject the traditional way, but we can move gradually to the new way.
> Additionally, update the Hadoop "How to contribute" wiki, and advertise
> that Github PR is the preferred method.
>
> Thoughts?



--
busbey

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]