GitBox emails in issues@ list

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

GitBox emails in issues@ list

Jan Høydahl / Cominvent
GitBox emails on the issues@ list are not threaded per PullRequest.
It would be very beneficial if all GitBox mails for the same PR# be grouped in same thread for easier consumption.
I guess that would mean they have identical Email Subject, instead of today when the Subject varies per comment:

[GitHub] [lucene-solr] chatman commented on a change in pull request #929: SOLR-13821: Package Store for storing package artefacts

Anyone know if it is possible?

--
Jan Høydahl, search solution architect
Cominvent AS - www.cominvent.com


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: GitBox emails in issues@ list

Adrien Grand
I don't know if that is possible, but I would appreciate threaded
responses much better too!

On Thu, Oct 10, 2019 at 11:11 PM Jan Høydahl <[hidden email]> wrote:

>
> GitBox emails on the issues@ list are not threaded per PullRequest.
> It would be very beneficial if all GitBox mails for the same PR# be grouped in same thread for easier consumption.
> I guess that would mean they have identical Email Subject, instead of today when the Subject varies per comment:
>
> [GitHub] [lucene-solr] chatman commented on a change in pull request #929: SOLR-13821: Package Store for storing package artefacts
>
> Anyone know if it is possible?
>
> --
> Jan Høydahl, search solution architect
> Cominvent AS - www.cominvent.com
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


--
Adrien

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: GitBox emails in issues@ list

Michael Sokolov-4
https://developers.google.com/gmail/api/guides/threads explains the
threading criteria, at least for its APIs. It says:

The References and In-Reply-To headers must be set in compliance with
the RFC 2822 standard.

The Subject headers must match.

so clearly the Subject matters. Probably it can handle Re: prefixes?

https://help.github.com/en/enterprise/2.18/user/articles/about-email-notifications
doesn't say much about being able to configure Subjects though

On Fri, Oct 11, 2019 at 10:40 AM Adrien Grand <[hidden email]> wrote:

>
> I don't know if that is possible, but I would appreciate threaded
> responses much better too!
>
> On Thu, Oct 10, 2019 at 11:11 PM Jan Høydahl <[hidden email]> wrote:
> >
> > GitBox emails on the issues@ list are not threaded per PullRequest.
> > It would be very beneficial if all GitBox mails for the same PR# be grouped in same thread for easier consumption.
> > I guess that would mean they have identical Email Subject, instead of today when the Subject varies per comment:
> >
> > [GitHub] [lucene-solr] chatman commented on a change in pull request #929: SOLR-13821: Package Store for storing package artefacts
> >
> > Anyone know if it is possible?
> >
> > --
> > Jan Høydahl, search solution architect
> > Cominvent AS - www.cominvent.com
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
>
>
> --
> Adrien
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: GitBox emails in issues@ list

Jan Høydahl / Cominvent
Hi

GitBox is an Apache service run by Infra, those emails don't come from GitHub directly.

I see that the mails coming from JIRA to issues@ list has those References and In-Reply-To headers and they thread well.
But emails from GitBox only contain Message-Id, like this

Message-ID: <[hidden email]>

The script that receives Webhook callbacks from GitHub seems to be this one

So I guess it should not be too hard to extend this script with a capability to generate a stable well-defined Message-Id on all "…opened a new PR", and then generate References and In-Reply-To headers for subsequent actions on the same PR.

Anyone want to attempt a PR for Infra? :)
There's already a similar JIRA INFRA-18350 suggesting a shorter subject, but we should probably create a new JIRA for the threading.

--
Jan Høydahl, search solution architect
Cominvent AS - www.cominvent.com

11. okt. 2019 kl. 23:16 skrev Michael Sokolov <[hidden email]>:

https://developers.google.com/gmail/api/guides/threads explains the
threading criteria, at least for its APIs. It says:

The References and In-Reply-To headers must be set in compliance with
the RFC 2822 standard.

The Subject headers must match.

so clearly the Subject matters. Probably it can handle Re: prefixes?

https://help.github.com/en/enterprise/2.18/user/articles/about-email-notifications
doesn't say much about being able to configure Subjects though

On Fri, Oct 11, 2019 at 10:40 AM Adrien Grand <[hidden email]> wrote:

I don't know if that is possible, but I would appreciate threaded
responses much better too!

On Thu, Oct 10, 2019 at 11:11 PM Jan Høydahl <[hidden email]> wrote:

GitBox emails on the issues@ list are not threaded per PullRequest.
It would be very beneficial if all GitBox mails for the same PR# be grouped in same thread for easier consumption.
I guess that would mean they have identical Email Subject, instead of today when the Subject varies per comment:

[GitHub] [lucene-solr] chatman commented on a change in pull request #929: SOLR-13821: Package Store for storing package artefacts

Anyone know if it is possible?

--
Jan Høydahl, search solution architect
Cominvent AS - www.cominvent.com


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]



--
Adrien

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]


Reply | Threaded
Open this post in threaded view
|

Re: GitBox emails in issues@ list

Jan Høydahl / Cominvent

--
Jan Høydahl, search solution architect
Cominvent AS - www.cominvent.com

13. okt. 2019 kl. 02:38 skrev Jan Høydahl <[hidden email]>:

Hi

GitBox is an Apache service run by Infra, those emails don't come from GitHub directly.

I see that the mails coming from JIRA to issues@ list has those References and In-Reply-To headers and they thread well.
But emails from GitBox only contain Message-Id, like this

Message-ID: <[hidden email]>

The script that receives Webhook callbacks from GitHub seems to be this one

So I guess it should not be too hard to extend this script with a capability to generate a stable well-defined Message-Id on all "…opened a new PR", and then generate References and In-Reply-To headers for subsequent actions on the same PR.

Anyone want to attempt a PR for Infra? :)
There's already a similar JIRA INFRA-18350 suggesting a shorter subject, but we should probably create a new JIRA for the threading.

--
Jan Høydahl, search solution architect
Cominvent AS - www.cominvent.com

11. okt. 2019 kl. 23:16 skrev Michael Sokolov <[hidden email]>:

https://developers.google.com/gmail/api/guides/threads explains the
threading criteria, at least for its APIs. It says:

The References and In-Reply-To headers must be set in compliance with
the RFC 2822 standard.

The Subject headers must match.

so clearly the Subject matters. Probably it can handle Re: prefixes?

https://help.github.com/en/enterprise/2.18/user/articles/about-email-notifications
doesn't say much about being able to configure Subjects though

On Fri, Oct 11, 2019 at 10:40 AM Adrien Grand <[hidden email]> wrote:

I don't know if that is possible, but I would appreciate threaded
responses much better too!

On Thu, Oct 10, 2019 at 11:11 PM Jan Høydahl <[hidden email]> wrote:

GitBox emails on the issues@ list are not threaded per PullRequest.
It would be very beneficial if all GitBox mails for the same PR# be grouped in same thread for easier consumption.
I guess that would mean they have identical Email Subject, instead of today when the Subject varies per comment:

[GitHub] [lucene-solr] chatman commented on a change in pull request #929: SOLR-13821: Package Store for storing package artefacts

Anyone know if it is possible?

--
Jan Høydahl, search solution architect
Cominvent AS - www.cominvent.com


---------------------------------------------------------------------
To unsubscribe, [hidden email]
For additional commands, [hidden email]



--
Adrien

---------------------------------------------------------------------
To unsubscribe, [hidden email]
For additional commands, [hidden email]


---------------------------------------------------------------------
To unsubscribe, [hidden email]
For additional commands, [hidden email]