[GitHub] [lucene-solr] gerlowskija commented on issue #665: Fixes SOLR-13539

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[GitHub] [lucene-solr] gerlowskija commented on issue #665: Fixes SOLR-13539

gerlowskija commented on issue #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-507078815
   I was able to clean up some of the failures locally by removing the second clause in the if-statement below.  (This was added in this PR in EmbeddedSolrServer)
    private Set<ContentStream> getContentStreams(final SolrRequest<?> request) throws IOException {
       if (request.getMethod() == SolrRequest.METHOD.GET || request instanceof QueryRequest) return null;
   This makes sense....there are some QueryRequest implementations that are supposed to be POST's.  (e.g. JSON-queries and JSON-faceting requests, Solr tagging requests, etc.).  But there are still other failing tests that rely on SolrJettyTestBase.  So I haven't figured it out yet, but something's still not quite right in that base-class.
   With Cao Manh Dat working on the 8.1.2 release, and Ignacio Vera talking about an 8.2 shortly afterward, if we can't figure out the test issues soon, it might be best to split the functionality changes and test-base changes into two separate PR's if possible.  I'd hate for this fix to miss the next crop of releases because we couldn't cross the finish line on test-changes also bundled into this commit.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]

With regards,
Apache Git Services

To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]