[GitHub] [lucene-solr] iverase commented on a change in pull request #844: LUCENE-8860: Make more decision on inner nodes in ShapeBoundingBoxQuery

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [lucene-solr] iverase commented on a change in pull request #844: LUCENE-8860: Make more decision on inner nodes in ShapeBoundingBoxQuery

GitBox
iverase commented on a change in pull request #844: LUCENE-8860: Make more decision on inner nodes in ShapeBoundingBoxQuery
URL: https://github.com/apache/lucene-solr/pull/844#discussion_r318499581
 
 

 ##########
 File path: lucene/sandbox/src/java/org/apache/lucene/document/XYShapeBoundingBoxQuery.java
 ##########
 @@ -41,7 +41,8 @@ public XYShapeBoundingBoxQuery(String field, QueryRelation queryRelation, double
   @Override
   protected PointValues.Relation relateRangeBBoxToQuery(int minXOffset, int minYOffset, byte[] minTriangle,
                                                         int maxXOffset, int maxYOffset, byte[] maxTriangle) {
-    return rectangle2D.relateRangeBBox(minXOffset, minYOffset, minTriangle, maxXOffset, maxYOffset, maxTriangle);
+    return rectangle2D.relateRangeBBox(minXOffset, minYOffset, minTriangle, maxXOffset, maxYOffset, maxTriangle,
+        queryRelation == QueryRelation.INTERSECTS);
 
 Review comment:
   Shouldn't this work as well for Disjoint?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]