[GitHub] [lucene-solr] jimczi commented on issue #862: LUCENE-8971: Enable constructing JapaneseTokenizer with custom dictio…

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [lucene-solr] jimczi commented on issue #862: LUCENE-8971: Enable constructing JapaneseTokenizer with custom dictio…

GitBox
jimczi commented on issue #862: LUCENE-8971: Enable constructing JapaneseTokenizer with custom dictio…
URL: https://github.com/apache/lucene-solr/pull/862#issuecomment-530492308
 
 
   > Jim, I'm sorry - there was no comment for several days, so I assumed it was OK to push
   
   No problem.
   
   > DictionaryBuilder was moved into the main jar
   
   I forgot that the DictionaryBuilder has moved into the main jar. Should it be marked experimental then ? The fact that we ship a single dictionary within the jar also ensures that it is built from the same version but this change breaks this assumption. What kind of compatibility are we expecting here ? Should we require users to rebuild binary dictionary on each minor version ?
   
   > Let's discuss, and if there's a problem I can revert?
   
   Maybe give a few more days for @mocobeta to review as well ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]