[GitHub] [lucene-solr] msokolov commented on issue #862: LUCENE-8971: Enable constructing JapaneseTokenizer with custom dictio…

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [lucene-solr] msokolov commented on issue #862: LUCENE-8971: Enable constructing JapaneseTokenizer with custom dictio…

GitBox
msokolov commented on issue #862: LUCENE-8971: Enable constructing JapaneseTokenizer with custom dictio…
URL: https://github.com/apache/lucene-solr/pull/862#issuecomment-530481447
 
 
   Jim, I'm sorry - there was no comment for several days, so I assumed it was OK to push. Let's discuss, and if there's a problem I can revert? DictionaryBuilder was moved into the main jar (no longer part of tools) in LUCENE-8871, so I think the software is all there - we have been using it in an automated build in our system with a patched version of Lucene. Arguably we could/should have documentation around this, that is clearly lacking, but given the complexity of this "feature" I feel it is pretty expert.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]