[GitHub] [lucene-solr] thomaswoeckinger commented on issue #665: Fixes SOLR-13539

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [lucene-solr] thomaswoeckinger commented on issue #665: Fixes SOLR-13539

GitBox
thomaswoeckinger commented on issue #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-507443102
 
 
   > Ok. I was worried we'd miss 8.1.2, so I took your changes to AbstractEnumField, BinaryField, BoolField, and UUIDField and merged them in a much smaller commit of their own. (see here: [8242e6c](https://github.com/apache/lucene-solr/commit/8242e6ce1da141e5585c0a8cd7ffc5953c5bf035)) This commit didn't include any of your test changes, unfortunately.
   >
   > (I don't like to merge code without tests, but since I'd seen and run the tests you added in this PR specifically for those field types, and tested it manually, I felt pretty confident.)
   >
   > Anyway, I'll take a look at 755 and run the tests later today. Since your latest test changes are over in 755, and the atomic-update related field changes have already been merged, is there a reason to keep this PR around? We could just work off of 755 and close this out, unless there's a reason you see to keep both 755 and 665 open?
   
   The only reason is that the related issues are depending on each other, so i think it is still more clear to do this whole stuff with the PR's #755 and #665. Rebasing should be no problem anyway.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]