[GitHub] [nutch] AthenaXiao opened a new pull request #524: [NUTCH-2786] add a warning for insecure TrustManager

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [nutch] AthenaXiao opened a new pull request #524: [NUTCH-2786] add a warning for insecure TrustManager

GitBox

AthenaXiao opened a new pull request #524:
URL: https://github.com/apache/nutch/pull/524


   Thanks for your contribution to [Apache Nutch](https://nutch.apache.org/)! Your help is appreciated!
   
   Before opening the pull request, please verify that
   * there is an open issue on the [Nutch issue tracker](https://issues.apache.org/jira/projects/NUTCH) which describes the problem or the improvement. We cannot accept pull requests without an issue because the change wouldn't be listed in the release notes.
   * the issue ID (`NUTCH-XXXX`)
     - is referenced in the title of the pull request
     - and placed in front of your commit messages
   * commits are squashed into a single one (or few commits for larger changes)
   * Java source code follows [Nutch Eclipse Code Formatting rules](https://github.com/apache/nutch/blob/master/eclipse-codeformat.xml)
   * Nutch is successfully built and unit tests pass by running `ant clean runtime test`
   * there should be no conflicts when merging the pull request branch into the *recent* master branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulled master branch.
   
   We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Nutch in general, please sign up for the [Nutch mailing list](https://nutch.apache.org/mailing_lists.html). Thanks!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [nutch] lewismc commented on pull request #524: [NUTCH-2786] add a warning for insecure TrustManager

GitBox

lewismc commented on pull request #524:
URL: https://github.com/apache/nutch/pull/524#issuecomment-747570772


   @AthenaXiao thanks for the patch. I think it would be more appropriate to provide Javadoc. Can you consider this and resubmit your patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [nutch] lewismc commented on pull request #524: [NUTCH-2786] add a warning for insecure TrustManager

GitBox
In reply to this post by GitBox

lewismc commented on pull request #524:
URL: https://github.com/apache/nutch/pull/524#issuecomment-757023226


   @AthenaXiao I'm going to close this issue off. The Class is present in quite a few places within the Nutch source. It is named appropriately and really down to the consumer how they use it. Some Javadoc would be preferred. In the absence of that, this patch is not going to be merged in its current state. Thank you


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [nutch] lewismc closed pull request #524: [NUTCH-2786] add a warning for insecure TrustManager

GitBox
In reply to this post by GitBox

lewismc closed pull request #524:
URL: https://github.com/apache/nutch/pull/524


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [nutch] lewismc commented on pull request #524: [NUTCH-2786] add a warning for insecure TrustManager

GitBox
In reply to this post by GitBox

lewismc commented on pull request #524:
URL: https://github.com/apache/nutch/pull/524#issuecomment-757023226


   @AthenaXiao I'm going to close this issue off. The Class is present in quite a few places within the Nutch source. It is named appropriately and really down to the consumer how they use it. Some Javadoc would be preferred. In the absence of that, this patch is not going to be merged in its current state. Thank you


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [nutch] lewismc closed pull request #524: [NUTCH-2786] add a warning for insecure TrustManager

GitBox
In reply to this post by GitBox

lewismc closed pull request #524:
URL: https://github.com/apache/nutch/pull/524


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]