[GitHub] [nutch] lewismc commented on a change in pull request #458: fix for NUTCH-1403 contributed by aalbahem

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [nutch] lewismc commented on a change in pull request #458: fix for NUTCH-1403 contributed by aalbahem

GitBox

lewismc commented on a change in pull request #458:
URL: https://github.com/apache/nutch/pull/458#discussion_r556012181



##########
File path: src/plugin/scoring-metadata/src/java/org/apache/nutch/scoring/metadata/package.html
##########
@@ -0,0 +1,17 @@
+<html>

Review comment:
       Please include ASLv2 header

##########
File path: src/plugin/scoring-metadata/src/test/org/apache/nutch/scoring/metadata/TestMetadataScoringFilter.java
##########
@@ -0,0 +1,113 @@
+package org.apache.nutch.scoring.metadata;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.io.Text;
+import org.apache.nutch.crawl.CrawlDatum;
+import org.apache.nutch.parse.*;
+import org.apache.nutch.protocol.Content;
+import org.apache.nutch.scoring.ScoringFilterException;
+import org.apache.nutch.util.NutchConfiguration;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+
+import java.util.HashMap;
+
+public class TestMetadataScoringFilter {
+
+  @Before

Review comment:
       This is redundant and can be removed.

##########
File path: src/plugin/scoring-metadata/src/test/org/apache/nutch/scoring/metadata/TestMetadataScoringFilter.java
##########
@@ -0,0 +1,113 @@
+package org.apache.nutch.scoring.metadata;

Review comment:
       Please include ASLv2 header




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]