[GitHub] [tika] onozaty opened a new pull request #378: fix for TIKA-3225 contributed by onozaty

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [tika] onozaty opened a new pull request #378: fix for TIKA-3225 contributed by onozaty

GitBox

onozaty opened a new pull request #378:
URL: https://github.com/apache/tika/pull/378


   Added a namespace declaration because it may cause an error when processing XML because there is no namespace declaration.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [tika] tballison commented on pull request #378: fix for TIKA-3225 contributed by onozaty

GitBox

tballison commented on pull request #378:
URL: https://github.com/apache/tika/pull/378#issuecomment-730360315


   LGTM. Any fellow devs object?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [tika] Gagravarr commented on pull request #378: fix for TIKA-3225 contributed by onozaty

GitBox
In reply to this post by GitBox

Gagravarr commented on pull request #378:
URL: https://github.com/apache/tika/pull/378#issuecomment-730375456


   The mime-info xml format was/is a standard[1], but we long ago added enough of our own matching types that other programs won't be able to cope fully with our file so we probably don't need to worry about externally testing the impact. Given the proposed change is standard xml, looks fine to me
   
   [1] https://specifications.freedesktop.org/shared-mime-info-spec/latest/ar01s02.html#idm45164881929088


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [tika] tballison merged pull request #378: fix for TIKA-3225 contributed by onozaty

GitBox
In reply to this post by GitBox

tballison merged pull request #378:
URL: https://github.com/apache/tika/pull/378


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]