Possible bug in protocol-httpclient -> HttpBasicAuthentication.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Possible bug in protocol-httpclient -> HttpBasicAuthentication.java

Juho Mäkinen
At least in the lastets nightly build, in HttpBasicAuthentication of
protocol-httpclient:

        String username = NutchConf.get().get("http.auth.basic." +
challenge + ".user");
        LOG.fine("BasicAuthentication username=" + username);
        String password = NutchConf.get().get("http.auth.basic." +
challenge + ".user");
        LOG.fine("BasicAuthentication password=" + password);

Notice that the code is getting both user AND password from
the property http.auth.basic. + challenge + .user. I believe that
it should get it from .password :)

 - Juho Mäkinen
Reply | Threaded
Open this post in threaded view
|

Re: Possible bug in protocol-httpclient -> HttpBasicAuthentication.java

Andrzej Białecki-2
Juho M?kinen wrote:

> At least in the lastets nightly build, in HttpBasicAuthentication of
> protocol-httpclient:
>
>         String username = NutchConf.get().get("http.auth.basic." +
> challenge + ".user");
>         LOG.fine("BasicAuthentication username=" + username);
>         String password = NutchConf.get().get("http.auth.basic." +
> challenge + ".user");
>         LOG.fine("BasicAuthentication password=" + password);
>
> Notice that the code is getting both user AND password from
> the property http.auth.basic. + challenge + .user. I believe that
> it should get it from .password :)

Yes, this looks like a bug - I'll fix this. Thank you!

--
Best regards,
Andrzej Bialecki     <><
  ___. ___ ___ ___ _ _   __________________________________
[__ || __|__/|__||\/|  Information Retrieval, Semantic Web
___|||__||  \|  ||  |  Embedded Unix, System Integration
http://www.sigram.com  Contact: info at sigram dot com