Re: [lucene-solr] branch master updated: Synchronizing 8.4.1 changes

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [lucene-solr] branch master updated: Synchronizing 8.4.1 changes

Jan Høydahl / Cominvent
Just a question about this commit.

These bug fixes released in 8.4.1 are also part of 8.5.0.

I thought we normally duplicated changes entries between a bugfix release and the next minor version to avoid having to look at release dates and guess whether the fixes are in the next minor or not.

Or I may remember wrong that we only follow this practice once we know that a lower version will be released after a higher version (e.g. 8.4.2 after 8.5.0).

Jan

> 22. jan. 2020 kl. 07:01 skrev [hidden email]:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> ishan pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/lucene-solr.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
>     new cc9c494  Synchronizing 8.4.1 changes
> cc9c494 is described below
>
> commit cc9c494a341d8f117b153145125a169bd8b95e6f
> Author: Ishan Chattopadhyaya <[hidden email]>
> AuthorDate: Wed Jan 22 11:31:12 2020 +0530
>
>    Synchronizing 8.4.1 changes
> ---
> solr/CHANGES.txt | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
> index 8a84b01..4d0a5da 100644
> --- a/solr/CHANGES.txt
> +++ b/solr/CHANGES.txt
> @@ -215,16 +215,10 @@ Bug Fixes
>
> * SOLR-14017: Ensure bin/solr's -q and -v options work with examples (Andy Vuong via Jason Gerlowski)
>
> -* SOLR-14106: Cleanup Jetty SslContextFactory usage (Ryan Rockenbaugh, Jan Hoydahl, Kevin Risden)
> -
> -* SOLR-14109: Always log to stdout from server/scripts/cloud-scripts/zkcli.{bat|sh} (janhoy)
> -
> * SOLR-14122: SimUtils converts v2 to v1 request params incorrectly. (Li Cao, ab)
>
> * SOLR-13089: Fix lsof edge cases in the solr CLI script (Martijn Koster via janhoy)
>
> -* SOLR-14163: SOLR_SSL_CLIENT_HOSTNAME_VERIFICATION needs to work with Jetty server/client SSL contexts (Kevin Risden)
> -
> * SOLR-6613: TextField.analyzeMultiTerm does not throw an exception when Analyzer returns no terms. (Bruno Roustant)
>
> * SOLR-14192: Race condition between SchemaManager and ZkIndexSchemaReader. (ab)
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [lucene-solr] branch master updated: Synchronizing 8.4.1 changes

Adrien Grand
Given that 8.5.0 is not released yet, moving these entries from 8.5 to 8.4.1 feels consistent with instructions we have on the wiki: https://cwiki.apache.org/confluence/display/lucene/ReleaseTodo#ReleaseTodo-SynchronizeCHANGES.txt. Indeed we would have duplicated entries if we were releasing 8.4.2 after 8.5.0.

On Wed, Jan 22, 2020 at 9:58 AM Jan Høydahl <[hidden email]> wrote:
Just a question about this commit.

These bug fixes released in 8.4.1 are also part of 8.5.0.

I thought we normally duplicated changes entries between a bugfix release and the next minor version to avoid having to look at release dates and guess whether the fixes are in the next minor or not.

Or I may remember wrong that we only follow this practice once we know that a lower version will be released after a higher version (e.g. 8.4.2 after 8.5.0).

Jan

> 22. jan. 2020 kl. 07:01 skrev [hidden email]:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> ishan pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/lucene-solr.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
>     new cc9c494  Synchronizing 8.4.1 changes
> cc9c494 is described below
>
> commit cc9c494a341d8f117b153145125a169bd8b95e6f
> Author: Ishan Chattopadhyaya <[hidden email]>
> AuthorDate: Wed Jan 22 11:31:12 2020 +0530
>
>    Synchronizing 8.4.1 changes
> ---
> solr/CHANGES.txt | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
> index 8a84b01..4d0a5da 100644
> --- a/solr/CHANGES.txt
> +++ b/solr/CHANGES.txt
> @@ -215,16 +215,10 @@ Bug Fixes
>
> * SOLR-14017: Ensure bin/solr's -q and -v options work with examples (Andy Vuong via Jason Gerlowski)
>
> -* SOLR-14106: Cleanup Jetty SslContextFactory usage (Ryan Rockenbaugh, Jan Hoydahl, Kevin Risden)
> -
> -* SOLR-14109: Always log to stdout from server/scripts/cloud-scripts/zkcli.{bat|sh} (janhoy)
> -
> * SOLR-14122: SimUtils converts v2 to v1 request params incorrectly. (Li Cao, ab)
>
> * SOLR-13089: Fix lsof edge cases in the solr CLI script (Martijn Koster via janhoy)
>
> -* SOLR-14163: SOLR_SSL_CLIENT_HOSTNAME_VERIFICATION needs to work with Jetty server/client SSL contexts (Kevin Risden)
> -
> * SOLR-6613: TextField.analyzeMultiTerm does not throw an exception when Analyzer returns no terms. (Bruno Roustant)
>
> * SOLR-14192: Race condition between SchemaManager and ZkIndexSchemaReader. (ab)
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]



--
Adrien
Reply | Threaded
Open this post in threaded view
|

Re: [lucene-solr] branch master updated: Synchronizing 8.4.1 changes

Jan Høydahl / Cominvent
I just realized that since the 8.4.1 section wlll actually be part of the 8.5.0 CHANGES file, there should be no doubt wrt this.

Thanks

22. jan. 2020 kl. 10:15 skrev Adrien Grand <[hidden email]>:

Given that 8.5.0 is not released yet, moving these entries from 8.5 to 8.4.1 feels consistent with instructions we have on the wiki: https://cwiki.apache.org/confluence/display/lucene/ReleaseTodo#ReleaseTodo-SynchronizeCHANGES.txt. Indeed we would have duplicated entries if we were releasing 8.4.2 after 8.5.0.

On Wed, Jan 22, 2020 at 9:58 AM Jan Høydahl <[hidden email]> wrote:
Just a question about this commit.

These bug fixes released in 8.4.1 are also part of 8.5.0.

I thought we normally duplicated changes entries between a bugfix release and the next minor version to avoid having to look at release dates and guess whether the fixes are in the next minor or not.

Or I may remember wrong that we only follow this practice once we know that a lower version will be released after a higher version (e.g. 8.4.2 after 8.5.0).

Jan

> 22. jan. 2020 kl. 07:01 skrev [hidden email]:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> ishan pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/lucene-solr.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
>     new cc9c494  Synchronizing 8.4.1 changes
> cc9c494 is described below
>
> commit cc9c494a341d8f117b153145125a169bd8b95e6f
> Author: Ishan Chattopadhyaya <[hidden email]>
> AuthorDate: Wed Jan 22 11:31:12 2020 +0530
>
>    Synchronizing 8.4.1 changes
> ---
> solr/CHANGES.txt | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
> index 8a84b01..4d0a5da 100644
> --- a/solr/CHANGES.txt
> +++ b/solr/CHANGES.txt
> @@ -215,16 +215,10 @@ Bug Fixes
>
> * SOLR-14017: Ensure bin/solr's -q and -v options work with examples (Andy Vuong via Jason Gerlowski)
>
> -* SOLR-14106: Cleanup Jetty SslContextFactory usage (Ryan Rockenbaugh, Jan Hoydahl, Kevin Risden)
> -
> -* SOLR-14109: Always log to stdout from server/scripts/cloud-scripts/zkcli.{bat|sh} (janhoy)
> -
> * SOLR-14122: SimUtils converts v2 to v1 request params incorrectly. (Li Cao, ab)
>
> * SOLR-13089: Fix lsof edge cases in the solr CLI script (Martijn Koster via janhoy)
>
> -* SOLR-14163: SOLR_SSL_CLIENT_HOSTNAME_VERIFICATION needs to work with Jetty server/client SSL contexts (Kevin Risden)
> -
> * SOLR-6613: TextField.analyzeMultiTerm does not throw an exception when Analyzer returns no terms. (Bruno Roustant)
>
> * SOLR-14192: Race condition between SchemaManager and ZkIndexSchemaReader. (ab)
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]



--
Adrien