Re: lucene-solr:jira/gradle: Parallel running tests

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: lucene-solr:jira/gradle: Parallel running tests

Gus Heck
I'm curious about the branch naming here. I notice this is jira/ and there are several other such heads in the repository. What's the convention or significance here for this jira/ prefix?

On Fri, Nov 2, 2018 at 6:12 AM <[hidden email]> wrote:
Repository: lucene-solr
Updated Branches:
  refs/heads/jira/gradle c9cb4fe96 -> 4a12fffb7


Parallel running tests


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/4a12fffb
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/4a12fffb
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/4a12fffb

Branch: refs/heads/jira/gradle
Commit: 4a12fffb751078c2dfdf427617dd5ed9c52c7378
Parents: c9cb4fe
Author: Cao Manh Dat <[hidden email]>
Authored: Fri Nov 2 10:11:47 2018 +0000
Committer: Cao Manh Dat <[hidden email]>
Committed: Fri Nov 2 10:11:47 2018 +0000

----------------------------------------------------------------------
 build.gradle | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/4a12fffb/build.gradle
----------------------------------------------------------------------
diff --git a/build.gradle b/build.gradle
index df21ce8..27a351d 100644
--- a/build.gradle
+++ b/build.gradle
@@ -30,6 +30,10 @@ subprojects {
                        systemProperty 'java.security.egd', 'file:/dev/./urandom'
                }
        }
+       tasks.withType(Test) {
+               maxParallelForks = Runtime.runtime.availableProcessors() / 2
+       }
+
 }

 // These versions are defined here because they represent
@@ -308,4 +312,4 @@ ext.library = [
        xz: "org.tukaani:xz:1.8",
        morfologik_ukrainian_search: "ua.net.nlp:morfologik-ukrainian-search:3.9.0",
        xercesImpl: "xerces:xercesImpl:2.9.1"
-]
\ No newline at end of file
+]



--
Reply | Threaded
Open this post in threaded view
|

Re: lucene-solr:jira/gradle: Parallel running tests

david.w.smiley@gmail.com
There's no real standard; just people doing what they like and observing what others do.

Note that commits to branches following the pattern (lucene|solr).*  (i.e. that which start with "lucene" or "solr") will *not* get an automated comment on corresponding JIRA issues.  All others continue to.  ASF infra got this done for us: https://issues.apache.org/jira/browse/INFRA-11198

I recommend you start a branch with "solr" or "SOLR" if you are going to work on a Solr issue.  This way if you merge in changes from master, you won't spam the related issues with comments.

~ David


On Fri, Nov 2, 2018 at 7:46 AM Gus Heck <[hidden email]> wrote:
I'm curious about the branch naming here. I notice this is jira/ and there are several other such heads in the repository. What's the convention or significance here for this jira/ prefix?

On Fri, Nov 2, 2018 at 6:12 AM <[hidden email]> wrote:
Repository: lucene-solr
Updated Branches:
  refs/heads/jira/gradle c9cb4fe96 -> 4a12fffb7


Parallel running tests


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/4a12fffb
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/4a12fffb
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/4a12fffb

Branch: refs/heads/jira/gradle
Commit: 4a12fffb751078c2dfdf427617dd5ed9c52c7378
Parents: c9cb4fe
Author: Cao Manh Dat <[hidden email]>
Authored: Fri Nov 2 10:11:47 2018 +0000
Committer: Cao Manh Dat <[hidden email]>
Committed: Fri Nov 2 10:11:47 2018 +0000

----------------------------------------------------------------------
 build.gradle | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/4a12fffb/build.gradle
----------------------------------------------------------------------
diff --git a/build.gradle b/build.gradle
index df21ce8..27a351d 100644
--- a/build.gradle
+++ b/build.gradle
@@ -30,6 +30,10 @@ subprojects {
                        systemProperty 'java.security.egd', 'file:/dev/./urandom'
                }
        }
+       tasks.withType(Test) {
+               maxParallelForks = Runtime.runtime.availableProcessors() / 2
+       }
+
 }

 // These versions are defined here because they represent
@@ -308,4 +312,4 @@ ext.library = [
        xz: "org.tukaani:xz:1.8",
        morfologik_ukrainian_search: "ua.net.nlp:morfologik-ukrainian-search:3.9.0",
        xercesImpl: "xerces:xercesImpl:2.9.1"
-]
\ No newline at end of file
+]



--
--
Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
Reply | Threaded
Open this post in threaded view
|

Re: lucene-solr:jira/gradle: Parallel running tests

Erick Erickson
It's not necessary to make a patch, especially if the change doesn't
need much collaboration. It's perfectly acceptable to make a patch and
attach it to the JIRA like the old days. Whichever you're most
comfortable with.

You've probably inferred that I'm one of the folks that had to be
dragged kicking and screaming into the modern Git days. ;)

Erick
On Fri, Nov 2, 2018 at 8:43 AM David Smiley <[hidden email]> wrote:

>
> There's no real standard; just people doing what they like and observing what others do.
>
> Note that commits to branches following the pattern (lucene|solr).*  (i.e. that which start with "lucene" or "solr") will *not* get an automated comment on corresponding JIRA issues.  All others continue to.  ASF infra got this done for us: https://issues.apache.org/jira/browse/INFRA-11198
>
> I recommend you start a branch with "solr" or "SOLR" if you are going to work on a Solr issue.  This way if you merge in changes from master, you won't spam the related issues with comments.
>
> ~ David
>
>
> On Fri, Nov 2, 2018 at 7:46 AM Gus Heck <[hidden email]> wrote:
>>
>> I'm curious about the branch naming here. I notice this is jira/ and there are several other such heads in the repository. What's the convention or significance here for this jira/ prefix?
>>
>> On Fri, Nov 2, 2018 at 6:12 AM <[hidden email]> wrote:
>>>
>>> Repository: lucene-solr
>>> Updated Branches:
>>>   refs/heads/jira/gradle c9cb4fe96 -> 4a12fffb7
>>>
>>>
>>> Parallel running tests
>>>
>>>
>>> Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
>>> Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/4a12fffb
>>> Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/4a12fffb
>>> Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/4a12fffb
>>>
>>> Branch: refs/heads/jira/gradle
>>> Commit: 4a12fffb751078c2dfdf427617dd5ed9c52c7378
>>> Parents: c9cb4fe
>>> Author: Cao Manh Dat <[hidden email]>
>>> Authored: Fri Nov 2 10:11:47 2018 +0000
>>> Committer: Cao Manh Dat <[hidden email]>
>>> Committed: Fri Nov 2 10:11:47 2018 +0000
>>>
>>> ----------------------------------------------------------------------
>>>  build.gradle | 6 +++++-
>>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>> ----------------------------------------------------------------------
>>>
>>>
>>> http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/4a12fffb/build.gradle
>>> ----------------------------------------------------------------------
>>> diff --git a/build.gradle b/build.gradle
>>> index df21ce8..27a351d 100644
>>> --- a/build.gradle
>>> +++ b/build.gradle
>>> @@ -30,6 +30,10 @@ subprojects {
>>>                         systemProperty 'java.security.egd', 'file:/dev/./urandom'
>>>                 }
>>>         }
>>> +       tasks.withType(Test) {
>>> +               maxParallelForks = Runtime.runtime.availableProcessors() / 2
>>> +       }
>>> +
>>>  }
>>>
>>>  // These versions are defined here because they represent
>>> @@ -308,4 +312,4 @@ ext.library = [
>>>         xz: "org.tukaani:xz:1.8",
>>>         morfologik_ukrainian_search: "ua.net.nlp:morfologik-ukrainian-search:3.9.0",
>>>         xercesImpl: "xerces:xercesImpl:2.9.1"
>>> -]
>>> \ No newline at end of file
>>> +]
>>>
>>
>>
>> --
>> http://www.the111shift.com
>
> --
> Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
> LinkedIn: http://linkedin.com/in/davidwsmiley | Book: http://www.solrenterprisesearchserver.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: lucene-solr:jira/gradle: Parallel running tests

Gus Heck
I generally like git, but It's not clear to me exactly how github is integrated/mirrored with the Apache git infrastructure, and if the flow is bidirectional or not... or whether or not listing my account in the Apache profile is sufficient to allow me additional privs there or not. (perhaps the answer is here https://www.apache.org/dev/new-committers-guide.html#checkout-the-committers-only-subversion-module , but that bit of karma seems to have not yet reached me). So for the time being I'll be using good old patches. The hint about solr.*  prefixes is good to know.

-Gus

On Fri, Nov 2, 2018 at 12:28 PM Erick Erickson <[hidden email]> wrote:
It's not necessary to make a patch, especially if the change doesn't
need much collaboration. It's perfectly acceptable to make a patch and
attach it to the JIRA like the old days. Whichever you're most
comfortable with.

You've probably inferred that I'm one of the folks that had to be
dragged kicking and screaming into the modern Git days. ;)

Erick
On Fri, Nov 2, 2018 at 8:43 AM David Smiley <[hidden email]> wrote:
>
> There's no real standard; just people doing what they like and observing what others do.
>
> Note that commits to branches following the pattern (lucene|solr).*  (i.e. that which start with "lucene" or "solr") will *not* get an automated comment on corresponding JIRA issues.  All others continue to.  ASF infra got this done for us: https://issues.apache.org/jira/browse/INFRA-11198
>
> I recommend you start a branch with "solr" or "SOLR" if you are going to work on a Solr issue.  This way if you merge in changes from master, you won't spam the related issues with comments.
>
> ~ David
>
>
> On Fri, Nov 2, 2018 at 7:46 AM Gus Heck <[hidden email]> wrote:
>>
>> I'm curious about the branch naming here. I notice this is jira/ and there are several other such heads in the repository. What's the convention or significance here for this jira/ prefix?
>>
>> On Fri, Nov 2, 2018 at 6:12 AM <[hidden email]> wrote:
>>>
>>> Repository: lucene-solr
>>> Updated Branches:
>>>   refs/heads/jira/gradle c9cb4fe96 -> 4a12fffb7
>>>
>>>
>>> Parallel running tests
>>>
>>>
>>> Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
>>> Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/4a12fffb
>>> Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/4a12fffb
>>> Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/4a12fffb
>>>
>>> Branch: refs/heads/jira/gradle
>>> Commit: 4a12fffb751078c2dfdf427617dd5ed9c52c7378
>>> Parents: c9cb4fe
>>> Author: Cao Manh Dat <[hidden email]>
>>> Authored: Fri Nov 2 10:11:47 2018 +0000
>>> Committer: Cao Manh Dat <[hidden email]>
>>> Committed: Fri Nov 2 10:11:47 2018 +0000
>>>
>>> ----------------------------------------------------------------------
>>>  build.gradle | 6 +++++-
>>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>> ----------------------------------------------------------------------
>>>
>>>
>>> http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/4a12fffb/build.gradle
>>> ----------------------------------------------------------------------
>>> diff --git a/build.gradle b/build.gradle
>>> index df21ce8..27a351d 100644
>>> --- a/build.gradle
>>> +++ b/build.gradle
>>> @@ -30,6 +30,10 @@ subprojects {
>>>                         systemProperty 'java.security.egd', 'file:/dev/./urandom'
>>>                 }
>>>         }
>>> +       tasks.withType(Test) {
>>> +               maxParallelForks = Runtime.runtime.availableProcessors() / 2
>>> +       }
>>> +
>>>  }
>>>
>>>  // These versions are defined here because they represent
>>> @@ -308,4 +312,4 @@ ext.library = [
>>>         xz: "org.tukaani:xz:1.8",
>>>         morfologik_ukrainian_search: "ua.net.nlp:morfologik-ukrainian-search:3.9.0",
>>>         xercesImpl: "xerces:xercesImpl:2.9.1"
>>> -]
>>> \ No newline at end of file
>>> +]
>>>
>>
>>
>> --
>> http://www.the111shift.com
>
> --
> Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
> LinkedIn: http://linkedin.com/in/davidwsmiley | Book: http://www.solrenterprisesearchserver.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]



--
Reply | Threaded
Open this post in threaded view
|

Re: lucene-solr:jira/gradle: Parallel running tests

Tomás Fernández Löbbe
My understanding is that the integration is not bidirectional (i.e. we can't use the "merge PR" green button in GitHub and make that a commit in the official repo). You can build PRs if you want, and then you can either turn that into a patch or cherry pick into the offical repo, but that's about all the integration you get AFAIK (other than auto-closing of PRs when a commit mentions a PR #).
I believe that if you add your @apache.org email to your profile in GitHub you are automatically added to the Apache org, though that doesn't give you much (or any) privileges in the repo, it's not really managed by us.


On Fri, Nov 2, 2018 at 5:56 PM Gus Heck <[hidden email]> wrote:
I generally like git, but It's not clear to me exactly how github is integrated/mirrored with the Apache git infrastructure, and if the flow is bidirectional or not... or whether or not listing my account in the Apache profile is sufficient to allow me additional privs there or not. (perhaps the answer is here https://www.apache.org/dev/new-committers-guide.html#checkout-the-committers-only-subversion-module , but that bit of karma seems to have not yet reached me). So for the time being I'll be using good old patches. The hint about solr.*  prefixes is good to know.

-Gus

On Fri, Nov 2, 2018 at 12:28 PM Erick Erickson <[hidden email]> wrote:
It's not necessary to make a patch, especially if the change doesn't
need much collaboration. It's perfectly acceptable to make a patch and
attach it to the JIRA like the old days. Whichever you're most
comfortable with.

You've probably inferred that I'm one of the folks that had to be
dragged kicking and screaming into the modern Git days. ;)

Erick
On Fri, Nov 2, 2018 at 8:43 AM David Smiley <[hidden email]> wrote:
>
> There's no real standard; just people doing what they like and observing what others do.
>
> Note that commits to branches following the pattern (lucene|solr).*  (i.e. that which start with "lucene" or "solr") will *not* get an automated comment on corresponding JIRA issues.  All others continue to.  ASF infra got this done for us: https://issues.apache.org/jira/browse/INFRA-11198
>
> I recommend you start a branch with "solr" or "SOLR" if you are going to work on a Solr issue.  This way if you merge in changes from master, you won't spam the related issues with comments.
>
> ~ David
>
>
> On Fri, Nov 2, 2018 at 7:46 AM Gus Heck <[hidden email]> wrote:
>>
>> I'm curious about the branch naming here. I notice this is jira/ and there are several other such heads in the repository. What's the convention or significance here for this jira/ prefix?
>>
>> On Fri, Nov 2, 2018 at 6:12 AM <[hidden email]> wrote:
>>>
>>> Repository: lucene-solr
>>> Updated Branches:
>>>   refs/heads/jira/gradle c9cb4fe96 -> 4a12fffb7
>>>
>>>
>>> Parallel running tests
>>>
>>>
>>> Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
>>> Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/4a12fffb
>>> Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/4a12fffb
>>> Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/4a12fffb
>>>
>>> Branch: refs/heads/jira/gradle
>>> Commit: 4a12fffb751078c2dfdf427617dd5ed9c52c7378
>>> Parents: c9cb4fe
>>> Author: Cao Manh Dat <[hidden email]>
>>> Authored: Fri Nov 2 10:11:47 2018 +0000
>>> Committer: Cao Manh Dat <[hidden email]>
>>> Committed: Fri Nov 2 10:11:47 2018 +0000
>>>
>>> ----------------------------------------------------------------------
>>>  build.gradle | 6 +++++-
>>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>> ----------------------------------------------------------------------
>>>
>>>
>>> http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/4a12fffb/build.gradle
>>> ----------------------------------------------------------------------
>>> diff --git a/build.gradle b/build.gradle
>>> index df21ce8..27a351d 100644
>>> --- a/build.gradle
>>> +++ b/build.gradle
>>> @@ -30,6 +30,10 @@ subprojects {
>>>                         systemProperty 'java.security.egd', 'file:/dev/./urandom'
>>>                 }
>>>         }
>>> +       tasks.withType(Test) {
>>> +               maxParallelForks = Runtime.runtime.availableProcessors() / 2
>>> +       }
>>> +
>>>  }
>>>
>>>  // These versions are defined here because they represent
>>> @@ -308,4 +312,4 @@ ext.library = [
>>>         xz: "org.tukaani:xz:1.8",
>>>         morfologik_ukrainian_search: "ua.net.nlp:morfologik-ukrainian-search:3.9.0",
>>>         xercesImpl: "xerces:xercesImpl:2.9.1"
>>> -]
>>> \ No newline at end of file
>>> +]
>>>
>>
>>
>> --
>> http://www.the111shift.com
>
> --
> Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
> LinkedIn: http://linkedin.com/in/davidwsmiley | Book: http://www.solrenterprisesearchserver.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]



--