Re: svn commit: r883522 - in /lucene/solr/trunk/src/java/org/apache/solr/search: ValueSourceParser.java function/ConstValueSource.java

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r883522 - in /lucene/solr/trunk/src/java/org/apache/solr/search: ValueSourceParser.java function/ConstValueSource.java

hossman

:    final long constant;
: +  final double dv;
: +  final float fv;

..can't the "final long constant" be removed completely now?


-Hoss

Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r883522 - in /lucene/solr/trunk/src/java/org/apache/solr/search: ValueSourceParser.java function/ConstValueSource.java

Yonik Seeley-2-2
On Mon, Nov 23, 2009 at 5:36 PM, Chris Hostetter
<[hidden email]> wrote:
> :    final long constant;
> : +  final double dv;
> : +  final float fv;
>
> ..can't the "final long constant" be removed completely now?

Some functions could actually use it - say like ms().
More could in the future if/when we type our value sources to avoid
precision loss (i.e. sub(longfield1,longfield2) would work in long
space, not float space).

-Yonik
http://www.lucidimagination.com
Reply | Threaded
Open this post in threaded view
|

Re: svn commit: r883522 - in /lucene/solr/trunk/src/java/org/apache/solr/search: ValueSourceParser.java function/ConstValueSource.java

hossman

: Some functions could actually use it - say like ms().
: More could in the future if/when we type our value sources to avoid
: precision loss (i.e. sub(longfield1,longfield2) would work in long
: space, not float space).

my bad ... i tuned out the fact that both new variables had different
types then the original.



-Hoss