SIP-4: Solr Resource Management API - please review

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

SIP-4: Solr Resource Management API - please review

Andrzej Białecki-2
Hi Solr devs,

I would appreciate feedback on the proposed design and implementation of the Resource Management API - please see SIP-4 [1] for details.

After several reviews I think that it’s more or less ready to commit (master only) but it’s a sizeable change and I’d hate to miss some obvious design flaw :)

Also, note that a chunk of the PR is a refactoring of the SolrMetricsContext that was required to support this API (now the “scope” is a part of the context instead of being kept separately).

Please leave code-related comments in PR #1100 [2], and other feedback in Jira SOLR-13579. Thank you!


[1] https://cwiki.apache.org/confluence/display/SOLR/SIP-4+Resource+management+framework
[2] https://github.com/apache/lucene-solr/pull/1100



Andrzej Białecki


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: SIP-4: Solr Resource Management API - please review

david.w.smiley@gmail.com
FYI I'm seriously interested in this but may not get to review until Friday.

~ David Smiley
Apache Lucene/Solr Search Developer


On Tue, Feb 4, 2020 at 6:50 AM Andrzej Białecki <[hidden email]> wrote:
Hi Solr devs,

I would appreciate feedback on the proposed design and implementation of the Resource Management API - please see SIP-4 [1] for details.

After several reviews I think that it’s more or less ready to commit (master only) but it’s a sizeable change and I’d hate to miss some obvious design flaw :)

Also, note that a chunk of the PR is a refactoring of the SolrMetricsContext that was required to support this API (now the “scope” is a part of the context instead of being kept separately).

Please leave code-related comments in PR #1100 [2], and other feedback in Jira SOLR-13579. Thank you!


[1] https://cwiki.apache.org/confluence/display/SOLR/SIP-4+Resource+management+framework
[2] https://github.com/apache/lucene-solr/pull/1100



Andrzej Białecki


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]