[VOTE] Release Lucene/Solr 7.3.0 RC1

classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Lucene/Solr 7.3.0 RC1

Alan Woodward-3
Please vote for release candidate 1 for Lucene/Solr 7.3.0

The artifacts can be downloaded from:

You can run the smoke tester directly with this command:


Here’s my +1
SUCCESS! [1:09:03.674472]
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Lucene/Solr 7.3.0 RC1

sarowe
+1

Docs, javadocs, and CHANGES look good.

Smoke tester says: SUCCESS! [0:54:11.928252]

--
Steve
www.lucidworks.com

> On Mar 26, 2018, at 10:06 AM, Alan Woodward <[hidden email]> wrote:
>
> Please vote for release candidate 1 for Lucene/Solr 7.3.0
>
> The artifacts can be downloaded from:
> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-7.3.0-RC1-reveb8a5a882f879a51389b5d43f74f3aceac9e68c9
>
> You can run the smoke tester directly with this command:
>
> python3 -u dev-tools/scripts/smokeTestRelease.py https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-7.3.0-RC1-reveb8a5a882f879a51389b5d43f74f3aceac9e68c9
>
> Here’s my +1
> SUCCESS! [1:09:03.674472]


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

RE: [VOTE] Release Lucene/Solr 7.3.0 RC1

Uwe Schindler
In reply to this post by Alan Woodward-3

Hi,

 

I did not run smoke tester, but I checked some more fancy stuff to be safe: I tried the JAR file (lucene-core.jar) with multiple Java versions and the MR-JAR feature worked with a quick “hack” (it creates a broken BytesRef and calls a method on it, the resulting Exception’s stack trace should have right methods):

 

*****************************************************

JAVA_HOME = C:\Program Files\Java\jdk1.8.0_144

java version "1.8.0_144"

Java(TM) SE Runtime Environment (build 1.8.0_144-b01)

Java HotSpot(TM) 64-Bit Server VM (build 25.144-b01, mixed mode)

*****************************************************

 

Microsoft Windows [Version 10.0.16299.334]

(c) 2017 Microsoft Corporation. Alle Rechte vorbehalten.

 

C:\Users\Uwe Schindler\Desktop\test>type Test.java

import org.apache.lucene.util.BytesRef;

public abstract class Test {

  public static void main(String... args) {

    BytesRef b1 = new BytesRef(new byte[0], 0, 10);

    BytesRef b2 = new BytesRef(20);

    b1.compareTo(b2);

  }

}

 

C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test

Exception in thread "main" java.lang.IndexOutOfBoundsException: Range [0, 10) out-of-bounds for length 0

        at org.apache.lucene.util.FutureArrays.checkFromToIndex(FutureArrays.java:45)

        at org.apache.lucene.util.FutureArrays.compareUnsigned(FutureArrays.java:72)

        at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)

        at Test.main(Test.java:7)

 

And now Java 9 / 10:

 

*****************************************************

JAVA_HOME = C:\Program Files\Java\jdk-9.0.1

java version "9.0.1"

Java(TM) SE Runtime Environment (build 9.0.1+11)

Java HotSpot(TM) 64-Bit Server VM (build 9.0.1+11, mixed mode)

*****************************************************

 

C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array index out of range: 10

        at java.base/java.util.Arrays.rangeCheck(Arrays.java:122)

        at java.base/java.util.Arrays.compareUnsigned(Arrays.java:6101)

        at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)

        at Test.main(Test.java:7)

 

*****************************************************

JAVA_HOME = C:\Program Files\Java\jdk-10

openjdk version "10" 2018-03-20

OpenJDK Runtime Environment 18.3 (build 10+46)

OpenJDK 64-Bit Server VM 18.3 (build 10+46, mixed mode)

*****************************************************

 

C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array index out of range: 10

        at java.base/java.util.Arrays.rangeCheck(Arrays.java:122)

        at java.base/java.util.Arrays.compareUnsigned(Arrays.java:6101)

        at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)

        at Test.main(Test.java:7)

 

So all looks fine from this perspective.

 

I then tested to start the techproducts example with Java 8, Java 9, Java 10:

 

Java 8 and 9 started up (yeah), but Java 10 failed (at least on windows) because of the braindead version parsing:

 

C:\Users\Uwe Schindler\Desktop\solr-7.3.0\bin>solr start -e techproducts

ERROR: Java 1.8 or later is required to run Solr. Current Java version is: 10

 

I will open an issue to fix this (or better: let’s simply remove the version check as it cannot be made safe with shell scripting).

 

**********************************************

So -1 to release if this also affects Linux (not yet tested).

**********************************************

 

Sorry,

Uwe

 

-----

Uwe Schindler

Achterdiek 19, D-28357 Bremen

http://www.thetaphi.de

eMail: [hidden email]

 

From: Alan Woodward <[hidden email]>
Sent: Monday, March 26, 2018 4:06 PM
To: [hidden email]
Subject: [VOTE] Release Lucene/Solr 7.3.0 RC1

 

Please vote for release candidate 1 for Lucene/Solr 7.3.0

 

The artifacts can be downloaded from:

 

You can run the smoke tester directly with this command:

 

 

Here’s my +1

SUCCESS! [1:09:03.674472]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Lucene/Solr 7.3.0 RC1

Mark Miller-3
Smoke test success: SUCCESS! [1:04:19.586886]

But +1 to fix running on Java 10.

- Mark

On Mon, Mar 26, 2018 at 1:37 PM Uwe Schindler <[hidden email]> wrote:

Hi,

 

I did not run smoke tester, but I checked some more fancy stuff to be safe: I tried the JAR file (lucene-core.jar) with multiple Java versions and the MR-JAR feature worked with a quick “hack” (it creates a broken BytesRef and calls a method on it, the resulting Exception’s stack trace should have right methods):

 

*****************************************************

JAVA_HOME = C:\Program Files\Java\jdk1.8.0_144

java version "1.8.0_144"

Java(TM) SE Runtime Environment (build 1.8.0_144-b01)

Java HotSpot(TM) 64-Bit Server VM (build 25.144-b01, mixed mode)

*****************************************************

 

Microsoft Windows [Version 10.0.16299.334]

(c) 2017 Microsoft Corporation. Alle Rechte vorbehalten.

 

C:\Users\Uwe Schindler\Desktop\test>type Test.java

import org.apache.lucene.util.BytesRef;

public abstract class Test {

  public static void main(String... args) {

    BytesRef b1 = new BytesRef(new byte[0], 0, 10);

    BytesRef b2 = new BytesRef(20);

    b1.compareTo(b2);

  }

}

 

C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test

Exception in thread "main" java.lang.IndexOutOfBoundsException: Range [0, 10) out-of-bounds for length 0

        at org.apache.lucene.util.FutureArrays.checkFromToIndex(FutureArrays.java:45)

        at org.apache.lucene.util.FutureArrays.compareUnsigned(FutureArrays.java:72)

        at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)

        at Test.main(Test.java:7)

 

And now Java 9 / 10:

 

*****************************************************

JAVA_HOME = C:\Program Files\Java\jdk-9.0.1

java version "9.0.1"

Java(TM) SE Runtime Environment (build 9.0.1+11)

Java HotSpot(TM) 64-Bit Server VM (build 9.0.1+11, mixed mode)

*****************************************************

 

C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array index out of range: 10

        at java.base/java.util.Arrays.rangeCheck(Arrays.java:122)

        at java.base/java.util.Arrays.compareUnsigned(Arrays.java:6101)

        at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)

        at Test.main(Test.java:7)

 

*****************************************************

JAVA_HOME = C:\Program Files\Java\jdk-10

openjdk version "10" 2018-03-20

OpenJDK Runtime Environment 18.3 (build 10+46)

OpenJDK 64-Bit Server VM 18.3 (build 10+46, mixed mode)

*****************************************************

 

C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array index out of range: 10

        at java.base/java.util.Arrays.rangeCheck(Arrays.java:122)

        at java.base/java.util.Arrays.compareUnsigned(Arrays.java:6101)

        at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)

        at Test.main(Test.java:7)

 

So all looks fine from this perspective.

 

I then tested to start the techproducts example with Java 8, Java 9, Java 10:

 

Java 8 and 9 started up (yeah), but Java 10 failed (at least on windows) because of the braindead version parsing:

 

C:\Users\Uwe Schindler\Desktop\solr-7.3.0\bin>solr start -e techproducts

ERROR: Java 1.8 or later is required to run Solr. Current Java version is: 10

 

I will open an issue to fix this (or better: let’s simply remove the version check as it cannot be made safe with shell scripting).

 

**********************************************

So -1 to release if this also affects Linux (not yet tested).

**********************************************

 

Sorry,

Uwe

 

 

From: Alan Woodward <[hidden email]>
Sent: Monday, March 26, 2018 4:06 PM
To: [hidden email]
Subject: [VOTE] Release Lucene/Solr 7.3.0 RC1

 

Please vote for release candidate 1 for Lucene/Solr 7.3.0

 

The artifacts can be downloaded from:

 

You can run the smoke tester directly with this command:

 

 

Here’s my +1

SUCCESS! [1:09:03.674472]

--
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Lucene/Solr 7.3.0 RC1

Dawid Weiss-2
Hmm... I got this one:

  File "dev-tools/scripts/smokeTestRelease.py", line 209, in checkJARMetaData
    raise RuntimeError('%s is missing one of "%s" inside its
META-INF/MANIFEST.MF' % (desc, verify))
RuntimeError: JAR file
"/tmp/smoke_lucene_7.3.0_eb8a5a882f879a51389b5d43f74f3aceac9e68c9/unpack/lucene-7.3.0/spatial3d/lucene-spatial3d-7.3.0.jar"
is missing one of "('Ant-Version: Apache Ant 1.8', 'Ant-Version:
Apache Ant 1.9')" inside its META-INF/MANIFEST.MF

The ant on that machine is a bit dated (1.8.2), but it's worked
before. The jar in question has this manifest entry:

Ant-Version: Apache Ant 1.10.1

I'm running smoke tester from branch_7_3 (eb8a5a882f879). Am I doing
something wrong here?

D.

On Mon, Mar 26, 2018 at 9:19 PM, Mark Miller <[hidden email]> wrote:

> Smoke test success: SUCCESS! [1:04:19.586886]
>
> But +1 to fix running on Java 10.
>
> - Mark
>
> On Mon, Mar 26, 2018 at 1:37 PM Uwe Schindler <[hidden email]> wrote:
>>
>> Hi,
>>
>>
>>
>> I did not run smoke tester, but I checked some more fancy stuff to be
>> safe: I tried the JAR file (lucene-core.jar) with multiple Java versions and
>> the MR-JAR feature worked with a quick “hack” (it creates a broken BytesRef
>> and calls a method on it, the resulting Exception’s stack trace should have
>> right methods):
>>
>>
>>
>> *****************************************************
>>
>> JAVA_HOME = C:\Program Files\Java\jdk1.8.0_144
>>
>> java version "1.8.0_144"
>>
>> Java(TM) SE Runtime Environment (build 1.8.0_144-b01)
>>
>> Java HotSpot(TM) 64-Bit Server VM (build 25.144-b01, mixed mode)
>>
>> *****************************************************
>>
>>
>>
>> Microsoft Windows [Version 10.0.16299.334]
>>
>> (c) 2017 Microsoft Corporation. Alle Rechte vorbehalten.
>>
>>
>>
>> C:\Users\Uwe Schindler\Desktop\test>type Test.java
>>
>> import org.apache.lucene.util.BytesRef;
>>
>> public abstract class Test {
>>
>>   public static void main(String... args) {
>>
>>     BytesRef b1 = new BytesRef(new byte[0], 0, 10);
>>
>>     BytesRef b2 = new BytesRef(20);
>>
>>     b1.compareTo(b2);
>>
>>   }
>>
>> }
>>
>>
>>
>> C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test
>>
>> Exception in thread "main" java.lang.IndexOutOfBoundsException: Range [0,
>> 10) out-of-bounds for length 0
>>
>>         at
>> org.apache.lucene.util.FutureArrays.checkFromToIndex(FutureArrays.java:45)
>>
>>         at
>> org.apache.lucene.util.FutureArrays.compareUnsigned(FutureArrays.java:72)
>>
>>         at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)
>>
>>         at Test.main(Test.java:7)
>>
>>
>>
>> And now Java 9 / 10:
>>
>>
>>
>> *****************************************************
>>
>> JAVA_HOME = C:\Program Files\Java\jdk-9.0.1
>>
>> java version "9.0.1"
>>
>> Java(TM) SE Runtime Environment (build 9.0.1+11)
>>
>> Java HotSpot(TM) 64-Bit Server VM (build 9.0.1+11, mixed mode)
>>
>> *****************************************************
>>
>>
>>
>> C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test
>>
>> Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array
>> index out of range: 10
>>
>>         at java.base/java.util.Arrays.rangeCheck(Arrays.java:122)
>>
>>         at java.base/java.util.Arrays.compareUnsigned(Arrays.java:6101)
>>
>>         at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)
>>
>>         at Test.main(Test.java:7)
>>
>>
>>
>> *****************************************************
>>
>> JAVA_HOME = C:\Program Files\Java\jdk-10
>>
>> openjdk version "10" 2018-03-20
>>
>> OpenJDK Runtime Environment 18.3 (build 10+46)
>>
>> OpenJDK 64-Bit Server VM 18.3 (build 10+46, mixed mode)
>>
>> *****************************************************
>>
>>
>>
>> C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test
>>
>> Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array
>> index out of range: 10
>>
>>         at java.base/java.util.Arrays.rangeCheck(Arrays.java:122)
>>
>>         at java.base/java.util.Arrays.compareUnsigned(Arrays.java:6101)
>>
>>         at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)
>>
>>         at Test.main(Test.java:7)
>>
>>
>>
>> So all looks fine from this perspective.
>>
>>
>>
>> I then tested to start the techproducts example with Java 8, Java 9, Java
>> 10:
>>
>>
>>
>> Java 8 and 9 started up (yeah), but Java 10 failed (at least on windows)
>> because of the braindead version parsing:
>>
>>
>>
>> C:\Users\Uwe Schindler\Desktop\solr-7.3.0\bin>solr start -e techproducts
>>
>> ERROR: Java 1.8 or later is required to run Solr. Current Java version is:
>> 10
>>
>>
>>
>> I will open an issue to fix this (or better: let’s simply remove the
>> version check as it cannot be made safe with shell scripting).
>>
>>
>>
>> **********************************************
>>
>> So -1 to release if this also affects Linux (not yet tested).
>>
>> **********************************************
>>
>>
>>
>> Sorry,
>>
>> Uwe
>>
>>
>>
>> -----
>>
>> Uwe Schindler
>>
>> Achterdiek 19, D-28357 Bremen
>>
>> http://www.thetaphi.de
>>
>> eMail: [hidden email]
>>
>>
>>
>> From: Alan Woodward <[hidden email]>
>> Sent: Monday, March 26, 2018 4:06 PM
>> To: [hidden email]
>> Subject: [VOTE] Release Lucene/Solr 7.3.0 RC1
>>
>>
>>
>> Please vote for release candidate 1 for Lucene/Solr 7.3.0
>>
>>
>>
>> The artifacts can be downloaded from:
>>
>>
>> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-7.3.0-RC1-reveb8a5a882f879a51389b5d43f74f3aceac9e68c9
>>
>>
>>
>> You can run the smoke tester directly with this command:
>>
>>
>>
>> python3 -u dev-tools/scripts/smokeTestRelease.py
>> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-7.3.0-RC1-reveb8a5a882f879a51389b5d43f74f3aceac9e68c9
>>
>>
>>
>> Here’s my +1
>>
>> SUCCESS! [1:09:03.674472]
>
> --
> - Mark
> about.me/markrmiller

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Lucene/Solr 7.3.0 RC1

Alan Woodward-3
I committed something today to allow running with ant 1.10.1, but of course that will now have the wrong git SHA.  It looks like we’ll need a respin anyway for Java 10, so things should match properly once that’s done.

> On 26 Mar 2018, at 20:41, Dawid Weiss <[hidden email]> wrote:
>
> Hmm... I got this one:
>
>  File "dev-tools/scripts/smokeTestRelease.py", line 209, in checkJARMetaData
>    raise RuntimeError('%s is missing one of "%s" inside its
> META-INF/MANIFEST.MF' % (desc, verify))
> RuntimeError: JAR file
> "/tmp/smoke_lucene_7.3.0_eb8a5a882f879a51389b5d43f74f3aceac9e68c9/unpack/lucene-7.3.0/spatial3d/lucene-spatial3d-7.3.0.jar"
> is missing one of "('Ant-Version: Apache Ant 1.8', 'Ant-Version:
> Apache Ant 1.9')" inside its META-INF/MANIFEST.MF
>
> The ant on that machine is a bit dated (1.8.2), but it's worked
> before. The jar in question has this manifest entry:
>
> Ant-Version: Apache Ant 1.10.1
>
> I'm running smoke tester from branch_7_3 (eb8a5a882f879). Am I doing
> something wrong here?
>
> D.
>
> On Mon, Mar 26, 2018 at 9:19 PM, Mark Miller <[hidden email]> wrote:
>> Smoke test success: SUCCESS! [1:04:19.586886]
>>
>> But +1 to fix running on Java 10.
>>
>> - Mark
>>
>> On Mon, Mar 26, 2018 at 1:37 PM Uwe Schindler <[hidden email]> wrote:
>>>
>>> Hi,
>>>
>>>
>>>
>>> I did not run smoke tester, but I checked some more fancy stuff to be
>>> safe: I tried the JAR file (lucene-core.jar) with multiple Java versions and
>>> the MR-JAR feature worked with a quick “hack” (it creates a broken BytesRef
>>> and calls a method on it, the resulting Exception’s stack trace should have
>>> right methods):
>>>
>>>
>>>
>>> *****************************************************
>>>
>>> JAVA_HOME = C:\Program Files\Java\jdk1.8.0_144
>>>
>>> java version "1.8.0_144"
>>>
>>> Java(TM) SE Runtime Environment (build 1.8.0_144-b01)
>>>
>>> Java HotSpot(TM) 64-Bit Server VM (build 25.144-b01, mixed mode)
>>>
>>> *****************************************************
>>>
>>>
>>>
>>> Microsoft Windows [Version 10.0.16299.334]
>>>
>>> (c) 2017 Microsoft Corporation. Alle Rechte vorbehalten.
>>>
>>>
>>>
>>> C:\Users\Uwe Schindler\Desktop\test>type Test.java
>>>
>>> import org.apache.lucene.util.BytesRef;
>>>
>>> public abstract class Test {
>>>
>>>  public static void main(String... args) {
>>>
>>>    BytesRef b1 = new BytesRef(new byte[0], 0, 10);
>>>
>>>    BytesRef b2 = new BytesRef(20);
>>>
>>>    b1.compareTo(b2);
>>>
>>>  }
>>>
>>> }
>>>
>>>
>>>
>>> C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test
>>>
>>> Exception in thread "main" java.lang.IndexOutOfBoundsException: Range [0,
>>> 10) out-of-bounds for length 0
>>>
>>>        at
>>> org.apache.lucene.util.FutureArrays.checkFromToIndex(FutureArrays.java:45)
>>>
>>>        at
>>> org.apache.lucene.util.FutureArrays.compareUnsigned(FutureArrays.java:72)
>>>
>>>        at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)
>>>
>>>        at Test.main(Test.java:7)
>>>
>>>
>>>
>>> And now Java 9 / 10:
>>>
>>>
>>>
>>> *****************************************************
>>>
>>> JAVA_HOME = C:\Program Files\Java\jdk-9.0.1
>>>
>>> java version "9.0.1"
>>>
>>> Java(TM) SE Runtime Environment (build 9.0.1+11)
>>>
>>> Java HotSpot(TM) 64-Bit Server VM (build 9.0.1+11, mixed mode)
>>>
>>> *****************************************************
>>>
>>>
>>>
>>> C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test
>>>
>>> Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array
>>> index out of range: 10
>>>
>>>        at java.base/java.util.Arrays.rangeCheck(Arrays.java:122)
>>>
>>>        at java.base/java.util.Arrays.compareUnsigned(Arrays.java:6101)
>>>
>>>        at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)
>>>
>>>        at Test.main(Test.java:7)
>>>
>>>
>>>
>>> *****************************************************
>>>
>>> JAVA_HOME = C:\Program Files\Java\jdk-10
>>>
>>> openjdk version "10" 2018-03-20
>>>
>>> OpenJDK Runtime Environment 18.3 (build 10+46)
>>>
>>> OpenJDK 64-Bit Server VM 18.3 (build 10+46, mixed mode)
>>>
>>> *****************************************************
>>>
>>>
>>>
>>> C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test
>>>
>>> Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array
>>> index out of range: 10
>>>
>>>        at java.base/java.util.Arrays.rangeCheck(Arrays.java:122)
>>>
>>>        at java.base/java.util.Arrays.compareUnsigned(Arrays.java:6101)
>>>
>>>        at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)
>>>
>>>        at Test.main(Test.java:7)
>>>
>>>
>>>
>>> So all looks fine from this perspective.
>>>
>>>
>>>
>>> I then tested to start the techproducts example with Java 8, Java 9, Java
>>> 10:
>>>
>>>
>>>
>>> Java 8 and 9 started up (yeah), but Java 10 failed (at least on windows)
>>> because of the braindead version parsing:
>>>
>>>
>>>
>>> C:\Users\Uwe Schindler\Desktop\solr-7.3.0\bin>solr start -e techproducts
>>>
>>> ERROR: Java 1.8 or later is required to run Solr. Current Java version is:
>>> 10
>>>
>>>
>>>
>>> I will open an issue to fix this (or better: let’s simply remove the
>>> version check as it cannot be made safe with shell scripting).
>>>
>>>
>>>
>>> **********************************************
>>>
>>> So -1 to release if this also affects Linux (not yet tested).
>>>
>>> **********************************************
>>>
>>>
>>>
>>> Sorry,
>>>
>>> Uwe
>>>
>>>
>>>
>>> -----
>>>
>>> Uwe Schindler
>>>
>>> Achterdiek 19, D-28357 Bremen
>>>
>>> http://www.thetaphi.de
>>>
>>> eMail: [hidden email]
>>>
>>>
>>>
>>> From: Alan Woodward <[hidden email]>
>>> Sent: Monday, March 26, 2018 4:06 PM
>>> To: [hidden email]
>>> Subject: [VOTE] Release Lucene/Solr 7.3.0 RC1
>>>
>>>
>>>
>>> Please vote for release candidate 1 for Lucene/Solr 7.3.0
>>>
>>>
>>>
>>> The artifacts can be downloaded from:
>>>
>>>
>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-7.3.0-RC1-reveb8a5a882f879a51389b5d43f74f3aceac9e68c9
>>>
>>>
>>>
>>> You can run the smoke tester directly with this command:
>>>
>>>
>>>
>>> python3 -u dev-tools/scripts/smokeTestRelease.py
>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-7.3.0-RC1-reveb8a5a882f879a51389b5d43f74f3aceac9e68c9
>>>
>>>
>>>
>>> Here’s my +1
>>>
>>> SUCCESS! [1:09:03.674472]
>>
>> --
>> - Mark
>> about.me/markrmiller
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Lucene/Solr 7.3.0 RC1

Dawid Weiss-2
Hi Alan,

I noticed your ant-related commit, but wondered how this passed for
everyone else -- did you guys run smoke tester from branch_7x?
Shouldn't we use the actual version's branch for this?

D.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Lucene/Solr 7.3.0 RC1

Anshum Gupta-3
In reply to this post by Uwe Schindler
This does affect Mac as well, so I’m pretty sure same is the case with everything *nix.

 Anshum




On Mar 26, 2018, at 11:36 AM, Uwe Schindler <[hidden email]> wrote:

Hi,
 
I did not run smoke tester, but I checked some more fancy stuff to be safe: I tried the JAR file (lucene-core.jar) with multiple Java versions and the MR-JAR feature worked with a quick “hack” (it creates a broken BytesRef and calls a method on it, the resulting Exception’s stack trace should have right methods):
 
*****************************************************
JAVA_HOME = C:\Program Files\Java\jdk1.8.0_144
java version "1.8.0_144"
Java(TM) SE Runtime Environment (build 1.8.0_144-b01)
Java HotSpot(TM) 64-Bit Server VM (build 25.144-b01, mixed mode)
*****************************************************
 
Microsoft Windows [Version 10.0.16299.334]
(c) 2017 Microsoft Corporation. Alle Rechte vorbehalten.
 
C:\Users\Uwe Schindler\Desktop\test>type Test.java
import org.apache.lucene.util.BytesRef;
public abstract class Test {
  public static void main(String... args) {
    BytesRef b1 = new BytesRef(new byte[0], 0, 10);
    BytesRef b2 = new BytesRef(20);
    b1.compareTo(b2);
  }
}
 
C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test
Exception in thread "main" java.lang.IndexOutOfBoundsException: Range [0, 10) out-of-bounds for length 0
        at org.apache.lucene.util.FutureArrays.checkFromToIndex(FutureArrays.java:45)
        at org.apache.lucene.util.FutureArrays.compareUnsigned(FutureArrays.java:72)
        at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)
        at Test.main(Test.java:7)
 
And now Java 9 / 10:
 
*****************************************************
JAVA_HOME = C:\Program Files\Java\jdk-9.0.1
java version "9.0.1"
Java(TM) SE Runtime Environment (build 9.0.1+11)
Java HotSpot(TM) 64-Bit Server VM (build 9.0.1+11, mixed mode)
*****************************************************
 
C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array index out of range: 10
        at java.base/java.util.Arrays.rangeCheck(Arrays.java:122)
        at java.base/java.util.Arrays.compareUnsigned(Arrays.java:6101)
        at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)
        at Test.main(Test.java:7)
 
*****************************************************
JAVA_HOME = C:\Program Files\Java\jdk-10
openjdk version "10" 2018-03-20
OpenJDK Runtime Environment 18.3 (build 10+46)
OpenJDK 64-Bit Server VM 18.3 (build 10+46, mixed mode)
*****************************************************
 
C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array index out of range: 10
        at java.base/java.util.Arrays.rangeCheck(Arrays.java:122)
        at java.base/java.util.Arrays.compareUnsigned(Arrays.java:6101)
        at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)
        at Test.main(Test.java:7)
 
So all looks fine from this perspective.
 
I then tested to start the techproducts example with Java 8, Java 9, Java 10:
 
Java 8 and 9 started up (yeah), but Java 10 failed (at least on windows) because of the braindead version parsing:
 
C:\Users\Uwe Schindler\Desktop\solr-7.3.0\bin>solr start -e techproducts
ERROR: Java 1.8 or later is required to run Solr. Current Java version is: 10
 
I will open an issue to fix this (or better: let’s simply remove the version check as it cannot be made safe with shell scripting).
 
**********************************************
So -1 to release if this also affects Linux (not yet tested).
**********************************************
 
Sorry,
Uwe
 
-----
Uwe Schindler
Achterdiek 19, D-28357 Bremen
 
From: Alan Woodward <[hidden email]> 
Sent: Monday, March 26, 2018 4:06 PM
To: [hidden email]
Subject: [VOTE] Release Lucene/Solr 7.3.0 RC1
 
Please vote for release candidate 1 for Lucene/Solr 7.3.0
 
The artifacts can be downloaded from:
 
You can run the smoke tester directly with this command:
 
 
Here’s my +1
SUCCESS! [1:09:03.674472]


signature.asc (891 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Lucene/Solr 7.3.0 RC1

sarowe
The smoke tester succeeded for me using branch_7_3 at SHA a494138 (after Alan’s commit allowing ant 1.10), on Linux using ant 1.9.4.

--
Steve
www.lucidworks.com

> On Mar 26, 2018, at 4:04 PM, Anshum Gupta <[hidden email]> wrote:
>
> This does affect Mac as well, so I’m pretty sure same is the case with everything *nix.
>
>  Anshum
>
>
>
>
>> On Mar 26, 2018, at 11:36 AM, Uwe Schindler <[hidden email]> wrote:
>>
>> Hi,
>>  
>> I did not run smoke tester, but I checked some more fancy stuff to be safe: I tried the JAR file (lucene-core.jar) with multiple Java versions and the MR-JAR feature worked with a quick “hack” (it creates a broken BytesRef and calls a method on it, the resulting Exception’s stack trace should have right methods):
>>  
>> *****************************************************
>> JAVA_HOME = C:\Program Files\Java\jdk1.8.0_144
>> java version "1.8.0_144"
>> Java(TM) SE Runtime Environment (build 1.8.0_144-b01)
>> Java HotSpot(TM) 64-Bit Server VM (build 25.144-b01, mixed mode)
>> *****************************************************
>>  
>> Microsoft Windows [Version 10.0.16299.334]
>> (c) 2017 Microsoft Corporation. Alle Rechte vorbehalten.
>>  
>> C:\Users\Uwe Schindler\Desktop\test>type Test.java
>> import org.apache.lucene.util.BytesRef;
>> public abstract class Test {
>>   public static void main(String... args) {
>>     BytesRef b1 = new BytesRef(new byte[0], 0, 10);
>>     BytesRef b2 = new BytesRef(20);
>>     b1.compareTo(b2);
>>   }
>> }
>>  
>> C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test
>> Exception in thread "main" java.lang.IndexOutOfBoundsException: Range [0, 10) out-of-bounds for length 0
>>         at org.apache.lucene.util.FutureArrays.checkFromToIndex(FutureArrays.java:45)
>>         at org.apache.lucene.util.FutureArrays.compareUnsigned(FutureArrays.java:72)
>>         at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)
>>         at Test.main(Test.java:7)
>>  
>> And now Java 9 / 10:
>>  
>> *****************************************************
>> JAVA_HOME = C:\Program Files\Java\jdk-9.0.1
>> java version "9.0.1"
>> Java(TM) SE Runtime Environment (build 9.0.1+11)
>> Java HotSpot(TM) 64-Bit Server VM (build 9.0.1+11, mixed mode)
>> *****************************************************
>>  
>> C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test
>> Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array index out of range: 10
>>         at java.base/java.util.Arrays.rangeCheck(Arrays.java:122)
>>         at java.base/java.util.Arrays.compareUnsigned(Arrays.java:6101)
>>         at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)
>>         at Test.main(Test.java:7)
>>  
>> *****************************************************
>> JAVA_HOME = C:\Program Files\Java\jdk-10
>> openjdk version "10" 2018-03-20
>> OpenJDK Runtime Environment 18.3 (build 10+46)
>> OpenJDK 64-Bit Server VM 18.3 (build 10+46, mixed mode)
>> *****************************************************
>>  
>> C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test
>> Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array index out of range: 10
>>         at java.base/java.util.Arrays.rangeCheck(Arrays.java:122)
>>         at java.base/java.util.Arrays.compareUnsigned(Arrays.java:6101)
>>         at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)
>>         at Test.main(Test.java:7)
>>  
>> So all looks fine from this perspective.
>>  
>> I then tested to start the techproducts example with Java 8, Java 9, Java 10:
>>  
>> Java 8 and 9 started up (yeah), but Java 10 failed (at least on windows) because of the braindead version parsing:
>>  
>> C:\Users\Uwe Schindler\Desktop\solr-7.3.0\bin>solr start -e techproducts
>> ERROR: Java 1.8 or later is required to run Solr. Current Java version is: 10
>>  
>> I will open an issue to fix this (or better: let’s simply remove the version check as it cannot be made safe with shell scripting).
>>  
>> **********************************************
>> So -1 to release if this also affects Linux (not yet tested).
>> **********************************************
>>  
>> Sorry,
>> Uwe
>>  
>> -----
>> Uwe Schindler
>> Achterdiek 19, D-28357 Bremen
>> http://www.thetaphi.de
>> eMail: [hidden email]
>>  
>> From: Alan Woodward <[hidden email]>
>> Sent: Monday, March 26, 2018 4:06 PM
>> To: [hidden email]
>> Subject: [VOTE] Release Lucene/Solr 7.3.0 RC1
>>  
>> Please vote for release candidate 1 for Lucene/Solr 7.3.0
>>  
>> The artifacts can be downloaded from:
>> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-7.3.0-RC1-reveb8a5a882f879a51389b5d43f74f3aceac9e68c9
>>  
>> You can run the smoke tester directly with this command:
>>  
>> python3 -u dev-tools/scripts/smokeTestRelease.py https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-7.3.0-RC1-reveb8a5a882f879a51389b5d43f74f3aceac9e68c9
>>  
>> Here’s my +1
>> SUCCESS! [1:09:03.674472]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Lucene/Solr 7.3.0 RC1

Dawid Weiss-2
Ah, bummer. I know what my problem was (I didn't have all the
up-to-date changes, wrong commit, long story). Thanks Steve.

Dawid

On Mon, Mar 26, 2018 at 10:09 PM, Steve Rowe <[hidden email]> wrote:

> The smoke tester succeeded for me using branch_7_3 at SHA a494138 (after Alan’s commit allowing ant 1.10), on Linux using ant 1.9.4.
>
> --
> Steve
> www.lucidworks.com
>
>> On Mar 26, 2018, at 4:04 PM, Anshum Gupta <[hidden email]> wrote:
>>
>> This does affect Mac as well, so I’m pretty sure same is the case with everything *nix.
>>
>>  Anshum
>>
>>
>>
>>
>>> On Mar 26, 2018, at 11:36 AM, Uwe Schindler <[hidden email]> wrote:
>>>
>>> Hi,
>>>
>>> I did not run smoke tester, but I checked some more fancy stuff to be safe: I tried the JAR file (lucene-core.jar) with multiple Java versions and the MR-JAR feature worked with a quick “hack” (it creates a broken BytesRef and calls a method on it, the resulting Exception’s stack trace should have right methods):
>>>
>>> *****************************************************
>>> JAVA_HOME = C:\Program Files\Java\jdk1.8.0_144
>>> java version "1.8.0_144"
>>> Java(TM) SE Runtime Environment (build 1.8.0_144-b01)
>>> Java HotSpot(TM) 64-Bit Server VM (build 25.144-b01, mixed mode)
>>> *****************************************************
>>>
>>> Microsoft Windows [Version 10.0.16299.334]
>>> (c) 2017 Microsoft Corporation. Alle Rechte vorbehalten.
>>>
>>> C:\Users\Uwe Schindler\Desktop\test>type Test.java
>>> import org.apache.lucene.util.BytesRef;
>>> public abstract class Test {
>>>   public static void main(String... args) {
>>>     BytesRef b1 = new BytesRef(new byte[0], 0, 10);
>>>     BytesRef b2 = new BytesRef(20);
>>>     b1.compareTo(b2);
>>>   }
>>> }
>>>
>>> C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test
>>> Exception in thread "main" java.lang.IndexOutOfBoundsException: Range [0, 10) out-of-bounds for length 0
>>>         at org.apache.lucene.util.FutureArrays.checkFromToIndex(FutureArrays.java:45)
>>>         at org.apache.lucene.util.FutureArrays.compareUnsigned(FutureArrays.java:72)
>>>         at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)
>>>         at Test.main(Test.java:7)
>>>
>>> And now Java 9 / 10:
>>>
>>> *****************************************************
>>> JAVA_HOME = C:\Program Files\Java\jdk-9.0.1
>>> java version "9.0.1"
>>> Java(TM) SE Runtime Environment (build 9.0.1+11)
>>> Java HotSpot(TM) 64-Bit Server VM (build 9.0.1+11, mixed mode)
>>> *****************************************************
>>>
>>> C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test
>>> Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array index out of range: 10
>>>         at java.base/java.util.Arrays.rangeCheck(Arrays.java:122)
>>>         at java.base/java.util.Arrays.compareUnsigned(Arrays.java:6101)
>>>         at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)
>>>         at Test.main(Test.java:7)
>>>
>>> *****************************************************
>>> JAVA_HOME = C:\Program Files\Java\jdk-10
>>> openjdk version "10" 2018-03-20
>>> OpenJDK Runtime Environment 18.3 (build 10+46)
>>> OpenJDK 64-Bit Server VM 18.3 (build 10+46, mixed mode)
>>> *****************************************************
>>>
>>> C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test
>>> Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array index out of range: 10
>>>         at java.base/java.util.Arrays.rangeCheck(Arrays.java:122)
>>>         at java.base/java.util.Arrays.compareUnsigned(Arrays.java:6101)
>>>         at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)
>>>         at Test.main(Test.java:7)
>>>
>>> So all looks fine from this perspective.
>>>
>>> I then tested to start the techproducts example with Java 8, Java 9, Java 10:
>>>
>>> Java 8 and 9 started up (yeah), but Java 10 failed (at least on windows) because of the braindead version parsing:
>>>
>>> C:\Users\Uwe Schindler\Desktop\solr-7.3.0\bin>solr start -e techproducts
>>> ERROR: Java 1.8 or later is required to run Solr. Current Java version is: 10
>>>
>>> I will open an issue to fix this (or better: let’s simply remove the version check as it cannot be made safe with shell scripting).
>>>
>>> **********************************************
>>> So -1 to release if this also affects Linux (not yet tested).
>>> **********************************************
>>>
>>> Sorry,
>>> Uwe
>>>
>>> -----
>>> Uwe Schindler
>>> Achterdiek 19, D-28357 Bremen
>>> http://www.thetaphi.de
>>> eMail: [hidden email]
>>>
>>> From: Alan Woodward <[hidden email]>
>>> Sent: Monday, March 26, 2018 4:06 PM
>>> To: [hidden email]
>>> Subject: [VOTE] Release Lucene/Solr 7.3.0 RC1
>>>
>>> Please vote for release candidate 1 for Lucene/Solr 7.3.0
>>>
>>> The artifacts can be downloaded from:
>>> https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-7.3.0-RC1-reveb8a5a882f879a51389b5d43f74f3aceac9e68c9
>>>
>>> You can run the smoke tester directly with this command:
>>>
>>> python3 -u dev-tools/scripts/smokeTestRelease.py https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-7.3.0-RC1-reveb8a5a882f879a51389b5d43f74f3aceac9e68c9
>>>
>>> Here’s my +1
>>> SUCCESS! [1:09:03.674472]
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Lucene/Solr 7.3.0 RC1

Mikhail Khludnev-2
In reply to this post by Alan Woodward-3

SUCCESS! [1:42:33.742651]




On Mon, Mar 26, 2018 at 5:06 PM, Alan Woodward <[hidden email]> wrote:
Please vote for release candidate 1 for Lucene/Solr 7.3.0

The artifacts can be downloaded from:

You can run the smoke tester directly with this command:


Here’s my +1
SUCCESS! [1:09:03.674472]



--
Sincerely yours
Mikhail Khludnev
Reply | Threaded
Open this post in threaded view
|

RE: [VOTE] Release Lucene/Solr 7.3.0 RC1

Uwe Schindler
In reply to this post by Mark Miller-3

Hi,

 

I fixed the Windows and Linux shell scripts to correctly parse the major version and use numerical comparisons instead of alphabetical string compare.

 

In fact, both - Windows and Linux/Mac - did not work at all caused by more or less the same issue (“10” < “9” if compared alphabetically, while the Linux script did not even use the major version part it compared “10” < “1.8”). On top of the version parsing issue, the script used a GC option which was deprecated and a no-op since Java 9, which was finally removed in Java 10: -XX:+UseParNewGC (this is obsolete as CMS collector automatically uses it so there is no reason to pass it in any Post-Java7 VM). So I removed this option.

 

The issue is here, I’ll commit shortly: https://issues.apache.org/jira/browse/SOLR-12141

 

Uwe

 

-----

Uwe Schindler

Achterdiek 19, D-28357 Bremen

http://www.thetaphi.de

eMail: [hidden email]

 

From: Mark Miller <[hidden email]>
Sent: Monday, March 26, 2018 9:20 PM
To: [hidden email]
Subject: Re: [VOTE] Release Lucene/Solr 7.3.0 RC1

 

Smoke test success: SUCCESS! [1:04:19.586886]

 

But +1 to fix running on Java 10.

 

- Mark

 

On Mon, Mar 26, 2018 at 1:37 PM Uwe Schindler <[hidden email]> wrote:

Hi,

 

I did not run smoke tester, but I checked some more fancy stuff to be safe: I tried the JAR file (lucene-core.jar) with multiple Java versions and the MR-JAR feature worked with a quick “hack” (it creates a broken BytesRef and calls a method on it, the resulting Exception’s stack trace should have right methods):

 

*****************************************************

JAVA_HOME = C:\Program Files\Java\jdk1.8.0_144

java version "1.8.0_144"

Java(TM) SE Runtime Environment (build 1.8.0_144-b01)

Java HotSpot(TM) 64-Bit Server VM (build 25.144-b01, mixed mode)

*****************************************************

 

Microsoft Windows [Version 10.0.16299.334]

(c) 2017 Microsoft Corporation. Alle Rechte vorbehalten.

 

C:\Users\Uwe Schindler\Desktop\test>type Test.java

import org.apache.lucene.util.BytesRef;

public abstract class Test {

  public static void main(String... args) {

    BytesRef b1 = new BytesRef(new byte[0], 0, 10);

    BytesRef b2 = new BytesRef(20);

    b1.compareTo(b2);

  }

}

 

C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test

Exception in thread "main" java.lang.IndexOutOfBoundsException: Range [0, 10) out-of-bounds for length 0

        at org.apache.lucene.util.FutureArrays.checkFromToIndex(FutureArrays.java:45)

        at org.apache.lucene.util.FutureArrays.compareUnsigned(FutureArrays.java:72)

        at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)

        at Test.main(Test.java:7)

 

And now Java 9 / 10:

 

*****************************************************

JAVA_HOME = C:\Program Files\Java\jdk-9.0.1

java version "9.0.1"

Java(TM) SE Runtime Environment (build 9.0.1+11)

Java HotSpot(TM) 64-Bit Server VM (build 9.0.1+11, mixed mode)

*****************************************************

 

C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array index out of range: 10

        at java.base/java.util.Arrays.rangeCheck(Arrays.java:122)

        at java.base/java.util.Arrays.compareUnsigned(Arrays.java:6101)

        at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)

        at Test.main(Test.java:7)

 

*****************************************************

JAVA_HOME = C:\Program Files\Java\jdk-10

openjdk version "10" 2018-03-20

OpenJDK Runtime Environment 18.3 (build 10+46)

OpenJDK 64-Bit Server VM 18.3 (build 10+46, mixed mode)

*****************************************************

 

C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array index out of range: 10

        at java.base/java.util.Arrays.rangeCheck(Arrays.java:122)

        at java.base/java.util.Arrays.compareUnsigned(Arrays.java:6101)

        at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)

        at Test.main(Test.java:7)

 

So all looks fine from this perspective.

 

I then tested to start the techproducts example with Java 8, Java 9, Java 10:

 

Java 8 and 9 started up (yeah), but Java 10 failed (at least on windows) because of the braindead version parsing:

 

C:\Users\Uwe Schindler\Desktop\solr-7.3.0\bin>solr start -e techproducts

ERROR: Java 1.8 or later is required to run Solr. Current Java version is: 10

 

I will open an issue to fix this (or better: let’s simply remove the version check as it cannot be made safe with shell scripting).

 

**********************************************

So -1 to release if this also affects Linux (not yet tested).

**********************************************

 

Sorry,

Uwe

 

 

From: Alan Woodward <[hidden email]>
Sent: Monday, March 26, 2018 4:06 PM
To: [hidden email]
Subject: [VOTE] Release Lucene/Solr 7.3.0 RC1

 

Please vote for release candidate 1 for Lucene/Solr 7.3.0

 

The artifacts can be downloaded from:

 

You can run the smoke tester directly with this command:

 

 

Here’s my +1

SUCCESS! [1:09:03.674472]

--

Reply | Threaded
Open this post in threaded view
|

RE: [VOTE] Release Lucene/Solr 7.3.0 RC1

Uwe Schindler

It’s pushed to 7.3.

 

Uwe

 

-----

Uwe Schindler

Achterdiek 19, D-28357 Bremen

http://www.thetaphi.de

eMail: [hidden email]

 

From: Uwe Schindler <[hidden email]>
Sent: Tuesday, March 27, 2018 12:21 PM
To: [hidden email]
Subject: RE: [VOTE] Release Lucene/Solr 7.3.0 RC1

 

Hi,

 

I fixed the Windows and Linux shell scripts to correctly parse the major version and use numerical comparisons instead of alphabetical string compare.

 

In fact, both - Windows and Linux/Mac - did not work at all caused by more or less the same issue (“10” < “9” if compared alphabetically, while the Linux script did not even use the major version part it compared “10” < “1.8”). On top of the version parsing issue, the script used a GC option which was deprecated and a no-op since Java 9, which was finally removed in Java 10: -XX:+UseParNewGC (this is obsolete as CMS collector automatically uses it so there is no reason to pass it in any Post-Java7 VM). So I removed this option.

 

The issue is here, I’ll commit shortly: https://issues.apache.org/jira/browse/SOLR-12141

 

Uwe

 

-----

Uwe Schindler

Achterdiek 19, D-28357 Bremen

http://www.thetaphi.de

eMail: [hidden email]

 

From: Mark Miller <[hidden email]>
Sent: Monday, March 26, 2018 9:20 PM
To: [hidden email]
Subject: Re: [VOTE] Release Lucene/Solr 7.3.0 RC1

 

Smoke test success: SUCCESS! [1:04:19.586886]

 

But +1 to fix running on Java 10.

 

- Mark

 

On Mon, Mar 26, 2018 at 1:37 PM Uwe Schindler <[hidden email]> wrote:

Hi,

 

I did not run smoke tester, but I checked some more fancy stuff to be safe: I tried the JAR file (lucene-core.jar) with multiple Java versions and the MR-JAR feature worked with a quick “hack” (it creates a broken BytesRef and calls a method on it, the resulting Exception’s stack trace should have right methods):

 

*****************************************************

JAVA_HOME = C:\Program Files\Java\jdk1.8.0_144

java version "1.8.0_144"

Java(TM) SE Runtime Environment (build 1.8.0_144-b01)

Java HotSpot(TM) 64-Bit Server VM (build 25.144-b01, mixed mode)

*****************************************************

 

Microsoft Windows [Version 10.0.16299.334]

(c) 2017 Microsoft Corporation. Alle Rechte vorbehalten.

 

C:\Users\Uwe Schindler\Desktop\test>type Test.java

import org.apache.lucene.util.BytesRef;

public abstract class Test {

  public static void main(String... args) {

    BytesRef b1 = new BytesRef(new byte[0], 0, 10);

    BytesRef b2 = new BytesRef(20);

    b1.compareTo(b2);

  }

}

 

C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test

Exception in thread "main" java.lang.IndexOutOfBoundsException: Range [0, 10) out-of-bounds for length 0

        at org.apache.lucene.util.FutureArrays.checkFromToIndex(FutureArrays.java:45)

        at org.apache.lucene.util.FutureArrays.compareUnsigned(FutureArrays.java:72)

        at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)

        at Test.main(Test.java:7)

 

And now Java 9 / 10:

 

*****************************************************

JAVA_HOME = C:\Program Files\Java\jdk-9.0.1

java version "9.0.1"

Java(TM) SE Runtime Environment (build 9.0.1+11)

Java HotSpot(TM) 64-Bit Server VM (build 9.0.1+11, mixed mode)

*****************************************************

 

C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array index out of range: 10

        at java.base/java.util.Arrays.rangeCheck(Arrays.java:122)

        at java.base/java.util.Arrays.compareUnsigned(Arrays.java:6101)

        at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)

        at Test.main(Test.java:7)

 

*****************************************************

JAVA_HOME = C:\Program Files\Java\jdk-10

openjdk version "10" 2018-03-20

OpenJDK Runtime Environment 18.3 (build 10+46)

OpenJDK 64-Bit Server VM 18.3 (build 10+46, mixed mode)

*****************************************************

 

C:\Users\Uwe Schindler\Desktop\test>java -cp lucene-core-7.3.0.jar;. Test

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array index out of range: 10

        at java.base/java.util.Arrays.rangeCheck(Arrays.java:122)

        at java.base/java.util.Arrays.compareUnsigned(Arrays.java:6101)

        at org.apache.lucene.util.BytesRef.compareTo(BytesRef.java:163)

        at Test.main(Test.java:7)

 

So all looks fine from this perspective.

 

I then tested to start the techproducts example with Java 8, Java 9, Java 10:

 

Java 8 and 9 started up (yeah), but Java 10 failed (at least on windows) because of the braindead version parsing:

 

C:\Users\Uwe Schindler\Desktop\solr-7.3.0\bin>solr start -e techproducts

ERROR: Java 1.8 or later is required to run Solr. Current Java version is: 10

 

I will open an issue to fix this (or better: let’s simply remove the version check as it cannot be made safe with shell scripting).

 

**********************************************

So -1 to release if this also affects Linux (not yet tested).

**********************************************

 

Sorry,

Uwe

 

 

From: Alan Woodward <[hidden email]>
Sent: Monday, March 26, 2018 4:06 PM
To: [hidden email]
Subject: [VOTE] Release Lucene/Solr 7.3.0 RC1

 

Please vote for release candidate 1 for Lucene/Solr 7.3.0

 

The artifacts can be downloaded from:

 

You can run the smoke tester directly with this command:

 

 

Here’s my +1

SUCCESS! [1:09:03.674472]

--