ant precommit fails on .adoc files

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

ant precommit fails on .adoc files

s_ge
Hi All

 

I've checked out lucene-solr project, branch "branch_8x"

 

When I run "ant precommit" at project root, I get these validation errors on "analytics.adoc" file.  Has anyone seen these before, and if you knew of a fix?

 

My env

 - windows 10 pro

 - jdk 1,8_221

 - ant 1.10.6 compiled on May 2 201

 

Below is the error in console.

 

Thanks!

Steve

 

 

----------------------

 

rat-sources-typedef:

[ivy:cachepath] :: resolving dependencies :: org.apache.rat#apache-rat-caller;working [not transitive]

[ivy:cachepath]         confs: [master]

[ivy:cachepath]         found org.apache.rat#apache-rat;0.11 in public

[ivy:cachepath] :: resolution report :: resolve 46ms :: artifacts dl 1ms

        ---------------------------------------------------------------------

        |                  |            modules            ||   artifacts   |

        |       conf       | number| search|dwnlded|evicted|| number|dwnlded|

        ---------------------------------------------------------------------

        |      master      |   1   |   0   |   0   |   0   ||   1   |   0   |

        ---------------------------------------------------------------------

 

validate-source-patterns:

[source-patterns] Unescaped symbol "->" on line #46: solr/solr-ref-guide/src/analytics.adoc

[source-patterns] Unescaped symbol "->" on line #55: solr/solr-ref-guide/src/analytics.adoc

 

BUILD FAILED

C:\development\workspace-eclipse-photon\loc-projects\lucene-solr-cdg\build.xml:128: Found 2 violations in source files (Unescaped symbol "->" on line #46, Unescaped symbol "->" on line #55).

 

Total time: 25 seconds

 

 

Reply | Threaded
Open this post in threaded view
|

Re: ant precommit fails on .adoc files

Chris Hostetter-3

This is strange -- I can't reproduce, and I can't see any evidence of a
change to explain why this might have been failing 8 days ago but not any
more.

Are you still seeing this error?

The lines in question are XML comments inside of (example) code blocks (in
the ref-guide source), which is valid and the
'checkForUnescapedSymbolSubstitutions' groovy function that generates the
error below already has allowances for this posibility.

(normally putting '->' in asciidoctor source files is a bad idea and
renders as giberish, which is why we have this check)


I wonder if it's possible that something in the local ENV where you are
running ant is causing the groovy regex patterns to be evaluated
differently? (ie: mismatched unix/windows line endings, LANG that doesn't
use UTF-8, etc...)




: I've checked out lucene-solr project, branch "branch_8x"

: When I run "ant precommit" at project root, I get these validation
: errors on "analytics.adoc" file.  Has anyone seen these before, and if
: you knew of a fix?

: validate-source-patterns:
:
: [source-patterns] Unescaped symbol "->" on line #46: solr/solr-ref-guide/src/analytics.adoc
:
: [source-patterns] Unescaped symbol "->" on line #55: solr/solr-ref-guide/src/analytics.adoc


-Hoss
http://www.lucidworks.com/