control test temp dir used in common-build.xml

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

control test temp dir used in common-build.xml

Simon Willnauer
hey folks,

I'd like to control the tempDir used to execute junit tests from the
outside. Any objections to the patch below?


diff --git a/lucene/common-build.xml b/lucene/common-build.xml
index 47d5013..2c8f144 100644
--- a/lucene/common-build.xml
+++ b/lucene/common-build.xml
@@ -95,6 +95,7 @@
   <property name="tests.verbose" value="false"/>
   <property name="tests.infostream" value="${tests.verbose}"/>
   <property name="tests.heapsize" value="512M"/>
+       <property name="tests.tempDir" value="${build.dir}/test"/>

   <!-- Override these in your local properties to your desire. -->
   <!-- Show simple class names (no package) in test suites. -->
@@ -705,7 +706,7 @@
     <attribute name="junit.output.dir" default="${junit.output.dir}"/>
     <attribute name="junit.classpath" default="junit.classpath"/>
     <attribute name="testsDir" default="${build.dir}/classes/test"/>
-    <attribute name="tempDir" default="${build.dir}/test"/>
+    <attribute name="tempDir" default="${tests.tempDir}"/>
     <attribute name="threadNum" default="1"/>
     <attribute name="tests.nightly" default="${tests.nightly}"/>
     <attribute name="tests.weekly" default="${tests.weekly}"/>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: control test temp dir used in common-build.xml

Dawid Weiss
I don't mind but why do we need a specific property (other than Java's
default temporary file location property)? Perhaps it'd be better to
just use that?

Dawid

On Thu, Jun 21, 2012 at 1:08 PM, Simon Willnauer
<[hidden email]> wrote:

> hey folks,
>
> I'd like to control the tempDir used to execute junit tests from the
> outside. Any objections to the patch below?
>
>
> diff --git a/lucene/common-build.xml b/lucene/common-build.xml
> index 47d5013..2c8f144 100644
> --- a/lucene/common-build.xml
> +++ b/lucene/common-build.xml
> @@ -95,6 +95,7 @@
>   <property name="tests.verbose" value="false"/>
>   <property name="tests.infostream" value="${tests.verbose}"/>
>   <property name="tests.heapsize" value="512M"/>
> +       <property name="tests.tempDir" value="${build.dir}/test"/>
>
>   <!-- Override these in your local properties to your desire. -->
>   <!-- Show simple class names (no package) in test suites. -->
> @@ -705,7 +706,7 @@
>     <attribute name="junit.output.dir" default="${junit.output.dir}"/>
>     <attribute name="junit.classpath" default="junit.classpath"/>
>     <attribute name="testsDir" default="${build.dir}/classes/test"/>
> -    <attribute name="tempDir" default="${build.dir}/test"/>
> +    <attribute name="tempDir" default="${tests.tempDir}"/>
>     <attribute name="threadNum" default="1"/>
>     <attribute name="tests.nightly" default="${tests.nightly}"/>
>     <attribute name="tests.weekly" default="${tests.weekly}"/>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: control test temp dir used in common-build.xml

Simon Willnauer
On Thu, Jun 21, 2012 at 1:12 PM, Dawid Weiss
<[hidden email]> wrote:
> I don't mind but why do we need a specific property (other than Java's
> default temporary file location property)? Perhaps it'd be better to
> just use that?

tests create directories in that one currently something like
${tempDir}/S0/someindex
I am running multiple instance of a test on the same checkout and that
somethimes fails there for some reason
I am controlling java.io.tmpDir too

simon

>
> Dawid
>
> On Thu, Jun 21, 2012 at 1:08 PM, Simon Willnauer
> <[hidden email]> wrote:
>> hey folks,
>>
>> I'd like to control the tempDir used to execute junit tests from the
>> outside. Any objections to the patch below?
>>
>>
>> diff --git a/lucene/common-build.xml b/lucene/common-build.xml
>> index 47d5013..2c8f144 100644
>> --- a/lucene/common-build.xml
>> +++ b/lucene/common-build.xml
>> @@ -95,6 +95,7 @@
>>   <property name="tests.verbose" value="false"/>
>>   <property name="tests.infostream" value="${tests.verbose}"/>
>>   <property name="tests.heapsize" value="512M"/>
>> +       <property name="tests.tempDir" value="${build.dir}/test"/>
>>
>>   <!-- Override these in your local properties to your desire. -->
>>   <!-- Show simple class names (no package) in test suites. -->
>> @@ -705,7 +706,7 @@
>>     <attribute name="junit.output.dir" default="${junit.output.dir}"/>
>>     <attribute name="junit.classpath" default="junit.classpath"/>
>>     <attribute name="testsDir" default="${build.dir}/classes/test"/>
>> -    <attribute name="tempDir" default="${build.dir}/test"/>
>> +    <attribute name="tempDir" default="${tests.tempDir}"/>
>>     <attribute name="threadNum" default="1"/>
>>     <attribute name="tests.nightly" default="${tests.nightly}"/>
>>     <attribute name="tests.weekly" default="${tests.weekly}"/>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: control test temp dir used in common-build.xml

Dawid Weiss
> ${tempDir}/S0/someindex
> I am running multiple instance of a test on the same checkout and that
> somethimes fails there for some reason I am controlling java.io.tmpDir too

Yep, this will be a problem if you're running two parallel "ant test"
thingies. All the other intermediate junit4 files are prefixed with a
pretty unique timestamp but forked jvm subfolders are not. I was
debating whether they should be a longer while and came to a
conclusion that shorter paths will be easier to digest (and
interpret).

D.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]