[jira] [Commented] (LUCENE-5187) Make SlowCompositeReaderWrapper constructor private

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-5187) Make SlowCompositeReaderWrapper constructor private

Clark Perkins (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-5187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13749711#comment-13749711 ]

Michael McCandless commented on LUCENE-5187:
--------------------------------------------

+1 to commit, those grouping tests are fine if the wrapping doesn't happen (because the reader already happened to be atomic).
               

> Make SlowCompositeReaderWrapper constructor private
> ---------------------------------------------------
>
>                 Key: LUCENE-5187
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5187
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-5187.patch
>
>
> I found a couple of places in the code base that duplicate the logic of SlowCompositeReaderWrapper.wrap. I think {{SlowCompositeReaderWrapper.wrap}} (vs. new SlowCompositeReaderWrapper) is what users need so we should probably make SlowCompositeReaderWrapper constructor private to enforce usage of {{wrap}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]