[jira] [Commented] (LUCENE-8950) FieldComparators Should Not Maintain Implicit PQs

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (LUCENE-8950) FieldComparators Should Not Maintain Implicit PQs

Shalin Shekhar Mangar (Jira)

    [ https://issues.apache.org/jira/browse/LUCENE-8950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907090#comment-16907090 ]

Adrien Grand commented on LUCENE-8950:
--------------------------------------

OK I got confused with the notion of deprecation, which suggests to me that we need to find a replacement, but reading your last message, my understanding is that you would like to introduce a sub class of FieldComparator that hides the fact that it maintains an implicit PQ, and make simple comparators extend this sub class instead of FieldComparator directly? I would be +1 to giving it a try and making the change if the perf hit is negligible.

> FieldComparators Should Not Maintain Implicit PQs
> -------------------------------------------------
>
>                 Key: LUCENE-8950
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8950
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Atri Sharma
>            Priority: Major
>
> While doing some perf tests, I realised that FieldComparators inherently maintain implicit priority queues for maintaining the sorted order of documents for the given sort order. This is wasteful especially in the case of a multi feature sort order and a large number of hits requested.
>  
> We should change this to have FieldComparators maintain only the top and bottom values, and use them as barriers to compare



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]