[jira] [Commented] (NUTCH-2649) Optionally skip TLS/SSL certificate validation for protocol-selenium and protocol-htmlunit

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (NUTCH-2649) Optionally skip TLS/SSL certificate validation for protocol-selenium and protocol-htmlunit

Tim Allison (Jira)

    [ https://issues.apache.org/jira/browse/NUTCH-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17019023#comment-17019023 ]

ASF GitHub Bot commented on NUTCH-2649:
---------------------------------------

sebastian-nagel commented on pull request #496: Fix for NUTCH-2649: Optionally skip TLS/SSL certificate validation fo…
URL: https://github.com/apache/nutch/pull/496#discussion_r368319047
 
 

 ##########
 File path: src/plugin/protocol-htmlunit/src/java/org/apache/nutch/protocol/htmlunit/HttpResponse.java
 ##########
 @@ -272,6 +288,8 @@ public HttpResponse(HttpBase http, URL url, CrawlDatum datum)
         }
       }
 
+    }catch(Exception e) {
 
 Review comment:
   The plugin must throw an exception when something goes wrong so that the calling instance (usually the Fetcher) can handle the exception. You need to catch the SSL-related exceptions (when initializing the trust manager) and rethrow them as ProtocolException.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


> Optionally skip TLS/SSL certificate validation for protocol-selenium and protocol-htmlunit
> ------------------------------------------------------------------------------------------
>
>                 Key: NUTCH-2649
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2649
>             Project: Nutch
>          Issue Type: Improvement
>          Components: protocol
>    Affects Versions: 1.15
>            Reporter: Sebastian Nagel
>            Assignee: Shashanka Balakuntala Srinivasa
>            Priority: Minor
>             Fix For: 1.17
>
>
> NUTCH-2648 adds a property to enable/disable the TLS/SSL certificate validation for protocol-http, protocol-httpclient and protocol-okhttp. It should be also supported by remaining protocol plugins:
> * protocol-selenium,
> * protocol-interactiveselenium and
> * protocol-htmlunit



--
This message was sent by Atlassian Jira
(v8.3.4#803005)