[jira] [Commented] (NUTCH-2774) Annotate methods implementing the Hadoop API by @Override

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (NUTCH-2774) Annotate methods implementing the Hadoop API by @Override

Chris Mattmann (Jira)

    [ https://issues.apache.org/jira/browse/NUTCH-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17047864#comment-17047864 ]

ASF GitHub Bot commented on NUTCH-2774:
---------------------------------------

sebastian-nagel commented on pull request #502: NUTCH-2774 Annotate methods implementing the Hadoop API by @Override
URL: https://github.com/apache/nutch/pull/502
 
 
   - annotate classes implementing Hadoop interfaces
   - annotate few classes implementing Nutch interfaces
   - remove empty method implementations when super classes already provide a default implementation
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


> Annotate methods implementing the Hadoop API by @Override
> ---------------------------------------------------------
>
>                 Key: NUTCH-2774
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2774
>             Project: Nutch
>          Issue Type: Improvement
>    Affects Versions: 1.16
>            Reporter: Sebastian Nagel
>            Priority: Major
>             Fix For: 1.17
>
>
> Methods which implement or override the Hadoop API should always be annotated using @Override. This will help to avoid that methods are not called accidentally because the method name or signature do not match the current API.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)