[jira] [Commented] (NUTCH-2774) Annotate methods implementing the Hadoop API by @Override

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (NUTCH-2774) Annotate methods implementing the Hadoop API by @Override

Chris Mattmann (Jira)

    [ https://issues.apache.org/jira/browse/NUTCH-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058581#comment-17058581 ]

Hudson commented on NUTCH-2774:
-------------------------------

SUCCESS: Integrated in Jenkins build Nutch-trunk #3667 (See [https://builds.apache.org/job/Nutch-trunk/3667/])
NUTCH-2774 Annotate methods implementing the Hadoop API by @Override - (snagel: [https://github.com/apache/nutch/commit/22e668dcbbbc41e1a9d0c0304cc08e87be581e9c])
* (edit) src/java/org/apache/nutch/parse/ParserChecker.java
* (edit) src/java/org/apache/nutch/crawl/LinkDbReader.java
* (edit) src/java/org/apache/nutch/scoring/webgraph/LinkRank.java
* (edit) src/java/org/apache/nutch/crawl/CrawlDbReader.java
* (edit) src/java/org/apache/nutch/crawl/CrawlDbReducer.java
* (edit) src/java/org/apache/nutch/tools/warc/WARCExporter.java
* (edit) src/java/org/apache/nutch/segment/SegmentMerger.java
* (edit) src/java/org/apache/nutch/util/ProtocolStatusStatistics.java
* (edit) src/java/org/apache/nutch/crawl/DeduplicationJob.java
* (edit) src/java/org/apache/nutch/indexer/IndexerMapReduce.java
* (edit) src/java/org/apache/nutch/crawl/Generator.java
* (edit) src/java/org/apache/nutch/parse/ParseSegment.java
* (edit) src/java/org/apache/nutch/net/URLNormalizerChecker.java
* (edit) src/java/org/apache/nutch/crawl/CrawlDbMerger.java
* (edit) src/java/org/apache/nutch/indexer/IndexingJob.java
* (edit) src/java/org/apache/nutch/scoring/webgraph/WebGraph.java
* (edit) src/java/org/apache/nutch/hostdb/ReadHostDb.java
* (edit) src/java/org/apache/nutch/parse/ParseOutputFormat.java
* (edit) src/java/org/apache/nutch/crawl/CrawlDbFilter.java
* (edit) src/java/org/apache/nutch/crawl/LinkDb.java
* (edit) src/java/org/apache/nutch/util/SitemapProcessor.java
* (edit) src/plugin/indexer-dummy/src/java/org/apache/nutch/indexwriter/dummy/DummyIndexWriter.java
* (edit) src/java/org/apache/nutch/crawl/Injector.java
* (edit) src/java/org/apache/nutch/scoring/webgraph/LinkDumper.java
* (edit) src/java/org/apache/nutch/crawl/URLPartitioner.java
* (edit) src/java/org/apache/nutch/crawl/LinkDbMerger.java
* (edit) src/java/org/apache/nutch/scoring/webgraph/ScoreUpdater.java
* (edit) src/java/org/apache/nutch/crawl/LinkDbFilter.java
* (edit) src/java/org/apache/nutch/net/URLFilterChecker.java
* (edit) src/java/org/apache/nutch/tools/Benchmark.java
* (edit) src/java/org/apache/nutch/indexer/CleaningJob.java
* (edit) src/java/org/apache/nutch/tools/FreeGenerator.java
* (edit) src/plugin/indexer-solr/src/java/org/apache/nutch/indexwriter/solr/SolrIndexWriter.java
* (edit) src/java/org/apache/nutch/crawl/CrawlDb.java
* (edit) src/java/org/apache/nutch/fetcher/Fetcher.java
* (edit) src/java/org/apache/nutch/util/CrawlCompletionStats.java
* (edit) src/java/org/apache/nutch/scoring/webgraph/NodeDumper.java
* (edit) src/java/org/apache/nutch/hostdb/UpdateHostDb.java
* (edit) src/java/org/apache/nutch/util/domain/DomainStatistics.java
* (edit) src/java/org/apache/nutch/indexer/IndexingFiltersChecker.java


> Annotate methods implementing the Hadoop API by @Override
> ---------------------------------------------------------
>
>                 Key: NUTCH-2774
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2774
>             Project: Nutch
>          Issue Type: Improvement
>    Affects Versions: 1.16
>            Reporter: Sebastian Nagel
>            Assignee: Sebastian Nagel
>            Priority: Major
>             Fix For: 1.17
>
>
> Methods which implement or override the Hadoop API should always be annotated using @Override. This will help to avoid that methods are not called accidentally because the method name or signature do not match the current API.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)