[jira] [Commented] (NUTCH-2811) Setup Github workflows for PR

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (NUTCH-2811) Setup Github workflows for PR

ASF GitHub Bot (Jira)

    [ https://issues.apache.org/jira/browse/NUTCH-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17168953#comment-17168953 ]

ASF GitHub Bot commented on NUTCH-2811:
---------------------------------------

balashashanka commented on a change in pull request #543:
URL: https://github.com/apache/nutch/pull/543#discussion_r463688556



##########
File path: .github/workflows/master-build.yml
##########
@@ -0,0 +1,36 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: master pr build
+
+on: [push, pull_request]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        java: [ '1.8' ]
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up JDK ${{ matrix.java }}
+        uses: actions/setup-java@v1
+        with:
+          java-version: ${{ matrix.java }}
+      - name: Build with Ant
+        run: ant clean nightly javadoc -buildfile build.xml

Review comment:
       Do we need to generate javadoc here? Or just nightly will do?

##########
File path: .github/workflows/master-build.yml
##########
@@ -0,0 +1,36 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: master pr build
+
+on: [push, pull_request]

Review comment:
       Hi @madhawa-gunasekara, the check runs well. But When i tried it in own repo [here ](https://github.com/balashashanka/nutch/tree/NUTCH-2181) and [here](https://github.com/balashashanka/nutch/pull/1). For a PR same check is ran twice. So may be run this only for PR or split this to run check on master after merge and for a PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


> Setup Github workflows for PR
> -----------------------------
>
>                 Key: NUTCH-2811
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2811
>             Project: Nutch
>          Issue Type: New Feature
>          Components: build, test
>            Reporter: Shashanka Balakuntala Srinivasa
>            Priority: Minor
>              Labels: task
>
> Create a workflow[1] in the git repository for incoming PR merging with the master. As reference we can have this[2] which was setup for GORA. 
>  
> [1] - [https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions]
> [2] - [https://github.com/apache/gora/tree/master/.github/workflows]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)